Update signatures and comment for clarity

src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioWorkspaceImpl.cs

@@ -1697,6 +1697,7 @@ private void ConvertProjectReferencesToMetadataReferences_NoLock(ProjectId proje
             {
                 var referenceInfo = GetReferenceInfo_NoLock(projectIdToRetarget);
 
+                // Update ConvertedProjectReferences in place to avoid duplicate list allocations
                 for (var i = 0; i < referenceInfo.ConvertedProjectReferences.Count; i++)
                 {
                     var convertedReference = referenceInfo.ConvertedProjectReferences[i];

src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs

@@ -1821,31 +1821,31 @@ public ImmutableArray<DocumentId> GetDocumentIdsWithFilePath(string? filePath)
                     continue;
                 }
 
-                builder.Add(id, CanReuse() ? tracker : tracker.Fork(tracker.ProjectState));
+                builder.Add(id, CanReuse(id) ? tracker : tracker.Fork(tracker.ProjectState));
+            }
 
-                // Returns true if 'tracker' can be reused for project 'id'
-                bool CanReuse()
-                {
-                    if (id == projectId)
-                        return true;
+            return builder.ToImmutable();
 
-                    // Check the dependency graph to see if project 'id' directly or transitively depends on 'projectId'.
-                    // If the information is not available, do not compute it.
-                    var forwardDependencies = dependencyGraph.TryGetProjectsThatThisProjectTransitivelyDependsOn(id);
-                    if (forwardDependencies is object && !forwardDependencies.Contains(projectId))
-                    {
-                        return true;
-                    }
+            // Returns true if 'tracker' can be reused for project 'id'
+            bool CanReuse(ProjectId id)
+            {
+                if (id == projectId)
+                    return true;
 
-                    // Compute the set of all projects that depend on 'projectId'. This information answers the same
-                    // question as the previous check, but involves at most one transitive computation within the
-                    // dependency graph.
-                    dependencies ??= dependencyGraph.GetProjectsThatTransitivelyDependOnThisProject(projectId);
-                    return !dependencies.Contains(id);
+                // Check the dependency graph to see if project 'id' directly or transitively depends on 'projectId'.
+                // If the information is not available, do not compute it.
+                var forwardDependencies = dependencyGraph.TryGetProjectsThatThisProjectTransitivelyDependsOn(id);
+                if (forwardDependencies is object && !forwardDependencies.Contains(projectId))
+                {
+                    return true;
                 }
-            }
 
-            return builder.ToImmutable();
+                // Compute the set of all projects that depend on 'projectId'. This information answers the same
+                // question as the previous check, but involves at most one transitive computation within the
+                // dependency graph.
+                dependencies ??= dependencyGraph.GetProjectsThatTransitivelyDependOnThisProject(projectId);
+                return !dependencies.Contains(id);
+            }
         }
 
         /// <summary>