Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
9b9f11b2
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
9b9f11b2
编写于
5月 09, 2017
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use-throw-expression should not be offered when the 'if-block' has additional statements in it.
上级
bc9be6c0
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
60 addition
and
0 deletion
+60
-0
src/EditorFeatures/CSharpTest/UseThrowExpression/UseThrowExpressionTests.cs
.../CSharpTest/UseThrowExpression/UseThrowExpressionTests.cs
+42
-0
src/Features/Core/Portable/UseThrowExpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
...xpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
+18
-0
未找到文件。
src/EditorFeatures/CSharpTest/UseThrowExpression/UseThrowExpressionTests.cs
浏览文件 @
9b9f11b2
...
...
@@ -386,6 +386,48 @@ public C(int? x)
_x = x;
}
}"
);
}
[
WorkItem
(
19377
,
"https://github.com/dotnet/roslyn/issues/19377"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUseThrowExpression
)]
public
async
Task
TestNotWithMultipleStatementsInIf1
()
{
await
TestMissingInRegularAndScriptAsync
(
@"using System;
class C
{
void M(string s)
{
if (s == null)
{
Console.WriteLine();
[|throw|] new ArgumentNullException(nameof(s));
}
_s = s;
}
}"
);
}
[
WorkItem
(
19377
,
"https://github.com/dotnet/roslyn/issues/19377"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUseThrowExpression
)]
public
async
Task
TestNotWithMultipleStatementsInIf2
()
{
await
TestMissingInRegularAndScriptAsync
(
@"using System;
class C
{
void M(string s)
{
if (s == null)
{
[|throw|] new ArgumentNullException(nameof(s));
Console.WriteLine();
}
_s = s;
}
}"
);
}
}
...
...
src/Features/Core/Portable/UseThrowExpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
浏览文件 @
9b9f11b2
...
...
@@ -116,6 +116,12 @@ private void AnalyzeOperation(OperationAnalysisContext context, INamedTypeSymbol
return
;
}
if
(!
IsOnlyStatementOfIf
(
ifOperation
,
throwOperation
))
{
// The if-statement can only have a single throw-statement in it.
return
;
}
var
containingBlock
=
GetOperation
(
semanticModel
,
ifOperation
.
Syntax
.
Parent
,
cancellationToken
)
as
IBlockStatement
;
if
(
containingBlock
==
null
)
...
...
@@ -189,6 +195,18 @@ private void AnalyzeOperation(OperationAnalysisContext context, INamedTypeSymbol
}
}
private
bool
IsOnlyStatementOfIf
(
IIfStatement
ifOperation
,
IThrowStatement
throwStatement
)
{
if
(
ifOperation
.
IfTrueStatement
.
Syntax
==
throwStatement
.
Syntax
)
{
return
true
;
}
return
ifOperation
.
IfTrueStatement
is
IBlockStatement
block
&&
block
.
Statements
.
Length
==
1
&&
block
.
Statements
[
0
].
Syntax
==
throwStatement
.
Syntax
;
}
protected
abstract
ISyntaxFactsService
GetSyntaxFactsService
();
protected
abstract
ISemanticFactsService
GetSemanticFactsService
();
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录