Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
98f0b25b
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
98f0b25b
编写于
11月 12, 2019
作者:
A
Allison Chou
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Removed warning code after consulting with compiler team
上级
53d11268
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
0 addition
and
21 deletion
+0
-21
src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.MultipleStatementsCodeGenerator.cs
...or.CSharpCodeGenerator.MultipleStatementsCodeGenerator.cs
+0
-1
src/Features/CSharp/Portable/ExtractMethod/CSharpSelectionValidator.cs
...CSharp/Portable/ExtractMethod/CSharpSelectionValidator.cs
+0
-20
未找到文件。
src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.MultipleStatementsCodeGenerator.cs
浏览文件 @
98f0b25b
...
...
@@ -47,7 +47,6 @@ protected override SyntaxToken CreateMethodName()
var
semanticModel
=
this
.
SemanticDocument
.
SemanticModel
;
var
nameGenerator
=
new
UniqueNameGenerator
(
semanticModel
);
var
scope
=
this
.
CSharpSelectionResult
.
GetContainingScope
();
return
SyntaxFactory
.
Identifier
(
nameGenerator
.
CreateUniqueMethodName
(
scope
,
"NewMethod"
,
GetLocalFunctionNamesIfScopeIsMethod
(
scope
)));
}
...
...
src/Features/CSharp/Portable/ExtractMethod/CSharpSelectionValidator.cs
浏览文件 @
98f0b25b
...
...
@@ -74,26 +74,6 @@ public override async Task<SelectionResult> GetValidSelectionAsync(CancellationT
}
}
// Warn if local functions are in selection since data flow analysis
// cannot correctly analyze them
// https://github.com/dotnet/roslyn/issues/14214
if
(
SpanInvolvesLocalFunction
(
selectionInfo
.
FinalSpan
,
model
,
root
))
{
selectionInfo
=
selectionInfo
.
WithStatus
(
s
=>
s
.
With
(
OperationStatusFlag
.
Succeeded
|
OperationStatusFlag
.
BestEffort
,
CSharpFeaturesResources
.
Warning_Extracting_a_local_function_reference_may_produce_invalid_code
));
var
commonRoot
=
selectionInfo
.
CommonRootFromOriginalSpan
;
var
annotated
=
commonRoot
.
WithAdditionalAnnotations
(
WarningAnnotation
.
Create
(
CSharpFeaturesResources
.
Warning_Extracting_a_local_function_reference_may_produce_invalid_code
));
doc
=
await
doc
.
WithSyntaxRootAsync
(
root
.
ReplaceNode
(
commonRoot
,
annotated
),
cancellationToken
).
ConfigureAwait
(
false
);
selectionInfo
.
FirstTokenInOriginalSpan
=
doc
.
Root
.
FindToken
(
selectionInfo
.
FirstTokenInOriginalSpan
.
SpanStart
);
selectionInfo
.
LastTokenInOriginalSpan
=
doc
.
Root
.
FindToken
(
selectionInfo
.
LastTokenInOriginalSpan
.
SpanStart
);
selectionInfo
.
FirstTokenInFinalSpan
=
doc
.
Root
.
FindToken
(
selectionInfo
.
FirstTokenInFinalSpan
.
SpanStart
);
selectionInfo
.
LastTokenInFinalSpan
=
doc
.
Root
.
FindToken
(
selectionInfo
.
LastTokenInFinalSpan
.
SpanStart
);
}
return
await
CSharpSelectionResult
.
CreateAsync
(
selectionInfo
.
Status
,
selectionInfo
.
OriginalSpan
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录