提交 98f0b25b 编写于 作者: A Allison Chou

Removed warning code after consulting with compiler team

上级 53d11268
......@@ -47,7 +47,6 @@ protected override SyntaxToken CreateMethodName()
var semanticModel = this.SemanticDocument.SemanticModel;
var nameGenerator = new UniqueNameGenerator(semanticModel);
var scope = this.CSharpSelectionResult.GetContainingScope();
return SyntaxFactory.Identifier(nameGenerator.CreateUniqueMethodName(scope, "NewMethod", GetLocalFunctionNamesIfScopeIsMethod(scope)));
}
......
......@@ -74,26 +74,6 @@ public override async Task<SelectionResult> GetValidSelectionAsync(CancellationT
}
}
// Warn if local functions are in selection since data flow analysis
// cannot correctly analyze them
// https://github.com/dotnet/roslyn/issues/14214
if (SpanInvolvesLocalFunction(selectionInfo.FinalSpan, model, root))
{
selectionInfo = selectionInfo.WithStatus(s => s.With(
OperationStatusFlag.Succeeded | OperationStatusFlag.BestEffort,
CSharpFeaturesResources.Warning_Extracting_a_local_function_reference_may_produce_invalid_code));
var commonRoot = selectionInfo.CommonRootFromOriginalSpan;
var annotated = commonRoot.WithAdditionalAnnotations(
WarningAnnotation.Create(CSharpFeaturesResources.Warning_Extracting_a_local_function_reference_may_produce_invalid_code));
doc = await doc.WithSyntaxRootAsync(
root.ReplaceNode(commonRoot, annotated),
cancellationToken).ConfigureAwait(false);
selectionInfo.FirstTokenInOriginalSpan = doc.Root.FindToken(selectionInfo.FirstTokenInOriginalSpan.SpanStart);
selectionInfo.LastTokenInOriginalSpan = doc.Root.FindToken(selectionInfo.LastTokenInOriginalSpan.SpanStart);
selectionInfo.FirstTokenInFinalSpan = doc.Root.FindToken(selectionInfo.FirstTokenInFinalSpan.SpanStart);
selectionInfo.LastTokenInFinalSpan = doc.Root.FindToken(selectionInfo.LastTokenInFinalSpan.SpanStart);
}
return await CSharpSelectionResult.CreateAsync(
selectionInfo.Status,
selectionInfo.OriginalSpan,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册