Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
98983b7f
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
98983b7f
编写于
4月 02, 2019
作者:
D
David Poeschl
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Make target-typed completion an experiment
上级
f5785337
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
20 addition
and
2 deletion
+20
-2
src/Features/Core/Portable/Completion/Providers/AbstractSymbolCompletionProvider.cs
.../Completion/Providers/AbstractSymbolCompletionProvider.cs
+19
-2
src/Workspaces/Core/Portable/Experiments/IExperimentationService.cs
...aces/Core/Portable/Experiments/IExperimentationService.cs
+1
-0
未找到文件。
src/Features/Core/Portable/Completion/Providers/AbstractSymbolCompletionProvider.cs
浏览文件 @
98983b7f
...
...
@@ -8,6 +8,7 @@
using
System.Threading
;
using
System.Threading.Tasks
;
using
Microsoft.CodeAnalysis.ErrorReporting
;
using
Microsoft.CodeAnalysis.Experiments
;
using
Microsoft.CodeAnalysis.Internal.Log
;
using
Microsoft.CodeAnalysis.LanguageServices
;
using
Microsoft.CodeAnalysis.Options
;
...
...
@@ -31,6 +32,8 @@ internal abstract class AbstractSymbolCompletionProvider : CommonCompletionProvi
private
static
int
s_cachedPosition
;
private
static
readonly
object
s_cacheGate
=
new
object
();
private
bool
?
_shouldCreateTargetTypeCompletionFilter
=
null
;
protected
AbstractSymbolCompletionProvider
()
{
}
...
...
@@ -63,9 +66,12 @@ protected virtual CompletionItemRules GetCompletionItemRules(IReadOnlyList<ISymb
symbolGroup
.
Key
.
displayText
,
symbolGroup
.
Key
.
suffix
,
symbolGroup
.
Key
.
insertionText
,
symbolGroup
.
ToList
(),
context
,
invalidProjectMap
:
null
,
totalProjects
:
null
,
preselect
:
preselect
);
if
(
symbolGroup
.
Any
(
s
=>
ShouldIncludeInTargetTypedCompletionList
(
s
,
inferredTypes
,
context
.
SemanticModel
,
context
.
Position
)
))
if
(
ShouldCreateTargetTypeCompletionFilter
(
context
.
Workspace
))
{
item
=
item
.
AddTag
(
WellKnownTags
.
MatchingType
);
if
(
symbolGroup
.
Any
(
s
=>
ShouldIncludeInTargetTypedCompletionList
(
s
,
inferredTypes
,
context
.
SemanticModel
,
context
.
Position
)))
{
item
=
item
.
AddTag
(
WellKnownTags
.
MatchingType
);
}
}
itemListBuilder
.
Add
(
item
);
...
...
@@ -74,6 +80,17 @@ protected virtual CompletionItemRules GetCompletionItemRules(IReadOnlyList<ISymb
return
itemListBuilder
.
ToImmutable
();
}
private
bool
ShouldCreateTargetTypeCompletionFilter
(
Workspace
workspace
)
{
if
(!
_shouldCreateTargetTypeCompletionFilter
.
HasValue
)
{
var
experimentationService
=
workspace
.
Services
.
GetService
<
IExperimentationService
>();
_shouldCreateTargetTypeCompletionFilter
=
experimentationService
.
IsExperimentEnabled
(
WellKnownExperimentNames
.
TargetTypedCompletionFilter
);
}
return
_shouldCreateTargetTypeCompletionFilter
==
true
;
}
private
bool
ShouldIncludeInTargetTypedCompletionList
(
ISymbol
symbol
,
ImmutableArray
<
ITypeSymbol
>
inferredTypes
,
SemanticModel
semanticModel
,
int
position
)
{
// When searching for identifiers of type C, exclude the symbol for the `C` type itself.
...
...
src/Workspaces/Core/Portable/Experiments/IExperimentationService.cs
浏览文件 @
98983b7f
...
...
@@ -23,5 +23,6 @@ internal static class WellKnownExperimentNames
public
const
string
CompletionAPI
=
nameof
(
CompletionAPI
);
public
const
string
PartialLoadMode
=
"Roslyn.PartialLoadMode"
;
public
const
string
TypeImportCompletion
=
"Roslyn.TypeImportCompletion"
;
public
const
string
TargetTypedCompletionFilter
=
"Roslyn.TargetTypedCompletionFilter"
;
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录