提交 966476e3 编写于 作者: C Cyrus Najmabadi

PR feedback.

上级 6f680462
......@@ -14,11 +14,11 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UseAutoProperty
Private ReadOnly semanticFacts As New VisualBasicSemanticFactsService()
Protected Overrides Function SupportsReadOnlyProperties(compilation As Compilation) As Boolean
Return True
Return DirectCast(compilation, VisualBasicCompilation).LanguageVersion >= LanguageVersion.VisualBasic14
End Function
Protected Overrides Function SupportsPropertyInitializer(compilation As Compilation) As Boolean
Return True
Return DirectCast(compilation, VisualBasicCompilation).LanguageVersion >= LanguageVersion.VisualBasic10
End Function
Protected Overrides Sub RegisterIneligibleFieldsAction(context As CompilationStartAnalysisContext, ineligibleFields As ConcurrentBag(Of IFieldSymbol))
......
......@@ -45,6 +45,27 @@ NewLines("class Class1 \n dim i as Integer = 1 \n [|readonly property P as integ
NewLines("class Class1 \n readonly property P as integer = 1 \n end class"))
End Sub
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseAutoProperty)>
Public Sub TestInitializer_VB9()
TestMissing(
NewLines("class Class1 \n dim [|i|] as Integer = 1 \n readonly property P as integer \n get \n return i \n end get \n end property \n end class"),
VisualBasicParseOptions.Default.WithLanguageVersion(LanguageVersion.VisualBasic9))
End Sub
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseAutoProperty)>
Public Sub TestReadOnlyField()
Test(
NewLines("class Class1 \n [|readonly dim i as integer|] \n property P as integer \n get \n return i \n end get \n end property \n end class"),
NewLines("class Class1 \n ReadOnly property P as integer \n end class"))
End Sub
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseAutoProperty)>
Public Sub TestReadOnlyField_VB12()
TestMissing(
NewLines("class Class1 \n [|readonly dim i as integer|] \n property P as integer \n get \n return i \n end get \n end property \n end class"),
VisualBasicParseOptions.Default.WithLanguageVersion(LanguageVersion.VisualBasic12))
End Sub
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseAutoProperty)>
Public Sub TestDifferentValueName()
Test(
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册