Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
948ac1bc
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
948ac1bc
编写于
12月 17, 2020
作者:
C
Cyrus Najmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Do not introduce conditional conversions when they are not legal.
上级
7d89cccc
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
54 addition
and
1 deletion
+54
-1
src/Analyzers/CSharp/Tests/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.cs
...Tests/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.cs
+39
-0
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/SpeculationAnalyzer.cs
...tensions/Compiler/CSharp/Utilities/SpeculationAnalyzer.cs
+15
-1
未找到文件。
src/Analyzers/CSharp/Tests/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.cs
浏览文件 @
948ac1bc
...
...
@@ -8417,5 +8417,44 @@ public static nint N(nint a, int b)
await
test
.
RunAsync
();
}
[
WorkItem
(
50000
,
"https://github.com/dotnet/roslyn/issues/50000"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)]
public
async
Task
KeepNecessaryCastIfRemovalWouldCreateIllegalConditionalExpression
()
{
await
new
VerifyCS
.
Test
{
TestCode
=
@"
class C
{
ushort Goo(string s)
=> s is null ? (ushort)1234 : ushort.Parse(s);
}
"
,
LanguageVersion
=
LanguageVersion
.
CSharp8
,
}.
RunAsync
();
}
[
WorkItem
(
50000
,
"https://github.com/dotnet/roslyn/issues/50000"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)]
public
async
Task
RemoveUnnecessaryCastWhenConditionalExpressionIsLegal
()
{
await
new
VerifyCS
.
Test
{
TestCode
=
@"
class C
{
ushort Goo(string s)
=> s is null ? [|(ushort)|]1234 : ushort.Parse(s);
}"
,
FixedCode
=
@"
class C
{
ushort Goo(string s)
=> s is null ? 1234 : ushort.Parse(s);
}"
,
LanguageVersion
=
LanguageVersion
.
CSharp9
,
}.
RunAsync
();
}
}
}
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/SpeculationAnalyzer.cs
浏览文件 @
948ac1bc
...
...
@@ -342,6 +342,17 @@ protected override bool ReplacementChangesSemanticsForNodeLanguageSpecific(Synta
{
var
newExpression
=
(
ConditionalExpressionSyntax
)
currentReplacedNode
;
// If we removed a cast, causing a conditional expression to now use a conditional *conversion*, then that is always
// an error before CSharp9, and should not be allowed.
var
originalConditionalConversion
=
this
.
OriginalSemanticModel
.
GetConversion
(
originalExpression
);
var
newConditionalConversion
=
this
.
SpeculativeSemanticModel
.
GetConversion
(
newExpression
);
if
(
newConditionalConversion
.
IsConditionalExpression
&&
!
originalConditionalConversion
.
IsConditionalExpression
&&
!
ConditionalExpressionConversionsAreAllowed
(
originalExpression
))
{
return
true
;
}
if
(
originalExpression
.
Condition
!=
previousOriginalNode
)
{
ExpressionSyntax
originalOtherPartOfConditional
,
newOtherPartOfConditional
;
...
...
@@ -719,9 +730,12 @@ private bool ReplacementBreaksQueryClause(QueryClauseSyntax originalClause, Quer
private
static
bool
IsPotentiallyTargetTypedConditionalExpression
(
ExpressionSyntax
expressionSyntax
)
{
return
expressionSyntax
is
ConditionalExpressionSyntax
&&
((
CSharpParseOptions
)
expressionSyntax
.
SyntaxTree
.
Options
).
LanguageVersion
>=
LanguageVersion
.
CSharp9
;
ConditionalExpressionConversionsAreAllowed
(
expressionSyntax
)
;
}
private
static
bool
ConditionalExpressionConversionsAreAllowed
(
ExpressionSyntax
expressionSyntax
)
=>
((
CSharpParseOptions
)
expressionSyntax
.
SyntaxTree
.
Options
).
LanguageVersion
>=
LanguageVersion
.
CSharp9
;
protected
override
bool
ReplacementIntroducesErrorType
(
ExpressionSyntax
originalExpression
,
ExpressionSyntax
newExpression
)
{
// The base implementation will see that the type of the new expression may potentially change to null,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录