Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
94472bf2
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
94472bf2
编写于
12月 19, 2016
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Preserve trivia
上级
e59176f7
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
49 addition
and
12 deletion
+49
-12
src/EditorFeatures/CSharpTest/UsePatternMatching/CSharpAsAndNullCheckTests.cs
...SharpTest/UsePatternMatching/CSharpAsAndNullCheckTests.cs
+34
-0
src/Features/CSharp/Portable/UsePatternMatching/CSharpAsAndNullCheckCodeFixProvider.cs
...UsePatternMatching/CSharpAsAndNullCheckCodeFixProvider.cs
+15
-12
未找到文件。
src/EditorFeatures/CSharpTest/UsePatternMatching/CSharpAsAndNullCheckTests.cs
浏览文件 @
94472bf2
...
...
@@ -431,5 +431,39 @@ void M()
}
}"
);
}
[
WorkItem
(
15957
,
"https://github.com/dotnet/roslyn/issues/15957"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsInlineTypeCheck
)]
public
async
Task
TestTrivia1
()
{
await
TestAsync
(
@"class C
{
void M(object y)
{
if (y != null)
{
}
[|var|] x = o as string;
if (x != null)
{
}
}
}"
,
@"class C
{
void M(object y)
{
if (y != null)
{
}
if (o is string x)
{
}
}
}"
,
compareTokens
:
false
);
}
}
}
\ No newline at end of file
src/Features/CSharp/Portable/UsePatternMatching/CSharpAsAndNullCheckCodeFixProvider.cs
浏览文件 @
94472bf2
...
...
@@ -57,26 +57,29 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
var
localDeclaration
=
(
LocalDeclarationStatementSyntax
)
localDeclarationLocation
.
FindNode
(
cancellationToken
);
var
ifStatement
=
(
IfStatementSyntax
)
ifStatementLocation
.
FindNode
(
cancellationToken
);
var
condition
=
(
BinaryExpressionSyntax
)
conditionLocation
.
FindNode
(
cancellationToken
);
var
condition
Part
=
(
BinaryExpressionSyntax
)
conditionLocation
.
FindNode
(
cancellationToken
);
var
asExpression
=
(
BinaryExpressionSyntax
)
asExpressionLocation
.
FindNode
(
cancellationToken
);
var
updatedCondition
=
SyntaxFactory
.
IsPatternExpression
(
var
updatedCondition
Part
=
SyntaxFactory
.
IsPatternExpression
(
asExpression
.
Left
,
SyntaxFactory
.
DeclarationPattern
(
((
TypeSyntax
)
asExpression
.
Right
).
WithoutTrivia
(),
SyntaxFactory
.
SingleVariableDesignation
(
localDeclaration
.
Declaration
.
Variables
[
0
].
Identifier
.
WithoutTrivia
())));
var
trivia
=
localDeclaration
.
GetLeadingTrivia
().
Concat
(
localDeclaration
.
GetTrailingTrivia
())
.
Where
(
t
=>
t
.
IsSingleOrMultiLineComment
())
.
SelectMany
(
t
=>
ImmutableArray
.
Create
(
t
,
SyntaxFactory
.
ElasticCarriageReturnLineFeed
))
.
ToImmutableArray
();
var
finalCondition
=
ifStatement
.
Condition
.
ReplaceNode
(
conditionPart
,
updatedConditionPart
);
var
updatedIfStatement
=
ifStatement
.
ReplaceNode
(
condition
,
updatedCondition
)
.
WithPrependedLeadingTrivia
(
trivia
)
.
WithAdditionalAnnotations
(
Formatter
.
Annotation
);
editor
.
RemoveNode
(
localDeclaration
);
editor
.
ReplaceNode
(
ifStatement
,
updatedIfStatement
);
// Keep the trivia on the node we're removing. But format the next statement so
// they look ok when they move to it.
var
removeOptions
=
localDeclaration
.
GetTrailingTrivia
().
Any
(
t
=>
t
.
IsRegularOrDocComment
())
?
SyntaxRemoveOptions
.
KeepLeadingTrivia
|
SyntaxRemoveOptions
.
KeepTrailingTrivia
:
SyntaxRemoveOptions
.
KeepLeadingTrivia
;
editor
.
RemoveNode
(
localDeclaration
,
removeOptions
);
editor
.
ReplaceNode
(
ifStatement
,
(
i
,
g
)
=>
{
var
currentIf
=
(
IfStatementSyntax
)
i
;
var
updatedIf
=
currentIf
.
ReplaceNode
(
currentIf
.
Condition
,
finalCondition
);
return
updatedIf
.
WithAdditionalAnnotations
(
Formatter
.
Annotation
);
});
}
private
class
MyCodeAction
:
CodeAction
.
DocumentChangeAction
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录