Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
92f239e9
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
92f239e9
编写于
11月 07, 2016
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Improve the messages we give for code fixes in the error list.
上级
ace57b08
变更
15
隐藏空白更改
内联
并排
Showing
15 changed file
with
80 addition
and
25 deletion
+80
-25
src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs
...eDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs
+3
-2
src/Features/CSharp/Portable/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs
...onalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs
+2
-1
src/Features/CSharp/Portable/UseExpressionBody/AbstractUseExpressionBodyDiagnosticAnalyzer.cs
...essionBody/AbstractUseExpressionBodyDiagnosticAnalyzer.cs
+2
-2
src/Features/CSharp/Portable/UsePatternMatching/CSharpAsAndNullCheckDiagnosticAnalyzer.cs
...PatternMatching/CSharpAsAndNullCheckDiagnosticAnalyzer.cs
+1
-1
src/Features/CSharp/Portable/UsePatternMatching/CSharpIsAndCastCheckDiagnosticAnalyzer.cs
...PatternMatching/CSharpIsAndCastCheckDiagnosticAnalyzer.cs
+1
-1
src/Features/Core/Portable/CodeStyle/AbstractCodeStyleDiagnosticAnalyzer.cs
...Portable/CodeStyle/AbstractCodeStyleDiagnosticAnalyzer.cs
+8
-8
src/Features/Core/Portable/FeaturesResources.Designer.cs
src/Features/Core/Portable/FeaturesResources.Designer.cs
+36
-0
src/Features/Core/Portable/FeaturesResources.resx
src/Features/Core/Portable/FeaturesResources.resx
+12
-0
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
...erAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
+1
-1
src/Features/Core/Portable/UseCoalesceExpression/AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs
...ession/AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs
+3
-2
src/Features/Core/Portable/UseCoalesceExpression/AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs
...ractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs
+1
-1
src/Features/Core/Portable/UseCollectionInitializer/AbstractUseCollectionInitializerDiagnosticAnalyzer.cs
...zer/AbstractUseCollectionInitializerDiagnosticAnalyzer.cs
+2
-1
src/Features/Core/Portable/UseNullPropagation/AbstractUseNullPropagationDiagnosticAnalyzer.cs
...opagation/AbstractUseNullPropagationDiagnosticAnalyzer.cs
+3
-2
src/Features/Core/Portable/UseObjectInitializer/AbstractUseObjectInitializerDiagnosticAnalyzer.cs
...ializer/AbstractUseObjectInitializerDiagnosticAnalyzer.cs
+2
-1
src/Features/Core/Portable/UseThrowExpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
...xpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
+3
-2
未找到文件。
src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -26,7 +26,8 @@ internal class CSharpInlineDeclarationDiagnosticAnalyzer : AbstractCodeStyleDiag
{
public
CSharpInlineDeclarationDiagnosticAnalyzer
()
:
base
(
IDEDiagnosticIds
.
InlineDeclarationDiagnosticId
,
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Inline_variable_declaration
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Inline_variable_declaration
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)),
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Variable_declaration_can_be_inlined
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
{
}
...
...
@@ -196,7 +197,7 @@ private void AnalyzeSyntaxNode(SyntaxNodeAnalysisContext context)
:
localDeclarator
;
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
this
.
DescriptorId
,
option
.
Notification
.
Value
),
CreateDescriptor
WithSeverity
(
option
.
Notification
.
Value
),
reportNode
.
GetLocation
(),
additionalLocations
:
allLocations
));
}
...
...
src/Features/CSharp/Portable/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -173,7 +173,8 @@ private void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)
additionalLocations
,
properties
));
// Put a diagnostic with the appropriate severity on the expression-statement itself.
syntaxContext
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
this
.
DescriptorId
,
severity
),
syntaxContext
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptorWithSeverity
(
severity
),
expressionStatement
.
GetLocation
(),
additionalLocations
,
properties
));
...
...
src/Features/CSharp/Portable/UseExpressionBody/AbstractUseExpressionBodyDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -65,7 +65,7 @@ internal virtual Diagnostic AnalyzeSyntax(OptionSet optionSet, TDeclaration decl
{
var
additionalLocations
=
ImmutableArray
.
Create
(
declaration
.
GetLocation
());
return
Diagnostic
.
Create
(
CreateDescriptor
(
_expressionBodyTitle
,
preferExpressionBodiedOption
.
Notification
.
Value
),
CreateDescriptor
WithTitle
(
_expressionBodyTitle
,
preferExpressionBodiedOption
.
Notification
.
Value
),
GetBody
(
declaration
).
Statements
[
0
].
GetLocation
(),
additionalLocations
:
additionalLocations
);
}
...
...
@@ -78,7 +78,7 @@ internal virtual Diagnostic AnalyzeSyntax(OptionSet optionSet, TDeclaration decl
{
var
additionalLocations
=
ImmutableArray
.
Create
(
declaration
.
GetLocation
());
return
Diagnostic
.
Create
(
CreateDescriptor
(
_blockBodyTitle
,
preferExpressionBodiedOption
.
Notification
.
Value
),
CreateDescriptor
WithTitle
(
_blockBodyTitle
,
preferExpressionBodiedOption
.
Notification
.
Value
),
expressionBody
.
GetLocation
(),
additionalLocations
:
additionalLocations
);
}
...
...
src/Features/CSharp/Portable/UsePatternMatching/CSharpAsAndNullCheckDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -132,7 +132,7 @@ private void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)
// Put a diagnostic with the appropriate severity on the declaration-statement itself.
syntaxContext
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
this
.
DescriptorId
,
severity
),
CreateDescriptor
WithSeverity
(
severity
),
localDeclarationStatement
.
GetLocation
(),
additionalLocations
));
}
...
...
src/Features/CSharp/Portable/UsePatternMatching/CSharpIsAndCastCheckDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -142,7 +142,7 @@ private void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)
// Put a diagnostic with the appropriate severity on the declaration-statement itself.
syntaxContext
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
this
.
DescriptorId
,
severity
),
CreateDescriptor
WithSeverity
(
severity
),
localDeclarationStatement
.
GetLocation
(),
additionalLocations
));
}
...
...
src/Features/Core/Portable/CodeStyle/AbstractCodeStyleDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -39,13 +39,13 @@ internal abstract class AbstractCodeStyleDiagnosticAnalyzer : DiagnosticAnalyzer
_localizableTitle
=
title
;
_localizableMessage
=
message
??
title
;
var
primaryDescriptor
=
CreateDescriptor
(
descriptorId
,
DiagnosticSeverity
.
Hidden
);
var
primaryDescriptor
=
CreateDescriptor
WithSeverity
(
DiagnosticSeverity
.
Hidden
);
UnnecessaryWithSuggestionDescriptor
=
CreateDescriptor
(
UnnecessaryWithSuggestionDescriptor
=
CreateDescriptor
WithId
(
descriptorId
,
_localizableTitle
,
_localizableMessage
,
DiagnosticSeverity
.
Hidden
,
DiagnosticCustomTags
.
Unnecessary
);
UnnecessaryWithoutSuggestionDescriptor
=
CreateDescriptor
(
UnnecessaryWithoutSuggestionDescriptor
=
CreateDescriptor
WithId
(
descriptorId
+
"WithoutSuggestion"
,
_localizableTitle
,
_localizableMessage
,
DiagnosticSeverity
.
Hidden
,
DiagnosticCustomTags
.
Unnecessary
);
...
...
@@ -56,13 +56,13 @@ internal abstract class AbstractCodeStyleDiagnosticAnalyzer : DiagnosticAnalyzer
public
override
ImmutableArray
<
DiagnosticDescriptor
>
SupportedDiagnostics
{
get
;
}
protected
DiagnosticDescriptor
CreateDescriptor
(
DiagnosticSeverity
severity
,
params
string
[]
customTags
)
=>
CreateDescriptor
(
DescriptorId
,
_localizableTitle
,
_localizableMessage
,
severity
,
customTags
);
protected
DiagnosticDescriptor
CreateDescriptor
WithSeverity
(
DiagnosticSeverity
severity
,
params
string
[]
customTags
)
=>
CreateDescriptor
WithId
(
DescriptorId
,
_localizableTitle
,
_localizableMessage
,
severity
,
customTags
);
protected
DiagnosticDescriptor
CreateDescriptor
(
LocalizableString
title
,
DiagnosticSeverity
severity
,
params
string
[]
customTags
)
=>
CreateDescriptor
(
DescriptorId
,
title
,
title
,
severity
,
customTags
);
protected
DiagnosticDescriptor
CreateDescriptor
WithTitle
(
LocalizableString
title
,
DiagnosticSeverity
severity
,
params
string
[]
customTags
)
=>
CreateDescriptor
WithId
(
DescriptorId
,
title
,
title
,
severity
,
customTags
);
private
DiagnosticDescriptor
CreateDescriptor
(
string
id
,
LocalizableString
title
,
LocalizableString
message
,
DiagnosticSeverity
severity
,
params
string
[]
customTags
)
private
DiagnosticDescriptor
CreateDescriptor
WithId
(
string
id
,
LocalizableString
title
,
LocalizableString
message
,
DiagnosticSeverity
severity
,
params
string
[]
customTags
)
=>
new
DiagnosticDescriptor
(
id
,
title
,
message
,
DiagnosticCategory
.
Style
,
...
...
src/Features/Core/Portable/FeaturesResources.Designer.cs
浏览文件 @
92f239e9
...
...
@@ -2011,6 +2011,15 @@ internal class FeaturesResources {
}
}
/// <summary>
/// Looks up a localized string similar to Null check can be simplified.
/// </summary>
internal
static
string
Null_check_can_be_simplified
{
get
{
return
ResourceManager
.
GetString
(
"Null_check_can_be_simplified"
,
resourceCulture
);
}
}
/// <summary>
/// Looks up a localized string similar to Object initialization can be simplified.
/// </summary>
...
...
@@ -2412,6 +2421,15 @@ internal class FeaturesResources {
}
}
/// <summary>
/// Looks up a localized string similar to Simplify collection initialization.
/// </summary>
internal
static
string
Simplify_collection_initialization
{
get
{
return
ResourceManager
.
GetString
(
"Simplify_collection_initialization"
,
resourceCulture
);
}
}
/// <summary>
/// Looks up a localized string similar to Simplify Member Access.
/// </summary>
...
...
@@ -2430,6 +2448,15 @@ internal class FeaturesResources {
}
}
/// <summary>
/// Looks up a localized string similar to Simplify object initialization.
/// </summary>
internal
static
string
Simplify_object_initialization
{
get
{
return
ResourceManager
.
GetString
(
"Simplify_object_initialization"
,
resourceCulture
);
}
}
/// <summary>
/// Looks up a localized string similar to Snippets.
/// </summary>
...
...
@@ -3164,6 +3191,15 @@ internal class FeaturesResources {
}
}
/// <summary>
/// Looks up a localized string similar to Variable declaration can be inlined.
/// </summary>
internal
static
string
Variable_declaration_can_be_inlined
{
get
{
return
ResourceManager
.
GetString
(
"Variable_declaration_can_be_inlined"
,
resourceCulture
);
}
}
/// <summary>
/// Looks up a localized string similar to Variadic SignatureHelpItem must have at least one parameter..
/// </summary>
...
...
src/Features/Core/Portable/FeaturesResources.resx
浏览文件 @
92f239e9
...
...
@@ -1157,4 +1157,16 @@ This version used in: {2}</value>
<data
name=
"Use_null_propagation"
xml:space=
"preserve"
>
<value>
Use null propagation
</value>
</data>
<data
name=
"Variable_declaration_can_be_inlined"
xml:space=
"preserve"
>
<value>
Variable declaration can be inlined
</value>
</data>
<data
name=
"Null_check_can_be_simplified"
xml:space=
"preserve"
>
<value>
Null check can be simplified
</value>
</data>
<data
name=
"Simplify_collection_initialization"
xml:space=
"preserve"
>
<value>
Simplify collection initialization
</value>
</data>
<data
name=
"Simplify_object_initialization"
xml:space=
"preserve"
>
<value>
Simplify object initialization
</value>
</data>
</root>
\ No newline at end of file
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -88,7 +88,7 @@ private void AnalyzeOperation(OperationAnalysisContext context)
if
(
severity
!=
DiagnosticSeverity
.
Hidden
)
{
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
severity
),
CreateDescriptor
WithSeverity
(
severity
),
context
.
Operation
.
Syntax
.
GetLocation
()));
}
}
...
...
src/Features/Core/Portable/UseCoalesceExpression/AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -19,7 +19,8 @@ internal abstract class AbstractUseCoalesceExpressionDiagnosticAnalyzer<
{
protected
AbstractUseCoalesceExpressionDiagnosticAnalyzer
()
:
base
(
IDEDiagnosticIds
.
UseCoalesceExpressionDiagnosticId
,
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Use_coalesce_expression
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Use_coalesce_expression
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)),
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Null_check_can_be_simplified
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
{
}
...
...
@@ -103,7 +104,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
whenPartToCheck
.
GetLocation
());
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
this
.
CreateDescriptor
(
option
.
Notification
.
Value
),
this
.
CreateDescriptor
WithSeverity
(
option
.
Notification
.
Value
),
conditionalExpression
.
GetLocation
(),
locations
));
}
...
...
src/Features/Core/Portable/UseCoalesceExpression/AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -129,7 +129,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
whenPartToKeep
.
GetLocation
());
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
this
.
CreateDescriptor
(
option
.
Notification
.
Value
),
this
.
CreateDescriptor
WithSeverity
(
option
.
Notification
.
Value
),
conditionalExpression
.
GetLocation
(),
locations
));
}
...
...
src/Features/Core/Portable/UseCollectionInitializer/AbstractUseCollectionInitializerDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -33,6 +33,7 @@ internal abstract class AbstractUseCollectionInitializerDiagnosticAnalyzer<
protected
AbstractUseCollectionInitializerDiagnosticAnalyzer
()
:
base
(
IDEDiagnosticIds
.
UseCollectionInitializerDiagnosticId
,
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Simplify_collection_initialization
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)),
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Collection_initialization_can_be_simplified
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
{
}
...
...
@@ -96,7 +97,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context, INamedTypeSymbol ien
var
severity
=
option
.
Notification
.
Value
;
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
severity
),
CreateDescriptor
WithSeverity
(
severity
),
objectCreationExpression
.
GetLocation
(),
additionalLocations
:
locations
));
...
...
src/Features/Core/Portable/UseNullPropagation/AbstractUseNullPropagationDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -28,7 +28,8 @@ internal abstract class AbstractUseNullPropagationDiagnosticAnalyzer<
{
protected
AbstractUseNullPropagationDiagnosticAnalyzer
()
:
base
(
IDEDiagnosticIds
.
UseNullPropagationDiagnosticId
,
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Use_null_propagation
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Use_null_propagation
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)),
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Null_check_can_be_simplified
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
{
}
...
...
@@ -112,7 +113,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
whenPartToCheck
.
GetLocation
());
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
this
.
CreateDescriptor
(
option
.
Notification
.
Value
),
this
.
CreateDescriptor
WithSeverity
(
option
.
Notification
.
Value
),
conditionalExpression
.
GetLocation
(),
locations
));
}
...
...
src/Features/Core/Portable/UseObjectInitializer/AbstractUseObjectInitializerDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -35,6 +35,7 @@ internal abstract class AbstractUseObjectInitializerDiagnosticAnalyzer<
protected
AbstractUseObjectInitializerDiagnosticAnalyzer
()
:
base
(
IDEDiagnosticIds
.
UseObjectInitializerDiagnosticId
,
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Simplify_object_initialization
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)),
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Object_initialization_can_be_simplified
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
{
}
...
...
@@ -80,7 +81,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
var
severity
=
option
.
Notification
.
Value
;
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
CreateDescriptor
(
severity
),
CreateDescriptor
WithSeverity
(
severity
),
objectCreationExpression
.
GetLocation
(),
additionalLocations
:
locations
));
...
...
src/Features/Core/Portable/UseThrowExpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
浏览文件 @
92f239e9
...
...
@@ -36,7 +36,8 @@ internal abstract class AbstractUseThrowExpressionDiagnosticAnalyzer : AbstractC
{
protected
AbstractUseThrowExpressionDiagnosticAnalyzer
()
:
base
(
IDEDiagnosticIds
.
UseThrowExpressionDiagnosticId
,
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Use_throw_expression
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Use_throw_expression
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)),
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Null_check_can_be_simplified
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
)))
{
}
...
...
@@ -141,7 +142,7 @@ private void AnalyzeOperation(OperationAnalysisContext context)
throwOperation
.
ThrownObject
.
Syntax
.
GetLocation
(),
assignmentExpression
.
Value
.
Syntax
.
GetLocation
());
var
descriptor
=
CreateDescriptor
(
option
.
Notification
.
Value
);
var
descriptor
=
CreateDescriptor
WithSeverity
(
option
.
Notification
.
Value
);
context
.
ReportDiagnostic
(
Diagnostic
.
Create
(
descriptor
,
throwStatement
.
GetLocation
(),
additionalLocations
:
allLocations
));
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录