Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
8f33c29f
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
8f33c29f
编写于
9月 18, 2016
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fixProvider.
上级
3f51cef5
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
78 addition
and
3 deletion
+78
-3
src/Features/Core/Portable/CodeFixes/PredefinedCodeFixProviderNames.cs
...Core/Portable/CodeFixes/PredefinedCodeFixProviderNames.cs
+1
-0
src/Features/Core/Portable/Diagnostics/Analyzers/IDEDiagnosticIds.cs
...s/Core/Portable/Diagnostics/Analyzers/IDEDiagnosticIds.cs
+1
-0
src/Features/Core/Portable/Features.csproj
src/Features/Core/Portable/Features.csproj
+1
-0
src/Features/Core/Portable/SimplifyNullCheck/SimplifyNullCheckAnalyzer.cs
...e/Portable/SimplifyNullCheck/SimplifyNullCheckAnalyzer.cs
+4
-3
src/Features/Core/Portable/SimplifyNullCheck/SimplifyNullCheckCodeFixProvider.cs
...ble/SimplifyNullCheck/SimplifyNullCheckCodeFixProvider.cs
+71
-0
未找到文件。
src/Features/Core/Portable/CodeFixes/PredefinedCodeFixProviderNames.cs
浏览文件 @
8f33c29f
...
...
@@ -38,6 +38,7 @@ internal static class PredefinedCodeFixProviderNames
public
const
string
RemoveUnnecessaryImports
=
"Remove Unnecessary Usings or Imports"
;
public
const
string
RenameTracking
=
"Rename Tracking"
;
public
const
string
SimplifyNames
=
"Simplify Names"
;
public
const
string
SimplifyNullCheck
=
nameof
(
SimplifyNullCheck
);
public
const
string
SpellCheck
=
"Spell Check"
;
public
const
string
Suppression
=
nameof
(
Suppression
);
public
const
string
AddOverloads
=
"Add Overloads to member"
;
...
...
src/Features/Core/Portable/Diagnostics/Analyzers/IDEDiagnosticIds.cs
浏览文件 @
8f33c29f
...
...
@@ -19,6 +19,7 @@ internal static class IDEDiagnosticIds
public
const
string
PreferIntrinsicPredefinedTypeInMemberAccessDiagnosticId
=
"IDE0013"
;
public
const
string
PreferFrameworkTypeInDeclarationsDiagnosticId
=
"IDE0014"
;
public
const
string
PreferFrameworkTypeInMemberAccessDiagnosticId
=
"IDE0015"
;
public
const
string
SimplifyNullCheckDiagnosticId
=
"IDE0016"
;
// Analyzer error Ids
public
const
string
AnalyzerChangedId
=
"IDE1001"
;
...
...
src/Features/Core/Portable/Features.csproj
浏览文件 @
8f33c29f
...
...
@@ -93,6 +93,7 @@
<Compile
Include=
"AddMissingReference\AbstractAddMissingReferenceCodeFixProvider.cs"
/>
<Compile
Include=
"AddMissingReference\CodeAction.cs"
/>
<Compile
Include=
"SimplifyNullCheck\SimplifyNullCheckAnalyzer.cs"
/>
<Compile
Include=
"SimplifyNullCheck\SimplifyNullCheckCodeFixProvider.cs"
/>
<Compile
Include=
"Structure\BlockTypes.cs"
/>
<Compile
Include=
"CodeLens\CodeLensReferencesServiceFactory.cs"
/>
<Compile
Include=
"Structure\Syntax\BlockStructureExtensions.cs"
/>
...
...
src/Features/Core/Portable/SimplifyNullCheck/SimplifyNullCheckAnalyzer.cs
浏览文件 @
8f33c29f
...
...
@@ -38,7 +38,8 @@ internal class SimplifyNullCheckAnalyzer : DiagnosticAnalyzer, IBuiltInAnalyzer
private
static
readonly
LocalizableString
s_localizableTitle
=
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Simplify_null_check
),
FeaturesResources
.
ResourceManager
,
typeof
(
FeaturesResources
));
private
static
readonly
LocalizableString
s_localizableMessage
=
new
LocalizableResourceString
(
nameof
(
FeaturesResources
.
Simplify_null_check
),
WorkspacesResources
.
ResourceManager
,
typeof
(
WorkspacesResources
));
private
static
readonly
DiagnosticDescriptor
s_descriptor
=
new
DiagnosticDescriptor
(
IDEDiagnosticIds
.
PopulateSwitchDiagnosticId
,
private
static
readonly
DiagnosticDescriptor
s_descriptor
=
new
DiagnosticDescriptor
(
IDEDiagnosticIds
.
SimplifyNullCheckDiagnosticId
,
s_localizableTitle
,
s_localizableMessage
,
DiagnosticCategory
.
Style
,
...
...
@@ -122,8 +123,8 @@ private void AnalyzeOperation(OperationAnalysisContext operationContext)
// Ok, there were no intervening writes. This check+assignment can be simplified.
var
allLocations
=
ImmutableArray
.
Create
(
throw
Operation
.
Syntax
.
GetLocation
(),
expressionStatemen
t
.
Syntax
.
GetLocation
(),
if
Operation
.
Syntax
.
GetLocation
(),
throwOperation
.
ThrownObjec
t
.
Syntax
.
GetLocation
(),
assignmentExpression
.
Value
.
Syntax
.
GetLocation
());
operationContext
.
ReportDiagnostic
(
...
...
src/Features/Core/Portable/SimplifyNullCheck/SimplifyNullCheckCodeFixProvider.cs
0 → 100644
浏览文件 @
8f33c29f
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using
System
;
using
System.Collections.Generic
;
using
System.Collections.Immutable
;
using
System.Composition
;
using
System.Linq
;
using
System.Text
;
using
System.Threading
;
using
System.Threading.Tasks
;
using
Microsoft.CodeAnalysis.CodeActions
;
using
Microsoft.CodeAnalysis.CodeFixes
;
using
Microsoft.CodeAnalysis.Diagnostics
;
using
Microsoft.CodeAnalysis.Editing
;
using
Roslyn.Utilities
;
namespace
Microsoft.CodeAnalysis.SimplifyNullCheck
{
[
ExportCodeFixProvider
(
LanguageNames
.
CSharp
,
Name
=
PredefinedCodeFixProviderNames
.
SimplifyNullCheck
),
Shared
]
internal
class
SimplifyNullCheckCodeFixProvider
:
CodeFixProvider
{
public
override
ImmutableArray
<
string
>
FixableDiagnosticIds
=>
ImmutableArray
.
Create
(
IDEDiagnosticIds
.
SimplifyNullCheckDiagnosticId
);
public
override
Task
RegisterCodeFixesAsync
(
CodeFixContext
context
)
{
var
diagnostic
=
context
.
Diagnostics
.
First
();
context
.
RegisterCodeFix
(
new
MyCodeAction
(
c
=>
FixAsync
(
context
.
Document
,
diagnostic
,
c
)),
diagnostic
);
return
SpecializedTasks
.
EmptyTask
;
}
private
async
Task
<
Document
>
FixAsync
(
Document
document
,
Diagnostic
diagnostic
,
CancellationToken
cancellationToken
)
{
var
root
=
await
document
.
GetSyntaxRootAsync
(
cancellationToken
).
ConfigureAwait
(
false
);
var
ifStatement
=
root
.
FindNode
(
diagnostic
.
AdditionalLocations
[
0
].
SourceSpan
);
var
throwStatementExpression
=
root
.
FindNode
(
diagnostic
.
AdditionalLocations
[
1
].
SourceSpan
);
var
assignmentValue
=
root
.
FindNode
(
diagnostic
.
AdditionalLocations
[
2
].
SourceSpan
);
var
editor
=
new
SyntaxEditor
(
root
,
document
.
Project
.
Solution
.
Workspace
);
var
generator
=
editor
.
Generator
;
// First, remote the if-statement entirely.
editor
.
RemoveNode
(
ifStatement
);
// Now, update the assignemnt value to go from 'a' to 'a ?? throw ...'.
editor
.
ReplaceNode
(
assignmentValue
,
generator
.
CoalesceExpression
(
assignmentValue
,
generator
.
ThrowExpression
(
throwStatementExpression
)));
var
newRoot
=
editor
.
GetChangedRoot
();
return
document
.
WithSyntaxRoot
(
newRoot
);
}
private
class
MyCodeAction
:
CodeAction
.
DocumentChangeAction
{
public
MyCodeAction
(
Func
<
CancellationToken
,
Task
<
Document
>>
createChangedDocument
)
:
base
(
FeaturesResources
.
Simplify_null_check
,
createChangedDocument
,
FeaturesResources
.
Simplify_null_check
)
{
}
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录