Merge pull request #15566 from heejaechang/optionmissing

add options back to diagnostics

src/Workspaces/Remote/Core/Services/SolutionService.cs

@@ -58,6 +58,11 @@ public async Task<Solution> GetSolutionAsync(Checksum solutionChecksum, Cancella
 
         public async Task<Solution> GetSolutionAsync(Checksum solutionChecksum, OptionSet optionSet, CancellationToken cancellationToken)
         {
+            if (optionSet == null)
+            {
+                return await GetSolutionAsync(solutionChecksum, cancellationToken).ConfigureAwait(false);
+            }
+
             // since option belong to workspace, we can't share solution
 
             // create new solution

src/Workspaces/Remote/ServiceHub/Services/CodeAnalysisService_Diagnostics.cs

@@ -33,7 +33,7 @@ public async Task CalculateDiagnosticsAsync(DiagnosticArguments arguments, byte[
                     var optionSet = await RoslynServices.AssetService.GetAssetAsync<OptionSet>(arguments.GetOptionSetChecksum(), CancellationToken).ConfigureAwait(false);
 
                     // entry point for diagnostic service
-                    var solution = await GetSolutionAsync().ConfigureAwait(false);
+                    var solution = await GetSolutionWithSpecificOptionsAsync(optionSet).ConfigureAwait(false);
 
                     var projectId = arguments.GetProjectId();
                     var analyzers = await GetHostAnalyzerReferences(arguments.GetHostAnalyzerChecksums()).ConfigureAwait(false);

src/Workspaces/Remote/ServiceHub/Services/ServiceHubServiceBase.cs

@@ -5,6 +5,7 @@
 using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.CodeAnalysis.Options;
 using Roslyn.Utilities;
 using StreamJsonRpc;
 
@@ -66,6 +67,12 @@ protected Task<Solution> GetSolutionAsync()
             return RoslynServices.SolutionService.GetSolutionAsync(_solutionChecksumOpt, CancellationToken);
         }
 
+        protected Task<Solution> GetSolutionWithSpecificOptionsAsync(OptionSet options)
+        {
+            Contract.ThrowIfNull(_solutionChecksumOpt);
+            return RoslynServices.SolutionService.GetSolutionAsync(_solutionChecksumOpt, options, CancellationToken);
+        }
+
         protected virtual void Dispose(bool disposing)
         {
             // do nothing here