Merge pull request #4515 from amcasey/CommandCase

Make Interactive window command parsing case sensitive.

src/InteractiveWindow/Editor/Commands/HelpCommand.cs

@@ -79,7 +79,7 @@ private bool ParseArguments(IInteractiveWindow window, string arguments, out str
             // display help on a particular command:
             command = commands[name];
 
-            if (command == null && name.StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
+            if (command == null && name.StartsWith(prefix, StringComparison.Ordinal))
             {
                 name = name.Substring(prefix.Length);
                 command = commands[name];

src/InteractiveWindow/Editor/Commands/ResetCommand.cs

@@ -81,7 +81,7 @@ internal static IEnumerable<int> GetNoConfigPositions(string arguments)
             int startIndex = 0;
             while (true)
             {
-                int index = arguments.IndexOf(NoConfigParameterName, startIndex, StringComparison.OrdinalIgnoreCase);
+                int index = arguments.IndexOf(NoConfigParameterName, startIndex, StringComparison.Ordinal);
                 if (index < 0) yield break;
 
                 if ((index == 0 || char.IsWhiteSpace(arguments[index - 1])) &&
@@ -105,7 +105,7 @@ internal static bool TryParseArguments(string arguments, out bool initialize)
                 initialize = true;
                 return true;
             }
-            else if (string.Equals(trimmed, NoConfigParameterName, StringComparison.OrdinalIgnoreCase))
+            else if (string.Equals(trimmed, NoConfigParameterName, StringComparison.Ordinal))
             {
                 initialize = false;
                 return true;

src/InteractiveWindow/EditorTest/InteractiveWindowTests.cs

@@ -658,9 +658,6 @@ public void ResetCommandArgumentParsing_Success()
 
             Assert.True(ResetCommand.TryParseArguments("\r\nnoconfig\r\n", out initialize));
             Assert.False(initialize);
-
-            Assert.True(ResetCommand.TryParseArguments("nOcOnfIg", out initialize));
-            Assert.False(initialize);
         }
 
         [Fact]
@@ -673,6 +670,7 @@ public void ResetCommandArgumentParsing_Failure()
             Assert.False(ResetCommand.TryParseArguments("noconfig 1", out initialize));
             Assert.False(ResetCommand.TryParseArguments("1 noconfig", out initialize));
             Assert.False(ResetCommand.TryParseArguments("noconfig\r\na", out initialize));
+            Assert.False(ResetCommand.TryParseArguments("nOcOnfIg", out initialize));
         }
 
         [Fact]
@@ -684,6 +682,7 @@ public void ResetCommandNoConfigClassification()
             Assert.Empty(ResetCommand.GetNoConfigPositions("noconfig1"));
             Assert.Empty(ResetCommand.GetNoConfigPositions("1noconfig"));
             Assert.Empty(ResetCommand.GetNoConfigPositions("1noconfig1"));
+            Assert.Empty(ResetCommand.GetNoConfigPositions("nOcOnfIg"));
 
             Assert.Equal(new[] { 0 }, ResetCommand.GetNoConfigPositions("noconfig"));
             Assert.Equal(new[] { 0 }, ResetCommand.GetNoConfigPositions("noconfig "));