Merge pull request #743 from rchande/EventOverriding

Don't suggest events to override in VB

Fixes #715 

src/EditorFeatures/VisualBasic/Completion/CompletionProviders/OverrideCompletionProvider.vb

@@ -177,7 +177,7 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.Completion.CompletionProvide
                 End If
             End If
 
-            Return members
+            Return members.Where(Function(m) Not m.IsKind(SymbolKind.Event)).ToSet()
         End Function
 
         Private Function OverridesObjectMethod(method As IMethodSymbol) As Boolean

src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/OverrideCompletionProviderTests.vb

 ' Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
 
 Imports Microsoft.CodeAnalysis
+Imports Microsoft.CodeAnalysis.Completion
 Imports Microsoft.CodeAnalysis.Completion.Providers
 Imports Microsoft.CodeAnalysis.Editor.UnitTests.Utilities
+Imports Microsoft.CodeAnalysis.Editor.UnitTests.Workspaces
 Imports Microsoft.CodeAnalysis.Editor.VisualBasic.Completion.CompletionProviders
 Imports Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.Completion.CompletionProviders
 
@@ -1712,4 +1714,39 @@ End Class
 
         VerifyItemIsAbsent(text.Value, "w")
     End Sub
+
+    <WorkItem(715, "https://github.com/dotnet/roslyn/issues/715")>
+    <Fact, Trait(Traits.Feature, Traits.Features.Completion)>
+    Public Sub EventsNotOffered()
+        Dim text = <Workspace>
+                       <Project Language="Visual Basic" CommonReferences="true">
+                           <ProjectReference>CSProject</ProjectReference>
+                           <Document FilePath="VBDocument">
+Class D
+    Inherits C
+
+    overrides $$
+End Class</Document>
+                       </Project>
+                       <Project Language="C#" CommonReferences="true" AssemblyName="CSProject">
+                           <Document FilePath="CSDocument">
+using System;
+
+public class C
+{
+    public virtual event EventHandler e;
+}
+        </Document>
+                       </Project>
+                   </Workspace>
+
+        Using workspace = TestWorkspaceFactory.CreateWorkspace(text)
+            Dim hostDocument = workspace.Documents.First()
+            Dim caretPosition = hostDocument.CursorPosition.Value
+            Dim document = workspace.CurrentSolution.GetDocument(hostDocument.Id)
+            Dim triggerInfo = CompletionTriggerInfo.CreateInvokeCompletionTriggerInfo()
+            Dim group = CompletionProvider.GetGroupAsync(document, caretPosition, triggerInfo).Result
+            Assert.False(group.Items.Any(Function(c) c.DisplayText = "e"))
+        End Using
+    End Sub
 End Class