Merge pull request #6243 from davkean/dev/davkean/peverify

Disable all PEVerification until #6190 is resolved

src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests_WellKnownAttributes.cs

@@ -3125,7 +3125,7 @@ public class C2 { }
 
         #region ComImportAttribute, CoClassAttribute
 
-        [Fact]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190")]
         public void TestComImportAttribute()
         {
             string source = @"
@@ -4937,7 +4937,7 @@ public void TestComCompatibleVersionAttribute_Invalid_02()
 
         #region WindowsRuntimeImportAttribute
 
-        [Fact]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190")]
         public void TestWindowsRuntimeImportAttribute()
         {
             var source = @"

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenDynamicTests.cs

@@ -303,7 +303,7 @@ dynamic F(dynamic d)
             Assert.Equal(1, ((CSharpCompilation)c.Compilation).GlobalNamespace.GetMember<NamespaceSymbol>("System").GetMember<NamedTypeSymbol>("Func`13").Arity);
         }
 
-        [Fact, WorkItem(530436, "DevDiv")]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190"), WorkItem(530436, "DevDiv")]
         public void InvalidFunc_Constraints()
         {
             var systemCoreRef = CreateCompilationWithMscorlib(SystemCoreSource, assemblyName: GetUniqueName()).EmitToImageReference();

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenOverridingAndHiding.cs

@@ -2358,7 +2358,7 @@ public static void Main()
         }
 
         [WorkItem(528172, "DevDiv")]
-        [Fact]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190")]
         public void TestHideWithInaccessibleVirtualMember()
         {
             // Tests:

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenTests.cs

@@ -10201,7 +10201,7 @@ static void Main()
         }
 
         [WorkItem(528183, "DevDiv")]
-        [Fact]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190")]
         public void TestExternWithoutDLLImport()
         {
             string source = @"

src/Compilers/CSharp/Test/Emit/CodeGen/DestructorTests.cs

@@ -517,7 +517,7 @@ public void IsRuntimeFinalizer2()
         }
 
         [WorkItem(528903, "DevDiv")] // Won't fix - test just captures behavior.
-        [Fact]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190")]
         public void DestructorOverridesPublicFinalize()
         {
             var text = @"

src/Compilers/CSharp/Test/Emit/Emit/EmitMetadata.cs

@@ -2113,7 +2113,7 @@ private void CheckInternalMembers(NamedTypeSymbol type, bool isFromSource)
                 Assert.Null(member);
         }
 
-        [Fact, WorkItem(90)]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/6190"), WorkItem(90)]
         public void EmitWithNoResourcesAllPlatforms()
         {
             var comp = CreateCompilationWithMscorlib("class Test { static void Main() { } }");

src/Compilers/CSharp/Test/Symbol/Symbols/Source/FieldTests.cs

@@ -354,7 +354,7 @@ class A
         /// Fields named "value__" should be marked rtspecialname.
         /// </summary>
         [WorkItem(546185, "DevDiv")]
-        [ClrOnlyFact(ClrOnlyReason.Unknown)]
+        [ClrOnlyFact(ClrOnlyReason.Unknown, Skip = "https://github.com/dotnet/roslyn/issues/6190")]
         public void RTSpecialName()
         {
             var source =

src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests_WellKnownAttributes.vb

@@ -4248,12 +4248,12 @@ BC32500: 'GuidAttribute' cannot be applied because the format of the GUID '69D3E
 
 #Region "WindowsRuntimeImportAttribute"
 
-        <Fact>
+        <Fact(Skip:="https://github.com/dotnet/roslyn/issues/6190")>
         <WorkItem(531295, "DevDiv")>
         Public Sub TestWindowsRuntimeImportAttribute()
             Dim source = <compilation>
-                             <file name="a.vb">
-                                 <![CDATA[
+                <file name="a.vb">
+                    <![CDATA[
 Imports System
 Imports System.Runtime.InteropServices
 
@@ -4272,8 +4272,8 @@ Class A
 	End Sub
 End Class
 ]]>
-                             </file>
-                         </compilation>
+                </file>
+            </compilation>
 
             Dim sourceValidator =
                 Sub(m As ModuleSymbol)
@@ -4338,7 +4338,7 @@ End Class
         Public Sub TestSynthesizedSTAThread()
             Dim source =
     <compilation>
-        <file name="a.vb">
+                    <file name="a.vb">
             Imports System
             Module Module1
                 Sub foo()
@@ -4348,7 +4348,7 @@ End Class
                 End Sub
             End Module
         </file>
-    </compilation>
+                </compilation>
 
             Dim compilation = CreateCompilationWithMscorlibAndVBRuntime(source, TestOptions.ReleaseExe)
             compilation.AssertNoErrors()
@@ -4369,7 +4369,7 @@ End Class
         Public Sub TestNoSynthesizedSTAThread_01()
             Dim source =
     <compilation>
-        <file name="a.vb">
+                        <file name="a.vb">
             Imports System
             Module Module1
                 Sub foo()
@@ -4379,7 +4379,7 @@ End Class
                 End Sub
             End Module
         </file>
-    </compilation>
+                    </compilation>
 
             Dim compilation = CreateCompilationWithMscorlibAndVBRuntime(source, TestOptions.ReleaseDll)
             compilation.AssertNoErrors()
@@ -4400,8 +4400,8 @@ End Class
         Public Sub TestNoSynthesizedSTAThread_02()
             Dim source =
 <compilation>
-    <file name="a.vb">
-        <![CDATA[ 
+                            <file name="a.vb">
+                                <![CDATA[ 
             Imports System
                 Module Module1
             Sub foo()
@@ -4412,8 +4412,8 @@ End Class
             End Sub
             End Module
         ]]>
-    </file>
-</compilation>
+                            </file>
+                        </compilation>
 
             Dim compilation = CreateCompilationWithMscorlibAndVBRuntime(source, TestOptions.ReleaseExe)
             compilation.AssertNoErrors()
@@ -4434,8 +4434,8 @@ End Class
         Public Sub TestNoSynthesizedSTAThread_03()
             Dim source =
 <compilation>
-    <file name="a.vb">
-        <![CDATA[ 
+                                <file name="a.vb">
+                                    <![CDATA[ 
             Imports System
                 Module Module1
             Sub foo()
@@ -4446,8 +4446,8 @@ End Class
             End Sub
             End Module
         ]]>
-    </file>
-</compilation>
+                                </file>
+                            </compilation>
 
             Dim compilation = CreateCompilationWithMscorlibAndVBRuntime(source, TestOptions.ReleaseExe)
             compilation.AssertNoErrors()
@@ -4470,8 +4470,8 @@ End Class
         <Fact, WorkItem(81)>
         Public Sub DisallowRequiredAttributeInSource()
             Dim source = <compilation>
-                             <file name="a.vb">
-                                 <![CDATA[
+                                    <file name="a.vb">
+                                        <![CDATA[
 Namespace VBClassLibrary
 
     <System.Runtime.CompilerServices.RequiredAttribute(GetType(RS))>
@@ -4497,8 +4497,8 @@ Namespace VBClassLibrary
 
 End Namespace
 ]]>
-                             </file>
-                         </compilation>
+                                    </file>
+                                </compilation>
 
             Dim comp = CreateCompilationWithMscorlib(source)
             CompilationUtils.AssertTheseDiagnostics(comp,
@@ -4539,8 +4539,8 @@ BC37235: The RequiredAttribute attribute is not permitted on Visual Basic types.
                 ]]>
 
             Dim source = <compilation>
-                             <file name="a.vb">
-                                 <![CDATA[
+                                        <file name="a.vb">
+                                            <![CDATA[
 Module M
     Sub Main()
         Dim r = New RequiredAttrClass()
@@ -4548,8 +4548,8 @@ Module M
     End Sub
 End Module
 ]]>
-                             </file>
-                         </compilation>
+                                        </file>
+                                    </compilation>
 
             Dim ilReference = CompileIL(ilSource.Value)
 
@@ -4637,8 +4637,8 @@ BC30649: 'RequiredAttrClass' is an unsupported type.
                 ]]>
 
             Dim source = <compilation>
-                             <file name="a.vb">
-                                 <![CDATA[
+                                            <file name="a.vb">
+                                                <![CDATA[
 Imports RequiredAttr
 
 Public Class C
@@ -4651,8 +4651,8 @@ Public Class C
     End Function
 End Class
 ]]>
-                             </file>
-                         </compilation>
+                                            </file>
+                                        </compilation>
 
             Dim ilReference = CompileIL(ilSource.Value)
 
@@ -4677,7 +4677,7 @@ BC30657: 'sc1_method' has a return type that is not supported or parameter types
         Public Sub TestAttributePropagationForAsyncAndIterators_01()
             Dim source =
             <compilation>
-                <file name="attr.vb"><![CDATA[
+                                                <file name="attr.vb"><![CDATA[
 Imports System
 Imports System.Collections.Generic
 Imports System.Threading.Tasks
@@ -4724,8 +4724,8 @@ Class MyAttribute
     Inherits System.Attribute
 End Class
             ]]>
-                </file>
-            </compilation>
+                                                </file>
+                                            </compilation>
 
             Dim attributeValidator As Action(Of ModuleSymbol) =
             Sub(m As ModuleSymbol)
@@ -4789,7 +4789,7 @@ End Class
         Public Sub TestAttributePropagationForAsyncAndIterators_02()
             Dim source =
             <compilation>
-                <file name="attr.vb"><![CDATA[
+                                                    <file name="attr.vb"><![CDATA[
 Imports System
 Imports System.Collections.Generic
 Imports System.Threading.Tasks
@@ -4839,8 +4839,8 @@ Class MyAttribute
     Inherits System.Attribute
 End Class
             ]]>
-                </file>
-            </compilation>
+                                                    </file>
+                                                </compilation>
 
             Dim attributeValidator As Action(Of ModuleSymbol) =
             Sub(m As ModuleSymbol)

src/Compilers/VisualBasic/Test/Emit/Emit/EmitMetadata.vb

@@ -904,7 +904,7 @@ End Class
 
         End Sub
 
-        <Fact, WorkItem(90)>
+        <Fact(Skip:="https://github.com/dotnet/roslyn/issues/6190"), WorkItem(90)>
         Public Sub EmitWithNoResourcesAllPlatforms()
             Dim comp = CreateCompilationWithMscorlib(
                 <compilation>

src/Compilers/VisualBasic/Test/Symbol/SymbolsTests/Source/FieldTests.vb

@@ -431,7 +431,7 @@ End Class]]>,
         ''' Fields named "value__" should be marked rtspecialname.
         ''' </summary>
         <WorkItem(546185, "DevDiv")>
-        <Fact()>
+        <Fact(Skip:="https://github.com/dotnet/roslyn/issues/6190")>
         Public Sub RTSpecialName()
             Dim compilation = CompilationUtils.CreateCompilationWithMscorlibAndVBRuntime(
 <compilation>

src/Test/Utilities/Desktop/HostedRuntimeEnvironment.cs

@@ -799,7 +799,9 @@ public string[] PeVerifyModules(string[] modulesToVerify, bool throwOnError = tr
             // for ARM testing at present.
             StringBuilder errors = new StringBuilder();
             List<string> allOutput = new List<string>();
-#if !(ARM)
+
+// Disable all PEVerification due to https://github.com/dotnet/roslyn/issues/6190
+#if false
 
             foreach (var name in modulesToVerify)
             {