Merge pull request #45840 from allisonchou/ChangeSignatureAccessibility2

Change signature accessibility - add screenreader header for empty column

Merge pull request #45840 from allisonchou/ChangeSignatureAccessibility2
Change signature accessibility - add screenreader header for empty column
82d46ca6 · Allison Chou · GitHub · 9dd7c7db · a957f39c · 82d46ca6
16 changed file
--- a/src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml
+++ b/src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml
@@ -203,6 +203,11 @@
                    <!-- This column appears empty to sighted users, but provides an improved screenreader 
                    experience that avoids moving cell-by-cell through the DataGrid -->
                    <DataGridTextColumn x:Name="automationHeader" IsReadOnly="True" Width="0">
+                        <DataGridTextColumn.HeaderStyle>
+                            <Style TargetType="{x:Type DataGridColumnHeader}">
+                                <Setter Property="AutomationProperties.Name" Value="{Binding ElementName=dialog, Path=CurrentParameter}" />
+                            </Style>
+                        </DataGridTextColumn.HeaderStyle>
                        <DataGridTextColumn.CellStyle>
                            <Style TargetType="DataGridCell" BasedOn="{StaticResource DataGridCellStyle}">
                                <Setter Property="AutomationProperties.Name" Value="{Binding FullAutomationText}"/>

--- a/src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml.cs
+++ b/src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml.cs
@@ -22,6 +22,7 @@ internal partial class ChangeSignatureDialog : DialogWindow

        // Expose localized strings for binding
        public string ChangeSignatureDialogTitle { get { return ServicesVSResources.Change_Signature; } }
+        public string CurrentParameter { get { return ServicesVSResources.Current_parameter; } }
        public string Parameters { get { return ServicesVSResources.Parameters_colon2; } }
        public string PreviewMethodSignature { get { return ServicesVSResources.Preview_method_signature_colon; } }
        public string PreviewReferenceChanges { get { return ServicesVSResources.Preview_reference_changes; } }

--- a/src/VisualStudio/Core/Def/ServicesVSResources.resx
+++ b/src/VisualStudio/Core/Def/ServicesVSResources.resx
@@ -1529,4 +1529,7 @@ I agree to all of the foregoing:</value>
  <data name="Warning_colon_type_does_not_bind" xml:space="preserve">
    <value>Warning: type does not bind</value>
  </data>
+  <data name="Current_parameter" xml:space="preserve">
+    <value>Current parameter</value>
+  </data>
 </root>
\ No newline at end of file
--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.cs.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.cs.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Aktuální dokument</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.de.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.de.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Aktuelles Dokument</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.es.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.es.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Documento actual</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.fr.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.fr.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Document en cours</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.it.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.it.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Documento corrente</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.ja.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.ja.xlf
@@ -157,6 +157,11 @@
        <target state="translated">現在のドキュメント</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.ko.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.ko.xlf
@@ -157,6 +157,11 @@
        <target state="translated">현재 문서</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.pl.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.pl.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Bieżący dokument</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.pt-BR.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.pt-BR.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Documento atual</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.ru.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.ru.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Текущий документ</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.tr.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.tr.xlf
@@ -157,6 +157,11 @@
        <target state="translated">Geçerli belge</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hans.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hans.xlf
@@ -157,6 +157,11 @@
        <target state="translated">当前文档</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>

--- a/src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hant.xlf
+++ b/src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hant.xlf
@@ -157,6 +157,11 @@
        <target state="translated">目前的文件</target>
        <note />
      </trans-unit>
+      <trans-unit id="Current_parameter">
+        <source>Current parameter</source>
+        <target state="new">Current parameter</target>
+        <note />
+      </trans-unit>
      <trans-unit id="Edit">
        <source>_Edit</source>
        <target state="new">_Edit</target>