Ban the ongoing use of IInProcessAnalyzer

RenameTrackingDiagnosticAnalyzer is the only remaining in-process
analyzer, which is tracked by #35808. Use of IInProcessAnalyzer in new
locations is not allowed.

src/EditorFeatures/Core/Implementation/RenameTracking/AbstractRenameTrackingCodeFixProvider.cs

@@ -29,7 +29,9 @@ internal abstract class AbstractRenameTrackingCodeFixProvider : CodeFixProvider
 
         public sealed override ImmutableArray<string> FixableDiagnosticIds
         {
+#pragma warning disable CS0618 // Type or member is obsolete
             get { return ImmutableArray.Create(RenameTrackingDiagnosticAnalyzer.DiagnosticId); }
+#pragma warning restore CS0618 // Type or member is obsolete
         }
 
         public sealed override Task RegisterCodeFixesAsync(CodeFixContext context)

src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs

 // Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
 
+using System;
 using System.Collections.Immutable;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Roslyn.Utilities;
@@ -7,6 +8,7 @@
 namespace Microsoft.CodeAnalysis.Editor.Implementation.RenameTracking
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
+    [Obsolete("https://github.com/dotnet/roslyn/issues/35808")]
     internal sealed class RenameTrackingDiagnosticAnalyzer : DiagnosticAnalyzer, IBuiltInAnalyzer, IInProcessAnalyzer
     {
         public const string DiagnosticId = "RenameTracking";

src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingTaggerProvider.StateMachine.cs

@@ -298,8 +298,10 @@ internal async Task<IEnumerable<Diagnostic>> GetDiagnostic(SyntaxTree tree, Diag
                         var textSpan = snapshotSpan.Span.ToTextSpan();
 
                         var builder = ImmutableDictionary.CreateBuilder<string, string>();
+#pragma warning disable CS0618 // Type or member is obsolete
                         builder.Add(RenameTrackingDiagnosticAnalyzer.RenameFromPropertyKey, trackingSession.OriginalName);
                         builder.Add(RenameTrackingDiagnosticAnalyzer.RenameToPropertyKey, snapshotSpan.GetText());
+#pragma warning restore CS0618 // Type or member is obsolete
                         var properties = builder.ToImmutable();
 
                         var diagnostic = Diagnostic.Create(diagnosticDescriptor,

src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingTaggerProvider.cs

@@ -144,8 +144,10 @@ internal static async Task<IEnumerable<Diagnostic>> GetDiagnosticsAsync(SyntaxTr
 
             var message = string.Format(
                 EditorFeaturesResources.Rename_0_to_1,
+#pragma warning disable CS0618 // Type or member is obsolete
                 diagnostic.Properties[RenameTrackingDiagnosticAnalyzer.RenameFromPropertyKey],
                 diagnostic.Properties[RenameTrackingDiagnosticAnalyzer.RenameToPropertyKey]);
+#pragma warning restore CS0618 // Type or member is obsolete
 
             return new RenameTrackingCodeAction(document, message, refactorNotifyServices, undoHistoryRegistry);
         }

src/EditorFeatures/Test/RenameTracking/RenameTrackingTestState.cs

@@ -176,7 +176,9 @@ public async Task AssertNoTag()
         public async Task<IList<Diagnostic>> GetDocumentDiagnosticsAsync(Document document = null)
         {
             document = document ?? this.Workspace.CurrentSolution.GetDocument(_hostDocument.Id);
+#pragma warning disable CS0618 // Type or member is obsolete
             var analyzer = new RenameTrackingDiagnosticAnalyzer();
+#pragma warning restore CS0618 // Type or member is obsolete
             return (await DiagnosticProviderTestUtilities.GetDocumentDiagnosticsAsync(analyzer, document,
                 (await document.GetSyntaxRootAsync()).FullSpan)).ToList();
         }
@@ -197,7 +199,9 @@ public async Task AssertTag(string expectedFromName, string expectedToName, bool
 
             // There should be a single rename tracking diagnostic
             Assert.Equal(1, diagnostics.Count);
+#pragma warning disable CS0618 // Type or member is obsolete
             Assert.Equal(RenameTrackingDiagnosticAnalyzer.DiagnosticId, diagnostics[0].Id);
+#pragma warning restore CS0618 // Type or member is obsolete
 
             var actions = new List<CodeAction>();
             var context = new CodeFixContext(document, diagnostics[0], (a, d) => actions.Add(a), CancellationToken.None);

src/Features/Core/Portable/Diagnostics/AnalyzerHelper.cs

@@ -67,6 +67,7 @@ public static bool IsOpenFileOnly(this DiagnosticAnalyzer analyzer, Workspace wo
             return false;
         }
 
+        [Obsolete("In-process analyzer restrictions are obsolete.")]
         public static bool IsInProcessOnly(this DiagnosticAnalyzer analyzer)
             => analyzer is IInProcessAnalyzer;
 

src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.InProcOrRemoteHostAnalyzerRunner.cs

@@ -65,7 +65,9 @@ public InProcOrRemoteHostAnalyzerRunner(DiagnosticAnalyzerService owner, Abstrac
                 //
                 // we have this open file analyzers since some of our built in analyzers such as SimplifyTypeNamesDiagnosticAnalyzer are too
                 // slow to run for whole solution when full solution analysis is on. easily taking more than an hour to run whole solution.
+#pragma warning disable CS0618 // Type or member is obsolete
                 var inProcResultTask = AnalyzeInProcAsync(CreateAnalyzerDriver(analyzerDriver, a => (forcedAnalysis || !a.IsOpenFileOnly(workspace)) && a.IsInProcessOnly()), project, remoteHostClient, cancellationToken);
+#pragma warning restore CS0618 // Type or member is obsolete
 
                 // out of proc analysis will use 2 source of analyzers. one is AnalyzerReference from project (nuget). and the other is host analyzers (vsix) 
                 // that are not part of roslyn solution. these host analyzers must be sync to OOP before hand by the Host. 
@@ -149,7 +151,9 @@ private async Task FireAndForgetReportAnalyzerPerformanceAsync(Project project,
                 {
                     var analyzerMap = pooledObject.Object;
 
+#pragma warning disable CS0618 // Type or member is obsolete
                     analyzerMap.AppendAnalyzerMap(analyzerDriver.Analyzers.Where(a => !a.IsInProcessOnly() && (forcedAnalysis || !a.IsOpenFileOnly(solution.Workspace))));
+#pragma warning restore CS0618 // Type or member is obsolete
                     if (analyzerMap.Count == 0)
                     {
                         return DiagnosticAnalysisResultMap.Create(ImmutableDictionary<DiagnosticAnalyzer, DiagnosticAnalysisResult>.Empty, ImmutableDictionary<DiagnosticAnalyzer, AnalyzerTelemetryInfo>.Empty);

src/Features/Core/Portable/Diagnostics/IInProcessAnalyzer.cs

 // Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
 
+using System;
+
 namespace Microsoft.CodeAnalysis.Diagnostics
 {
     /// <summary>
     /// A marker interface for <see cref="DiagnosticAnalyzer"/> implementations that do not support out-of-process
     /// execution.
     /// </summary>
+    [Obsolete("Diagnostic analyzers must not be restricted in in-process analysis.", error: true)]
     internal interface IInProcessAnalyzer
     {
     }