Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
8012e05c
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
“35be70dfcb3f4b9dfef93a315bbff7fee658bb9e”上不存在“...node/watcher/unix/test/chockidarWatcherService.test.ts”
提交
8012e05c
编写于
8月 28, 2019
作者:
H
HeeJae Chang
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
make sure we initialize experimentation service outside of lock since it can jump to other threads.
上级
4d9190ea
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
13 addition
and
4 deletion
+13
-4
src/VisualStudio/Core/Def/Implementation/Remote/RemoteHostClientServiceFactory.RemoteHostClientService.cs
...RemoteHostClientServiceFactory.RemoteHostClientService.cs
+13
-4
未找到文件。
src/VisualStudio/Core/Def/Implementation/Remote/RemoteHostClientServiceFactory.RemoteHostClientService.cs
浏览文件 @
8012e05c
...
...
@@ -55,6 +55,16 @@ public class RemoteHostClientService : ForegroundThreadAffinitizedObject, IRemot
public
void
Enable
()
{
// experimentation service unfortunately uses JTF to jump to UI thread in certain cases
// which can cause deadlock if 2 parties try to enable OOP from BG and then FG before
// experimentation service tries to jump to UI thread.
//
// this doesn't attempt to solve our JTF and some services being not free-thread issue here, but
// try to fix this particular deadlock issue only. we already have long discussion on
// how we need to deal with JTF, Roslyn service requirements and VS services reality conflicting
// each others. architectural fix should come from the result of that discussion.
var
experimentationService
=
_workspace
.
Services
.
GetService
<
IExperimentationService
>();
lock
(
_gate
)
{
if
(
_remoteClientTask
!=
null
)
...
...
@@ -82,7 +92,7 @@ public void Enable()
}
// set bitness
SetRemoteHostBitness
();
SetRemoteHostBitness
(
experimentationService
);
// make sure we run it on background thread
_shutdownCancellationTokenSource
=
new
CancellationTokenSource
();
...
...
@@ -176,13 +186,12 @@ public Task<RemoteHostClient> TryGetRemoteHostClientAsync(CancellationToken canc
return
remoteClientTask
;
}
private
void
SetRemoteHostBitness
()
private
void
SetRemoteHostBitness
(
IExperimentationService
experimentationService
)
{
var
x64
=
_workspace
.
Options
.
GetOption
(
RemoteHostOptions
.
OOP64Bit
);
if
(!
x64
)
{
x64
=
_workspace
.
Services
.
GetService
<
IExperimentationService
>().
IsExperimentEnabled
(
WellKnownExperimentNames
.
RoslynOOP64bit
);
x64
=
experimentationService
.
IsExperimentEnabled
(
WellKnownExperimentNames
.
RoslynOOP64bit
);
}
// log OOP bitness
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录