Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
7c36f882
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
7c36f882
编写于
7月 05, 2017
作者:
R
Ravi Chande
提交者:
GitHub
7月 05, 2017
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #20509 from rchande/sighelpCrash
Fix crash in element access signature help
上级
f9142af0
04fe3df4
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
47 addition
and
1 deletion
+47
-1
src/EditorFeatures/CSharpTest/SignatureHelp/ElementAccessExpressionSignatureHelpProviderTests.cs
...Help/ElementAccessExpressionSignatureHelpProviderTests.cs
+42
-0
src/Features/CSharp/Portable/SignatureHelp/ElementAccessExpressionSignatureHelpProvider.cs
...atureHelp/ElementAccessExpressionSignatureHelpProvider.cs
+5
-1
未找到文件。
src/EditorFeatures/CSharpTest/SignatureHelp/ElementAccessExpressionSignatureHelpProviderTests.cs
浏览文件 @
7c36f882
...
...
@@ -898,6 +898,48 @@ public void Method(TestClass tc)
"
;
await
TestAsync
(
markup
,
new
[]
{
new
SignatureHelpTestItem
(
"int WithIndexer[int index]"
)
},
usePreviousCharAsTrigger
:
true
);
}
[
WorkItem
(
20507
,
"https://github.com/dotnet/roslyn/issues/20507"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
SignatureHelp
)]
public
async
Task
InConditionalIndexingFollowedByMemberAccess
()
{
var
markup
=
@"
class Indexable
{
public Indexable this[int x] { get => null; }
Indexable Count;
static void Main(string[] args)
{
Indexable x;
x?[$$].Count;
}
}
"
;
await
TestAsync
(
markup
,
new
[]
{
new
SignatureHelpTestItem
(
"Indexable Indexable[int x]"
)
},
usePreviousCharAsTrigger
:
false
);
}
[
WorkItem
(
20507
,
"https://github.com/dotnet/roslyn/issues/20507"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
SignatureHelp
)]
public
async
Task
InConditionalIndexingFollowedByConditionalAcesss
()
{
var
markup
=
@"
class Indexable
{
public Indexable this[int x] { get => null; }
Indexable Count;
static void Main(string[] args)
{
Indexable x;
x?[$$].Count?.Count;
}
}
"
;
await
TestAsync
(
markup
,
new
[]
{
new
SignatureHelpTestItem
(
"Indexable Indexable[int x]"
)
},
usePreviousCharAsTrigger
:
false
);
}
}
}
}
src/Features/CSharp/Portable/SignatureHelp/ElementAccessExpressionSignatureHelpProvider.cs
浏览文件 @
7c36f882
...
...
@@ -372,7 +372,11 @@ internal static bool TryGetSyntax(SyntaxNode root, int position, ISyntaxFactsSer
{
if
(
CommonSignatureHelpUtilities
.
TryGetSyntax
(
root
,
position
,
syntaxFacts
,
triggerReason
,
IsTriggerToken
,
IsArgumentListToken
,
cancellationToken
,
out
ElementBindingExpressionSyntax
elementBindingExpression
))
{
identifier
=
((
ConditionalAccessExpressionSyntax
)
elementBindingExpression
.
Parent
).
Expression
;
// Find the first conditional access expression that starts left of our open bracket
var
conditionalAccess
=
elementBindingExpression
.
FirstAncestorOrSelf
<
ConditionalAccessExpressionSyntax
>(
c
=>
c
.
SpanStart
<
elementBindingExpression
.
SpanStart
);
identifier
=
conditionalAccess
.
Expression
;
openBrace
=
elementBindingExpression
.
ArgumentList
.
OpenBracketToken
;
return
true
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录