Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
7b7c5ef2
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
7b7c5ef2
编写于
9月 09, 2020
作者:
R
Rikki Gibson
提交者:
GitHub
9月 09, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix nullable analysis of lambdas within conditional expressions (#47405)
上级
f3027ac1
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
76 addition
and
0 deletion
+76
-0
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
+7
-0
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
...rp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
+69
-0
未找到文件。
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
浏览文件 @
7b7c5ef2
...
...
@@ -4229,6 +4229,7 @@ private static TypeWithState GetNullCoalescingResultType(TypeWithState rightResu
consequenceConversion
,
resultTypeWithAnnotations
,
consequenceRValue
,
consequenceState
,
consequenceEndReachable
);
TypeWithState
convertedAlternativeResult
=
convertResult
(
...
...
@@ -4237,6 +4238,7 @@ private static TypeWithState GetNullCoalescingResultType(TypeWithState rightResu
alternativeConversion
,
resultTypeWithAnnotations
,
alternativeRValue
,
alternativeState
,
alternativeEndReachable
);
resultState
=
convertedConsequenceResult
.
State
.
Join
(
convertedAlternativeResult
.
State
);
...
...
@@ -4272,8 +4274,12 @@ private static TypeWithState GetNullCoalescingResultType(TypeWithState rightResu
Conversion
conversion
,
TypeWithAnnotations
targetType
,
TypeWithState
operandType
,
LocalState
state
,
bool
isReachable
)
{
var
savedState
=
this
.
State
;
this
.
State
=
state
;
bool
previousDisabledDiagnostics
=
_disableDiagnostics
;
// If the node is not reachable, then we're only visiting to get
// nullability information for the public API, and not to produce diagnostics.
...
...
@@ -4301,6 +4307,7 @@ private static TypeWithState GetNullCoalescingResultType(TypeWithState rightResu
resultType
=
default
;
_disableDiagnostics
=
previousDisabledDiagnostics
;
}
this
.
State
=
savedState
;
return
resultType
;
}
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
浏览文件 @
7b7c5ef2
...
...
@@ -51615,6 +51615,75 @@ static void F()
Diagnostic(ErrorCode.WRN_NullabilityMismatchInParameterTypeOfTargetDelegate, "(I<object?> o) => { }").WithArguments("o", "lambda expression", "D<I<object>>").WithLocation(10, 26));
}
[Fact, WorkItem(40561, "https://github.com/dotnet/roslyn/issues/40561")]
public void ReturnLambda_InsideConditionalExpr()
{
var source = @"
using System;
class C
{
static void M0(string s) { }
static Action? M1(string? s)
=> s != null
? () => M0(s)
: (Action?)null;
static Action? M2(string? s)
=> s != null
? (Action)(() => M0(s))
: null;
static Action? M3(string? s)
=> s != null
? () => { M0(s); s = null; }
: (Action?)null;
static Action? M4(string? s)
{
return s != null
? local(() => M0(s), s = null)
: (Action?)null;
Action local(Action a1, string? s)
{
return a1;
}
}
static Action? M5(string? s)
{
return s != null
? local(s = null, () => M0(s)) // 1
: (Action?)null;
Action local(string? s, Action a1)
{
return a1;
}
}
static Action? M6(string? s)
{
return s != null
? local(() => M0(s))
: (Action?)null;
Action local(Action a1)
{
s = null;
return a1;
}
}
}";
var comp = CreateNullableCompilation(source);
comp.VerifyDiagnostics(
// (38,40): warning CS8604: Possible null reference argument for parameter 's' in 'void C.M0(string s)'.
// ? local(s = null, () => M0(s)) // 1
Diagnostic(ErrorCode.WRN_NullReferenceArgument, "s").WithArguments("s", "void C.M0(string s)").WithLocation(38, 40));
}
[Fact]
[WorkItem(29617, "https://github.com/dotnet/roslyn/issues/29617")]
public void ReturnTypeInference_01()
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录