Use an empty message for developer builds

7868953d · Jared Parsons · 3148f556 · 7868953d · 7868953d · 7868953d
32 changed file
--- a/src/NuGet/BuildNuGets.csx
+++ b/src/NuGet/BuildNuGets.csx
@@ -7,6 +7,7 @@ using System.Linq;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Text;
+using System.Text.RegularExpressions;
 using System.Xml.Linq;

 string usage = @"usage: BuildNuGets.csx <binaries-dir> <build-version> <output-directory> <git sha>";
@@ -36,7 +37,15 @@ var OutDir = Path.GetFullPath(Args[2]).TrimEnd('\\');
 // In developer builds the commit sha is <developer build>. Need to make sure
 // we escape the values so that 
 var CommitSha = Args[3].Replace("<", "").Replace(">", "");
-var CommitUrl = $"https://github.com/dotnet/roslyn/commit/{CommitSha}";
+var CommitIsDeveloperBuild = CommitSha == "<developer build>";
+if (!CommitIsDeveloperBuild && !Regex.IsMatch(CommitSha, "[A-Fa-f0-9]+"))
+{
+    Console.WriteLine("Invalid Git sha value: expected <developer build> or a valid sha");
+    Environment.Exit(1);
+}
+var CommitPathMessage = CommitIsDeveloperBuild
+    ? $"This package was built from the source at https://github.com/dotnet/roslyn/commit/{CommitSha}"
+    : "This an unofficial build from a developers machine";

 var LicenseUrlRedist = @"http://go.microsoft.com/fwlink/?LinkId=529443";
 var LicenseUrlNonRedist = @"http://go.microsoft.com/fwlink/?LinkId=529444";
@@ -211,7 +220,7 @@ int PackFiles(string[] nuspecFiles, string licenseUrl)
        { "tags", Tags },
        { "emptyDirPath", emptyDir },
        { "additionalFilesPath", NuGetAdditionalFilesPath },
-        { "commitUrl", CommitUrl }
+        { "commitPathMessage", CommitPathMessage }
    };

    foreach (var dependencyVersion in dependencyVersions)

--- a/src/NuGet/Microsoft.CodeAnalysis.Build.Tasks.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Build.Tasks.nuspec
@@ -7,7 +7,7 @@
        Contains the build task and targets used by MSBuild to run the C# and VB compilers.
        Supports using VBCSCompiler on Windows.

-        This package was built from the source at $commitUrl$
+        $commitPathMessage$
    </description>
    <dependencies>
      <group targetFramework="netstandard1.3">

--- a/src/NuGet/Microsoft.CodeAnalysis.CSharp.CodeStyle.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.CSharp.CodeStyle.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") code style analyzers for C#.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
    </dependencies>


--- a/src/NuGet/Microsoft.CodeAnalysis.CSharp.Features.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.CSharp.Features.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") support for creating C# editing experiences.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Features" version="$version$" />
      <dependency id="Microsoft.CodeAnalysis.CSharp.Workspaces" version="$version$" />

--- a/src/NuGet/Microsoft.CodeAnalysis.CSharp.Scripting.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.CSharp.Scripting.nuspec
@@ -3,7 +3,7 @@
  <metadata>
    <id>Microsoft.CodeAnalysis.CSharp.Scripting</id>
    <summary>Microsoft .NET Compiler Platform ("Roslyn") CSharp scripting package.</summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <language>en-US</language>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <version>$version$</version>

--- a/src/NuGet/Microsoft.CodeAnalysis.CSharp.Workspaces.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.CSharp.Workspaces.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") support for analyzing C# projects and solutions.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.CSharp" version="[$version$]" />
      <dependency id="Microsoft.CodeAnalysis.Workspaces.Common" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.CSharp.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.CSharp.nuspec
@@ -7,7 +7,7 @@

      More details at https://aka.ms/roslyn-packages
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Common" version="[$version$]" />
    </dependencies>

--- a/src/NuGet/Microsoft.CodeAnalysis.Common.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Common.nuspec
@@ -6,7 +6,7 @@
    <description>
      A shared package used by the Microsoft .NET Compiler Platform ("Roslyn"). Do not install this package manually, it will be added as a prerequisite by other packages that require it.

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <group targetFramework="netstandard1.3">

--- a/src/NuGet/Microsoft.CodeAnalysis.Compilers.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Compilers.nuspec
@@ -8,7 +8,7 @@

      More details at https://aka.ms/roslyn-packages

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.CSharp" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.EditorFeatures.Text.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.EditorFeatures.Text.nuspec
@@ -9,7 +9,7 @@
      Supported Platforms:
      - .NET Framework 4.6

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Workspaces.Common" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.EditorFeatures.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.EditorFeatures.nuspec
@@ -9,7 +9,7 @@
      Supported Platforms:
      - .NET Framework 4.6
      
-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Features" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.Features.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Features.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") support for creating editing experiences.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Workspaces.Common" version="$version$" />
    </dependencies>

--- a/src/NuGet/Microsoft.CodeAnalysis.Remote.Razor.ServiceHub.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Remote.Razor.ServiceHub.nuspec
@@ -11,7 +11,7 @@
 Supported Platforms:
 - .NET Framework 4.6

-    This package was built from the source at $commitUrl$
+    $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Remote.Workspaces" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.Remote.ServiceHub.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Remote.ServiceHub.nuspec
@@ -11,7 +11,7 @@
 Supported Platforms:
 - .NET Framework 4.6

-    This package was built from the source at $commitUrl$
+    $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Remote.Workspaces" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.Remote.Workspaces.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Remote.Workspaces.nuspec
@@ -11,7 +11,7 @@
 Supported Platforms:
 - .NET Framework 4.6

-    This package was built from the source at $commitUrl$
+    $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Common" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.Scripting.Common.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Scripting.Common.nuspec
@@ -6,7 +6,7 @@
    <description>
      Microsoft .NET Compiler Platform ("Roslyn") shared scripting package. Do not install this package manually, it will be added as a prerequisite by other packages that require it.

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>

    <language>en-US</language>

--- a/src/NuGet/Microsoft.CodeAnalysis.Scripting.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Scripting.nuspec
@@ -6,7 +6,7 @@
    <description>
      Microsoft .NET Compiler Platform ("Roslyn") CSharp and VB scripting package.

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.CSharp.Scripting" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.CodeStyle.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.CodeStyle.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") code style analyzers for Visual Basic.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
    </dependencies>


--- a/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.Features.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.Features.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") support for creating Visual Basic editing experiences.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Features" version="$version$" />
      <dependency id="Microsoft.CodeAnalysis.VisualBasic.Workspaces" version="$version$" />

--- a/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.Scripting.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.Scripting.nuspec
@@ -6,7 +6,7 @@
    <description>
      Microsoft .NET Compiler Platform ("Roslyn") Visual Basic scripting package.
      
-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>

    <language>en-US</language>

--- a/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.Workspaces.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.Workspaces.nuspec
@@ -5,7 +5,7 @@
    <summary>
      .NET Compiler Platform ("Roslyn") support for analyzing Visual Basic projects and solutions.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.VisualBasic" version="[$version$]" />
      <dependency id="Microsoft.CodeAnalysis.Workspaces.Common" version="[$version$]" />

--- a/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.VisualBasic.nuspec
@@ -7,7 +7,7 @@

      More details at https://aka.ms/roslyn-packages
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Common" version="$version$" />
    </dependencies>

--- a/src/NuGet/Microsoft.CodeAnalysis.Workspaces.Common.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.Workspaces.Common.nuspec
@@ -8,7 +8,7 @@
    <description>
      A shared package used by the .NET Compiler Platform ("Roslyn") including support for analyzing projects and solutions. Do not install this package manually, it will be added as a prerequisite by other packages that require it.

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <group targetFramework="netstandard1.3">

--- a/src/NuGet/Microsoft.CodeAnalysis.nuspec
+++ b/src/NuGet/Microsoft.CodeAnalysis.nuspec
@@ -13,7 +13,7 @@
        - "Microsoft.CodeAnalysis.CSharp" (only the C# compiler)      
        - "Microsoft.CodeAnalysis.VisualBasic (only the VB compiler)

-      This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.CSharp.Workspaces" version="[$version$]" />

--- a/src/NuGet/Microsoft.NETCore.Compilers.nuspec
+++ b/src/NuGet/Microsoft.NETCore.Compilers.nuspec
@@ -5,7 +5,7 @@
    <summary>
      CoreCLR-compatible versions of the C# and VB compilers for use in MSBuild.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <language>en-US</language>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <version>$version$</version>

--- a/src/NuGet/Microsoft.Net.CSharp.Interactive.netcore.nuspec
+++ b/src/NuGet/Microsoft.Net.CSharp.Interactive.netcore.nuspec
@@ -8,7 +8,7 @@
      Supported Platforms:
      - .NET Core (NETCoreApp1.0)
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <language>en-US</language>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <version>$version$</version>

--- a/src/NuGet/Microsoft.Net.Compilers.netcore.nuspec
+++ b/src/NuGet/Microsoft.Net.Compilers.netcore.nuspec
@@ -5,7 +5,7 @@
    <summary>
      CoreCLR-compatible versions of the C# and VB compilers.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <language>en-US</language>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <version>$version$</version>

--- a/src/NuGet/Microsoft.Net.Compilers.nuspec
+++ b/src/NuGet/Microsoft.Net.Compilers.nuspec
@@ -7,7 +7,7 @@

    This package can be used to compile code targeting any platform, but can only be run using the desktop .NET 4.6+ Full Framework.
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <language>en-US</language>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <version>$version$</version>

--- a/src/NuGet/Microsoft.VisualStudio.IntegrationTest.Utilities.nuspec
+++ b/src/NuGet/Microsoft.VisualStudio.IntegrationTest.Utilities.nuspec
@@ -3,7 +3,7 @@
  <metadata>
    <id>Microsoft.VisualStudio.IntegrationTest.Utilities</id>
    <summary>Utility methods used to run Visual Studio integration tests.</summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <language>en-US</language>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <version>$version$</version>

--- a/src/NuGet/Microsoft.VisualStudio.LanguageServices.Next.nuspec
+++ b/src/NuGet/Microsoft.VisualStudio.LanguageServices.Next.nuspec
@@ -8,7 +8,7 @@
 Supported Platforms:
 - .NET Framework 4.6
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Remote.ServiceHub" version="[$version$]" />
      <dependency id="Microsoft.CodeAnalysis.Remote.Workspaces" version="[$version$]" />

--- a/src/NuGet/Microsoft.VisualStudio.LanguageServices.Razor.RemoteClient.nuspec
+++ b/src/NuGet/Microsoft.VisualStudio.LanguageServices.Razor.RemoteClient.nuspec
@@ -9,7 +9,7 @@
      Supported Platforms:
        - .NET Framework 4.6

-        This package was built from the source at $commitUrl$
+      $commitPathMessage$
    </description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis.Workspaces.Common" version="[$version$]" />

--- a/src/NuGet/Microsoft.VisualStudio.LanguageServices.nuspec
+++ b/src/NuGet/Microsoft.VisualStudio.LanguageServices.nuspec
@@ -8,7 +8,7 @@
 Supported Platforms:
 - .NET Framework 4.6
    </summary>
-    <description>This package was built from the source at $commitUrl$</description>
+    <description>$commitPathMessage$</description>
    <dependencies>
      <dependency id="Microsoft.CodeAnalysis" version="[$version$]" />
    </dependencies>