Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
70a222a4
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
70a222a4
编写于
5月 18, 2020
作者:
C
CyrusNajmabadi
提交者:
GitHub
5月 18, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #44367 from CyrusNajmabadi/experimentCache
Cache results of IsExperimentEnabled for performance
上级
9f2acc77
cdc5afa0
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
31 addition
and
0 deletion
+31
-0
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
...Def/Experimentation/VisualStudioExperimentationService.cs
+31
-0
未找到文件。
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
浏览文件 @
70a222a4
...
...
@@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.
using
System
;
using
System.Collections.Generic
;
using
System.Composition
;
using
System.Reflection
;
using
Microsoft.CodeAnalysis.Editor.Shared.Utilities
;
...
...
@@ -21,6 +22,13 @@ internal class VisualStudioExperimentationService : ForegroundThreadAffinitizedO
private
readonly
MethodInfo
_isCachedFlightEnabledInfo
;
private
readonly
IVsFeatureFlags
_featureFlags
;
/// <summary>
/// Cache of values we've queried from the underlying VS service. These values are expected to last for the
/// lifetime of the session, so it's fine for us to cache things to avoid the heavy cost of querying for them
/// over and over.
/// </summary>
private
readonly
Dictionary
<
string
,
bool
>
_experimentEnabledMap
=
new
Dictionary
<
string
,
bool
>();
[
ImportingConstructor
]
[
Obsolete
(
MefConstruction
.
ImportingConstructorMessage
,
error
:
true
)]
public
VisualStudioExperimentationService
(
IThreadingContext
threadingContext
,
SVsServiceProvider
serviceProvider
)
...
...
@@ -53,6 +61,29 @@ public VisualStudioExperimentationService(IThreadingContext threadingContext, SV
}
public
bool
IsExperimentEnabled
(
string
experimentName
)
{
ThisCanBeCalledOnAnyThread
();
// First look in our cache to see if this has already been computed and cached.
lock
(
_experimentEnabledMap
)
{
if
(
_experimentEnabledMap
.
TryGetValue
(
experimentName
,
out
var
result
))
return
result
;
}
// Otherwise, compute and cache this ourselves. It's fine if multiple callers cause this to happen. We'll
// just let the last one win.
var
enabled
=
IsExperimentEnabledWorker
(
experimentName
);
lock
(
_experimentEnabledMap
)
{
_experimentEnabledMap
[
experimentName
]
=
enabled
;
}
return
enabled
;
}
private
bool
IsExperimentEnabledWorker
(
string
experimentName
)
{
ThisCanBeCalledOnAnyThread
();
if
(
_isCachedFlightEnabledInfo
!=
null
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录