Since we haven't made classification extensible, there's no reason to use...

Since we haven't made classification extensible, there's no reason to use ExtensionMananger. In this case, ExtensionManager only prevents us from finding our own bugs. (changeset 1214494)

Src/Workspaces/Core/Classification/AbstractClassificationService.Worker.cs

@@ -21,7 +21,6 @@ private struct Worker
             private readonly CancellationToken cancellationToken;
             private readonly Func<SyntaxNode, List<ISyntaxClassifier>> getNodeClassifiers;
             private readonly Func<SyntaxToken, List<ISyntaxClassifier>> getTokenClassifiers;
-            private readonly IExtensionManager extensionManager;
             private readonly HashSet<ClassifiedSpan> set;
             private readonly Stack<SyntaxNodeOrToken> pendingNodes;
 
@@ -34,7 +33,6 @@ private struct Worker
                 Func<SyntaxToken, List<ISyntaxClassifier>> getTokenClassifiers,
                 CancellationToken cancellationToken)
             {
-                this.extensionManager = workspace.GetExtensionManager();
                 this.getNodeClassifiers = getNodeClassifiers;
                 this.getTokenClassifiers = getTokenClassifiers;
                 this.semanticModel = semanticModel;
@@ -119,23 +117,8 @@ private void ClassifyNode(SyntaxNode syntax)
                 foreach (var classifier in getNodeClassifiers(syntax))
                 {
                     cancellationToken.ThrowIfCancellationRequested();
-
-                    try
-                    {
-                        if (!extensionManager.IsDisabled(classifier))
-                        {
-                            var classifications = classifier.ClassifyNode(syntax, this.semanticModel, cancellationToken);
-                            AddClassifications(classifications);
-                        }
-                    }
-                    catch (OperationCanceledException)
-                    {
-                        throw;
-                    }
-                    catch (Exception e)
-                    {
-                        extensionManager.HandleException(classifier, e);
-                    }
+                    var classifications = classifier.ClassifyNode(syntax, this.semanticModel, cancellationToken);
+                    AddClassifications(classifications);
                 }
             }
 
@@ -165,23 +148,8 @@ private void ClassifyToken(SyntaxToken syntax)
                 foreach (var classifier in getTokenClassifiers(syntax))
                 {
                     cancellationToken.ThrowIfCancellationRequested();
-
-                    try
-                    {
-                        if (!extensionManager.IsDisabled(classifier))
-                        {
-                            var classifications = classifier.ClassifyToken(syntax, this.semanticModel, cancellationToken);
-                            AddClassifications(classifications);
-                        }
-                    }
-                    catch (OperationCanceledException)
-                    {
-                        throw;
-                    }
-                    catch (Exception e)
-                    {
-                        extensionManager.HandleException(classifier, e);
-                    }
+                    var classifications = classifier.ClassifyToken(syntax, this.semanticModel, cancellationToken);
+                    AddClassifications(classifications);
                 }
 
                 ClassifyStructuredTrivia(syntax.TrailingTrivia);