Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
6e2b2f0a
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
6e2b2f0a
编写于
11月 07, 2016
作者:
H
Heejae Chang
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fixed race where build start event could be fired multiple times.
上级
b73c499f
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
40 addition
and
14 deletion
+40
-14
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
...mentation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
+40
-14
未找到文件。
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
浏览文件 @
6e2b2f0a
...
...
@@ -28,7 +28,8 @@ internal class ExternalErrorDiagnosticUpdateSource : IDiagnosticUpdateSource
private
readonly
SimpleTaskQueue
_taskQueue
;
private
readonly
IAsynchronousOperationListener
_listener
;
private
InprogressState
_state
=
null
;
private
readonly
object
_gate
;
private
InprogressState
_stateDoNotAccessDirectly
=
null
;
private
ImmutableArray
<
DiagnosticData
>
_lastBuiltResult
=
ImmutableArray
<
DiagnosticData
>.
Empty
;
[
ImportingConstructor
]
...
...
@@ -63,13 +64,15 @@ internal class ExternalErrorDiagnosticUpdateSource : IDiagnosticUpdateSource
_notificationService
=
_workspace
.
Services
.
GetService
<
IGlobalOperationNotificationService
>();
_gate
=
new
object
();
registrationService
.
Register
(
this
);
}
public
event
EventHandler
<
bool
>
BuildStarted
;
public
event
EventHandler
<
DiagnosticsUpdatedArgs
>
DiagnosticsUpdated
;
public
bool
IsInProgress
=>
_s
tate
!=
null
;
public
bool
IsInProgress
=>
BuildInprogressS
tate
!=
null
;
public
ImmutableArray
<
DiagnosticData
>
GetBuildErrors
()
{
...
...
@@ -78,13 +81,13 @@ public ImmutableArray<DiagnosticData> GetBuildErrors()
public
bool
SupportedDiagnosticId
(
ProjectId
projectId
,
string
id
)
{
return
_s
tate
?.
SupportedDiagnosticId
(
projectId
,
id
)
??
false
;
return
BuildInprogressS
tate
?.
SupportedDiagnosticId
(
projectId
,
id
)
??
false
;
}
public
void
ClearErrors
(
ProjectId
projectId
)
{
// capture state if it exists
var
state
=
_s
tate
;
var
state
=
BuildInprogressS
tate
;
var
asyncToken
=
_listener
.
BeginAsyncOperation
(
"ClearErrors"
);
_taskQueue
.
ScheduleTask
(()
=>
...
...
@@ -153,10 +156,10 @@ internal void OnSolutionBuild(object sender, UIContextChangedEventArgs e)
}
// get local copy of inprogress state
var
inprogressState
=
_s
tate
;
var
inprogressState
=
BuildInprogressS
tate
;
// building is done. reset the state.
Interlocked
.
CompareExchange
(
ref
_state
,
null
,
inprogressState
);
ClearInprogressState
(
);
// enqueue build/live sync in the queue.
var
asyncToken
=
_listener
.
BeginAsyncOperation
(
"OnSolutionBuild"
);
...
...
@@ -342,17 +345,42 @@ public void AddNewErrors(DocumentId documentId, DiagnosticData diagnostic)
}).
CompletesAsyncOperation
(
asyncToken
);
}
private
InprogressState
BuildInprogressState
{
get
{
lock
(
_gate
)
{
return
_stateDoNotAccessDirectly
;
}
}
}
private
void
ClearInprogressState
()
{
lock
(
_gate
)
{
_stateDoNotAccessDirectly
=
null
;
}
}
private
InprogressState
GetOrCreateInprogressState
()
{
if
(
_state
==
null
)
if
(
_state
DoNotAccessDirectly
==
null
)
{
// here, we take current snapshot of solution when the state is first created. and through out this code, we use this snapshot.
// since we have no idea what actual snapshot of solution the out of proc build has picked up, it doesn't remove the race we can have
// between build and diagnostic service, but this at least make us to consistent inside of our code.
Interlocked
.
CompareExchange
(
ref
_state
,
new
InprogressState
(
this
,
_workspace
.
CurrentSolution
),
null
);
lock
(
_gate
)
{
if
(
_stateDoNotAccessDirectly
==
null
)
{
// here, we take current snapshot of solution when the state is first created. and through out this code, we use this snapshot.
// since we have no idea what actual snapshot of solution the out of proc build has picked up, it doesn't remove the race we can have
// between build and diagnostic service, but this at least make us to consistent inside of our code.
_stateDoNotAccessDirectly
=
new
InprogressState
(
this
,
_workspace
.
CurrentSolution
);
}
}
}
return
_state
;
return
_state
DoNotAccessDirectly
;
}
private
void
RaiseDiagnosticsCreated
(
object
id
,
Solution
solution
,
ProjectId
projectId
,
DocumentId
documentId
,
ImmutableArray
<
DiagnosticData
>
items
)
...
...
@@ -400,8 +428,6 @@ public InprogressState(ExternalErrorDiagnosticUpdateSource owner, Solution solut
_solution
=
solution
;
// let people know build has started
// TODO: to be more accurate, it probably needs to be counted. but for now,
// I think the way it is doing probably enough.
_owner
.
RaiseBuildStarted
(
started
:
true
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录