Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
6c9ac78d
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
6c9ac78d
编写于
9月 08, 2020
作者:
S
Sam Harwell
提交者:
GitHub
9月 08, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #47372 from Youssef1313/parenthesis-bug
Fix IsSafeToChangeAssociativity for dynamic variables
上级
3505bcd6
e8f51f97
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
23 addition
and
1 deletion
+23
-1
src/Analyzers/CSharp/Tests/RemoveUnnecessaryParentheses/RemoveUnnecessaryExpressionParenthesesTests.cs
...arentheses/RemoveUnnecessaryExpressionParenthesesTests.cs
+17
-1
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ParenthesizedExpressionSyntaxExtensions.cs
...ore/Extensions/ParenthesizedExpressionSyntaxExtensions.cs
+6
-0
未找到文件。
src/Analyzers/CSharp/Tests/RemoveUnnecessaryParentheses/RemoveUnnecessaryExpressionParenthesesTests.cs
浏览文件 @
6c9ac78d
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
...
...
@@ -95,6 +95,22 @@ void M()
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryParentheses
)]
[
WorkItem
(
47365
,
"https://github.com/dotnet/roslyn/issues/47365"
)]
public
async
Task
TestDynamic
()
{
await
TestMissingAsync
(
@"class C
{
void M()
{
dynamic i = 1;
dynamic s = ""s"";
Console.WriteLine(s + $$(1 + i));
}
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryParentheses
)]
public
async
Task
TestArithmeticRequiredForClarity2
()
{
...
...
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ParenthesizedExpressionSyntaxExtensions.cs
浏览文件 @
6c9ac78d
...
...
@@ -40,6 +40,12 @@ internal static class CommonParenthesizedExpressionSyntaxExtensions
}
}
// It's not safe to change associativity for dynamic variables as the actual type isn't known. See https://github.com/dotnet/roslyn/issues/47365
if
(
innerTypeInfo
.
Type
is
IDynamicTypeSymbol
)
{
return
false
;
}
// Only allow us to change associativity if all the types are the same.
// for example, if we have: int + (int + long) then we don't want to
// change things such that we effectively have (int + int) + long
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录