提交 6b3bd104 编写于 作者: D Dustin Campbell

Apply CR feedback to rename log file and convert method to property

上级 817002ae
......@@ -67,7 +67,7 @@ public ProjectBuildManager(ImmutableDictionary<string, string> additionalGlobalP
_additionalGlobalProperties = additionalGlobalProperties ?? ImmutableDictionary<string, string>.Empty;
}
private ImmutableDictionary<string, string> AllGlobalProperties()
private ImmutableDictionary<string, string> AllGlobalProperties
=> s_defaultGlobalProperties.AddRange(_additionalGlobalProperties);
private static async Task<(MSB.Evaluation.Project project, DiagnosticLog log)> LoadProjectAsync(
......@@ -116,7 +116,7 @@ public ProjectBuildManager(ImmutableDictionary<string, string> additionalGlobalP
}
else
{
var projectCollection = new MSB.Evaluation.ProjectCollection(AllGlobalProperties());
var projectCollection = new MSB.Evaluation.ProjectCollection(AllGlobalProperties);
try
{
return LoadProjectAsync(path, projectCollection, cancellationToken);
......
......@@ -48,7 +48,7 @@ private void DotNetRestore(string solutionOrProjectFileName)
private void DotNetBuild(string solutionOrProjectFileName, string configuration = null)
{
var arguments = $@"msbuild ""{solutionOrProjectFileName}"" /bl:{Path.Combine(SolutionDirectory.Path, "restore.binlog")}";
var arguments = $@"msbuild ""{solutionOrProjectFileName}"" /bl:{Path.Combine(SolutionDirectory.Path, "build.binlog")}";
if (configuration != null)
{
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册