Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
6acd1644
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
6acd1644
编写于
2月 09, 2016
作者:
A
AlekseyTs
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Verify that bound node has ConstantValue even when underlying symbol has one.
Fixed #8475.
上级
a962c9cd
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
30 addition
and
4 deletion
+30
-4
src/Compilers/VisualBasic/Portable/Semantics/Conversions.vb
src/Compilers/VisualBasic/Portable/Semantics/Conversions.vb
+7
-4
src/Compilers/VisualBasic/Test/Semantic/Semantics/Conversions.vb
...pilers/VisualBasic/Test/Semantic/Semantics/Conversions.vb
+23
-0
未找到文件。
src/Compilers/VisualBasic/Portable/Semantics/Conversions.vb
浏览文件 @
6acd1644
...
...
@@ -916,13 +916,16 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
userDefinedConversionsMightStillBeApplicable
=
False
Dim
conv
As
ConversionKind
' Using <symbol>.IsConstant() for field accesses can result in an infinite loop.
' To detect such a loop pass the already visited constants from the binder.
' Using source.IsConstant for field accesses can result in an infinite loop.
' To resolve the cycle, first call GetConstantValue with the already visited constants from the binder.
' The check for source.IsConstant is still necessary because the node might still
' be considered as a non-constant in some error conditions (a reference before declaration,
' for example).
Dim
sourceIsConstant
As
Boolean
=
False
If
source
.
Kind
=
BoundKind
.
FieldAccess
Then
sourceIsConstant
=
DirectCast
(
source
,
BoundFieldAccess
).
FieldSymbol
.
GetConstantValue
(
binder
.
ConstantFieldsInProgress
)
IsNot
Nothing
sourceIsConstant
=
DirectCast
(
source
,
BoundFieldAccess
).
FieldSymbol
.
GetConstantValue
(
binder
.
ConstantFieldsInProgress
)
IsNot
Nothing
AndAlso
source
.
IsConstant
ElseIf
source
.
Kind
=
BoundKind
.
Local
Then
sourceIsConstant
=
DirectCast
(
source
,
BoundLocal
).
LocalSymbol
.
GetConstantValue
(
binder
)
IsNot
Nothing
sourceIsConstant
=
DirectCast
(
source
,
BoundLocal
).
LocalSymbol
.
GetConstantValue
(
binder
)
IsNot
Nothing
AndAlso
source
.
IsConstant
Else
sourceIsConstant
=
source
.
IsConstant
End
If
...
...
src/Compilers/VisualBasic/Test/Semantic/Semantics/Conversions.vb
浏览文件 @
6acd1644
...
...
@@ -4727,5 +4727,28 @@ Expected - 2
CompileAndVerify
(
compilation
,
expectedOutput
:
=
expectedOutput
).
VerifyDiagnostics
()
End
Sub
<
WorkItem
(
8475
,
"https://github.com/dotnet/roslyn/issues/8475"
)
>
<
Fact
()
>
Public
Sub
ConvertConstantBeforeItsDeclaration
()
Dim
compilation
=
CreateCompilationWithMscorlibAndVBRuntime
(
<
compilation
>
<
file
name
=
"a.vb"
><
!
[
CDATA
[
Class
Program
Shared
Sub
Main
()
Dim
x
as
Integer
=
STR
Const
STR
As
String
=
""
End
Sub
End
Class
]]
></
file
>
</
compilation
>
,
options
:
=
TestOptions
.
ReleaseExe
)
compilation
.
AssertTheseDiagnostics
(
<
expected
>
BC32000
:
Local
variable
'STR' cannot be referred to before it is declared.
Dim
x
as
Integer
=
STR
~~~
</
expected
>
)
End
Sub
End
Class
End
Namespace
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录