Enable tests skipped due to a Mono bug in AssemblyName.CultureName

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenScriptTests.cs

@@ -213,7 +213,7 @@ class CLS
                 Diagnostic(ErrorCode.ERR_AnonymousTypeNotAvailable, "new"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CompilationChain_AnonymousTypeTemplates()
         {
             var s0 = CreateSubmission("var x = new { a = 1 }; ");
@@ -236,7 +236,7 @@ public void CompilationChain_AnonymousTypeTemplates()
             Assert.False(sx.AnonymousTypeManager.AreTemplatesSealed);
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CompilationChain_DynamicSiteDelegates()
         {
             // TODO: references should be inherited
@@ -260,7 +260,7 @@ public void CompilationChain_DynamicSiteDelegates()
             Assert.False(sx.AnonymousTypeManager.AreTemplatesSealed);
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void Submissions_EmitToPeStream()
         {
             var s0 = CreateSubmission("int a = 1;");
@@ -271,7 +271,7 @@ public void Submissions_EmitToPeStream()
             s12.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CrossSubmissionGenericInterfaceImplementation_Generic()
         {
             var c0 = CreateSubmission(@"
@@ -293,7 +293,7 @@ public void m<TT>(int x, TT y)
             c1.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CrossSubmissionGenericInterfaceImplementation_Explicit_GenericMethod()
         {
             var c0 = CreateSubmission(@"
@@ -315,7 +315,7 @@ void I<int>.m<S>(int x, S y)
             c1.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CrossSubmissionGenericInterfaceImplementation_Explicit()
         {
             var c0 = CreateSubmission(@"
@@ -337,7 +337,7 @@ void I<int>.m(int x)
             c1.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CrossSubmissionGenericInterfaceImplementation_Explicit_NoGenericParametersInSignature()
         {
             var c0 = CreateSubmission(@"
@@ -359,7 +359,7 @@ void I<int>.m(byte x)
             c1.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void GenericInterfaceImplementation_Explicit_NoGenericParametersInSignature()
         {
             var c0 = CreateSubmission(@"
@@ -376,7 +376,7 @@ void I<int>.m(byte x)
             c0.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CrossSubmissionInterfaceImplementation_Explicit_NoGenericParametersInSignature()
         {
             var c0 = CreateSubmission(@"
@@ -398,7 +398,7 @@ void I.m(byte x)
             c1.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CrossSubmissionNestedGenericInterfaceImplementation_Explicit()
         {
             var c0 = CreateSubmission(@"
@@ -423,7 +423,7 @@ void C<int>.I.m(int x)
             c1.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void NestedGenericInterfaceImplementation_Explicit()
         {
             var c0 = CreateSubmission(@"
@@ -443,7 +443,7 @@ void C<int>.I.m(int x)
             c0.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ExternalInterfaceImplementation_Explicit()
         {
             var c0 = CreateSubmission(@"
@@ -465,7 +465,7 @@ IEnumerator IEnumerable.GetEnumerator()
             c0.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void AbstractAccessors()
         {
             var c0 = CreateSubmission(@"
@@ -478,7 +478,7 @@ public abstract class C
             c0.VerifyEmitDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ExprStmtWithMethodCall()
         {
             var s0 = CreateSubmission("int Foo() { return 2;}");

src/Compilers/CSharp/Test/Semantic/Semantics/ScriptSemanticsTests.cs

@@ -83,7 +83,7 @@ public void MainInScript1()
                 Diagnostic(ErrorCode.WRN_MainIgnored, "Main").WithArguments("Main()"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void NoReferences()
         {
             var submission = CSharpCompilation.CreateSubmission("test", syntaxTree: SyntaxFactory.ParseSyntaxTree("1", options: TestOptions.Interactive), returnType: typeof(int));
@@ -104,7 +104,7 @@ public void NoReferences()
                 Diagnostic(ErrorCode.ERR_PredefinedTypeNotFound).WithArguments("System.Object").WithLocation(1, 1));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void Namespaces()
         {
             var c = CreateSubmission(@"
@@ -292,7 +292,7 @@ public void UsingStaticClass()
         }
 
         [WorkItem(3817, "https://github.com/dotnet/roslyn/issues/3817")]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void LabelLookup()
         {
             var source = "using System; 1";
@@ -302,7 +302,7 @@ public void LabelLookup()
         }
 
         [WorkItem(543890)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ThisIndexerAccessInSubmission()
         {
             string test = @"
@@ -335,7 +335,7 @@ public void ThisIndexerAccessInSubmission()
         /// </summary>
         [WorkItem(530986)]
         [WorkItem(1010871)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void LookupSymbols()
         {
             var text = "1 + ";
@@ -365,7 +365,7 @@ public void LookupSymbols()
             Assert.False(symbols.Any(s => s.Name == "Roslyn"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void HostObjectBinding_Diagnostics()
         {
             var submission = CreateSubmission("x",
@@ -413,7 +413,7 @@ public void DelegateAddition()
         }
 
         [WorkItem(870885)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void Bug870885()
         {
             var source = @"var o = o.F;";
@@ -426,7 +426,7 @@ public void Bug870885()
         }
 
         [WorkItem(949595)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void GlobalAttributes()
         {
             var source = @"
@@ -442,7 +442,7 @@ public void GlobalAttributes()
                 Diagnostic(ErrorCode.ERR_GlobalAttributesNotAllowed, "module"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void SealedOverride()
         {
             var source0 = @"
@@ -465,7 +465,7 @@ class Y : M
             CompileAndVerify(c1);
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void PrivateNested()
         {
             var c0 = CreateSubmission(@"public class C { private static int foo() { return 1; } }");
@@ -476,7 +476,7 @@ public void PrivateNested()
                 Diagnostic(ErrorCode.ERR_BadAccess, "foo").WithArguments("C.foo()"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void InconsistentAccessibilityChecks()
         {
             var c0 = CreateSubmission(@"
@@ -548,7 +548,7 @@ public class E { }
                 Diagnostic(ErrorCode.ERR_BadVisFieldType, "x").WithArguments("x", "B"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CompilationChain_Fields()
         {
             var c0 = CreateSubmission(@"
@@ -562,7 +562,7 @@ public void CompilationChain_Fields()
             c2.VerifyDiagnostics(Diagnostic(ErrorCode.ERR_ObjectRequired, "i").WithArguments("i"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void CompilationChain_InStaticContext()
         {
             var c0 = CreateSubmission(@"
@@ -585,7 +585,7 @@ public void CompilationChain_InStaticContext()
                 Diagnostic(ErrorCode.ERR_ObjectRequired, "z").WithArguments("z()"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void AccessToGlobalMemberFromNestedClass1()
         {
             var c0 = CreateSubmission(@"
@@ -602,7 +602,7 @@ class D
                 Diagnostic(ErrorCode.ERR_ObjectRequired, "foo").WithArguments("foo()"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void AccessToGlobalMemberFromNestedClass2()
         {
             var c0 = CreateSubmission(@"
@@ -623,7 +623,7 @@ class D
         /// <summary>
         /// Previous submission has to have no errors.
         /// </summary>
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void Submissions_ExecutionOrder3()
         {
             var s0 = CreateSubmission("int a = \"x\";");
@@ -635,7 +635,7 @@ public void Submissions_ExecutionOrder3()
         }
 
         [WorkItem(3795, "https://github.com/dotnet/roslyn/issues/3795")]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ErrorInUsing()
         {
             var submission = CreateSubmission("using Unknown;");
@@ -650,7 +650,7 @@ public void ErrorInUsing()
                 Diagnostic(ErrorCode.ERR_SingleTypeNameNotFound, "Unknown").WithArguments("Unknown"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void HostObjectBinding_MissingHostObjectContext()
         {
             var c = CreateSubmission("Z()", new[] { HostRef });
@@ -660,7 +660,7 @@ public void HostObjectBinding_MissingHostObjectContext()
                 Diagnostic(ErrorCode.ERR_NameNotInContext, "Z").WithArguments("Z"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void HostObjectBinding_InStaticContext()
         {
             var source = @"
@@ -684,7 +684,7 @@ public void HostObjectBinding_InStaticContext()
                 Diagnostic(ErrorCode.ERR_ObjectRequired, "Z").WithArguments(typeName + ".C.Z()"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void WRN_LowercaseEllSuffix()
         {
             var c = CreateSubmission("int i = 42l;");
@@ -696,7 +696,7 @@ public void WRN_LowercaseEllSuffix()
                 Diagnostic(ErrorCode.ERR_NoImplicitConvCast, "42l").WithArguments("long", "int"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ERR_RecursivelyTypedVariable()
         {
             var c = CreateSubmission("var x = x;");
@@ -706,7 +706,7 @@ public void ERR_RecursivelyTypedVariable()
                 Diagnostic(ErrorCode.ERR_RecursivelyTypedVariable, "x").WithArguments("x"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ERR_VariableUsedBeforeDeclaration()
         {
             var c = CreateSubmission("var x = 1; { var x = x;}");
@@ -716,7 +716,7 @@ public void ERR_VariableUsedBeforeDeclaration()
                 Diagnostic(ErrorCode.ERR_VariableUsedBeforeDeclaration, "x").WithArguments("x"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ERR_ReturnNotAllowedInScript()
         {
             var c1 = CreateSubmission("return;");
@@ -732,7 +732,7 @@ public void ERR_ReturnNotAllowedInScript()
                 Diagnostic(ErrorCode.ERR_ReturnNotAllowedInScript, "return"));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ERR_FieldCantBeRefAny()
         {
             var c = CreateSubmission(@"
@@ -750,7 +750,7 @@ public void ERR_FieldCantBeRefAny()
         }
 
         [WorkItem(529387)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void IsVariable_PreviousSubmission()
         {
             var c0 = CreateSubmission("var x = 1;");
@@ -762,7 +762,7 @@ public void IsVariable_PreviousSubmission()
                 Diagnostic(ErrorCode.ERR_FixedNeeded, "&x").WithLocation(1, 1));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void IsVariable_HostObject()
         {
             var c0 = CreateSubmission("&x", new[] { HostRef }, hostObjectType: typeof(B2));
@@ -774,7 +774,7 @@ public void IsVariable_HostObject()
         }
 
         [WorkItem(530404)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void DiagnosticsPass()
         {
             var source = "(System.Linq.Expressions.Expression<System.Func<object>>)(() => null ?? new object())";
@@ -787,7 +787,7 @@ public void DiagnosticsPass()
         }
 
         [WorkItem(527850)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ArithmeticOperators_MultiplicationExpression()
         {
             var s0 = CreateSubmission("int i = 5;");
@@ -804,7 +804,7 @@ public void ArithmeticOperators_MultiplicationExpression()
         [WorkItem(527850)]
         [WorkItem(522569)]
         [WorkItem(4737)]
-        [ClrOnlyFact(ClrOnlyReason.Submission, Skip = "4737")]
+        [Fact(Skip = "4737")]
         public void TopLevelLabel()
         {
             var s0 = CreateSubmission(@"
@@ -815,7 +815,7 @@ public void TopLevelLabel()
         }
 
         [WorkItem(541210)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void TopLevelGoto()
         {
             var s0 = CreateSubmission("goto Object;");
@@ -826,7 +826,7 @@ public void TopLevelGoto()
         }
 
         [WorkItem(541166)]
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void DefineExtensionMethods()
         {
             var references = new[] { TestReferences.NetFx.v4_0_30319.System_Core };

src/Compilers/CSharp/Test/Symbol/Compilation/CompilationAPITests.cs

@@ -1383,7 +1383,7 @@ class A
                 Diagnostic(ErrorCode.WRN_MainIgnored, "Main").WithArguments("A.Main()").WithLocation(4, 17));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void GetEntryPoint_Submission()
         {
             var source = @"1 + 1";
@@ -1402,7 +1402,7 @@ public void GetEntryPoint_Submission()
             entryPoint.Diagnostics.Verify();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void GetEntryPoint_Submission_MainIgnored()
         {
             var source = @"
@@ -1926,7 +1926,7 @@ public void ConsistentParseOptions()
             });
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void SubmissionCompilation_Errors()
         {
             var genericParameter = typeof(List<>).GetGenericArguments()[0];
@@ -1969,7 +1969,7 @@ private static void TestSubmissionResult(CSharpCompilation s, SpecialType? expec
             Assert.Equal(expectedHasValue, hasValue);
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void SubmissionResultType()
         {
             var submission = CSharpCompilation.CreateSubmission("sub");
@@ -1992,7 +1992,7 @@ public void SubmissionResultType()
         /// <summary>
         /// Previous submission has to have no errors.
         /// </summary>
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void PreviousSubmissionWithError()
         {
             var s0 = CreateSubmission("int a = \"x\";");

src/Compilers/CSharp/Test/Symbol/Compilation/GetUnusedImportDirectivesTests.cs

@@ -359,7 +359,7 @@ public void InfoAndWarnAsError()
                 Diagnostic(ErrorCode.HDN_UnusedUsingDirective, "using System;").WithWarningAsError(false));
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void UnusedUsingInteractive()
         {
             var tree = Parse("using System;", options: TestOptions.Interactive);

src/Compilers/CSharp/Test/Symbol/Symbols/ExtensionMethodTests.cs

@@ -3685,7 +3685,7 @@ class C
             compilation.VerifyDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void InteractiveExtensionMethods()
         {
             var parseOptions = TestOptions.Interactive;

src/Compilers/CSharp/Test/Symbol/Symbols/Source/ExternAliasTests.cs

@@ -98,7 +98,7 @@ public void ExternAliasInScript()
             comp.VerifyDiagnostics();
         }
 
-        [ClrOnlyFact(ClrOnlyReason.Submission)]
+        [Fact]
         public void ExternAliasInInteractive_Error()
         {
             var src = "extern alias Bar;";

src/Compilers/VisualBasic/Test/Semantic/Compilation/CompilationAPITests.vb

@@ -1720,7 +1720,7 @@ End Namespace
             Assert.Throws(Of ArgumentException)(Function() VisualBasicCompilation.Create(assemblyName, {tree1, tree3}, {MscorlibRef}, CompilationOptions))
         End Sub
 
-        <ClrOnlyFact(ClrOnlyReason.Submission)>
+        <Fact>
         Public Sub SubmissionCompilation_Errors()
             Dim genericParameter = GetType(List(Of)).GetGenericArguments()(0)
             Dim open = GetType(Dictionary(Of,)).MakeGenericType(GetType(Integer), genericParameter)
@@ -1753,7 +1753,7 @@ End Namespace
             Assert.Throws(Of ArgumentException)(Function() VisualBasicCompilation.CreateSubmission("a", options:=TestOptions.ReleaseDll.WithDelaySign(False)))
         End Sub
 
-        <ClrOnlyFact(ClrOnlyReason.Submission)>
+        <Fact>
         Public Sub SubmissionResultType()
             Dim submission = VisualBasicCompilation.CreateSubmission("sub")
             Dim hasValue As Boolean
@@ -1803,7 +1803,7 @@ End Sub
         ''' <summary>
         ''' Previous submission has to have no errors.
         ''' </summary>
-        <ClrOnlyFact(ClrOnlyReason.Submission)>
+        <Fact>
         Public Sub PreviousSubmissionWithError()
             Dim s0 = CreateSubmission("Dim a As X = 1")
 

src/Compilers/VisualBasic/Test/Semantic/Semantics/GetUnusedImportDirectivesTests.vb

@@ -301,7 +301,7 @@ Imports System
             CreateCompilationWithMscorlib(source, parseOptions:=New VisualBasicParseOptions(documentationMode:=DocumentationMode.Diagnose)).AssertTheseDiagnostics(<errors></errors>, suppressInfos:=False)
         End Sub
 
-        <ClrOnlyFact(ClrOnlyReason.Submission)>
+        <Fact>
         Public Sub UnusedImportInteractive()
             Dim tree = Parse("Imports System", options:=TestOptions.Interactive)
             Dim compilation = VisualBasicCompilation.CreateSubmission("sub1", tree, {MscorlibRef_v4_0_30316_17626})

src/Test/Utilities/Desktop/ConditionalFactAttribute.cs

@@ -35,9 +35,6 @@ public enum ClrOnlyReason
 
         // Can't sign. 
         Signing,
-
-        // Can't find System.Object when compiling a submission (not understood).
-        Submission,
     }
 
     public class ClrOnlyFact : FactAttribute