Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
611578d7
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
611578d7
编写于
6月 07, 2019
作者:
S
Sam Harwell
提交者:
GitHub
6月 07, 2019
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #36161 from sharwell/updaterefs-no-capture
Avoid in-process captures in UpdateReferencesAync
上级
0b8e89e9
2ec12e3b
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
13 addition
and
6 deletion
+13
-6
src/Features/Core/Portable/IncrementalCaches/SymbolTreeInfoIncrementalAnalyzerProvider.cs
...mentalCaches/SymbolTreeInfoIncrementalAnalyzerProvider.cs
+13
-6
未找到文件。
src/Features/Core/Portable/IncrementalCaches/SymbolTreeInfoIncrementalAnalyzerProvider.cs
浏览文件 @
611578d7
...
...
@@ -205,8 +205,8 @@ private async Task UpdateSymbolTreeInfoAsync(Project project, CancellationToken
// Produce the indices for the source and metadata symbols in parallel.
var
tasks
=
new
List
<
Task
>
{
GetTask
(
project
,
(
)
=>
UpdateSourceSymbolTreeInfoAsync
(
project
,
cancellationToken
)
,
cancellationToken
),
GetTask
(
project
,
(
)
=>
UpdateReferencesAync
(
project
,
cancellationToken
)
,
cancellationToken
)
GetTask
(
project
,
(
self
,
project
,
_
,
cancellationToken
)
=>
self
.
UpdateSourceSymbolTreeInfoAsync
(
project
,
cancellationToken
),
null
,
cancellationToken
),
GetTask
(
project
,
(
self
,
project
,
_
,
cancellationToken
)
=>
self
.
UpdateReferencesAync
(
project
,
cancellationToken
),
null
,
cancellationToken
)
};
await
Task
.
WhenAll
(
tasks
).
ConfigureAwait
(
false
);
...
...
@@ -230,14 +230,21 @@ private async Task UpdateSourceSymbolTreeInfoAsync(Project project, Cancellation
}
}
private
Task
GetTask
(
Project
project
,
Func
<
Task
>
func
,
CancellationToken
cancellationToken
)
[
PerformanceSensitive
(
"https://github.com/dotnet/roslyn/issues/36158"
,
AllowCaptures
=
false
,
Constraint
=
"Avoid captures to reduce GC pressure when running in the host workspace."
)]
private
Task
GetTask
(
Project
project
,
Func
<
IncrementalAnalyzer
,
Project
,
PortableExecutableReference
,
CancellationToken
,
Task
>
func
,
PortableExecutableReference
reference
,
CancellationToken
cancellationToken
)
{
var
isRemoteWorkspace
=
project
.
Solution
.
Workspace
.
Kind
==
WorkspaceKind
.
RemoteWorkspace
;
return
isRemoteWorkspace
?
Task
.
Run
(
func
,
cancellationToken
)
:
func
();
?
GetNewTask
(
this
,
func
,
project
,
reference
,
cancellationToken
)
:
func
(
this
,
project
,
reference
,
cancellationToken
);
static
Task
GetNewTask
(
IncrementalAnalyzer
self
,
Func
<
IncrementalAnalyzer
,
Project
,
PortableExecutableReference
,
CancellationToken
,
Task
>
func
,
Project
project
,
PortableExecutableReference
reference
,
CancellationToken
cancellationToken
)
{
return
Task
.
Run
(()
=>
func
(
self
,
project
,
reference
,
cancellationToken
),
cancellationToken
);
}
}
[
PerformanceSensitive
(
"https://github.com/dotnet/roslyn/issues/36158"
,
AllowCaptures
=
false
)]
private
Task
UpdateReferencesAync
(
Project
project
,
CancellationToken
cancellationToken
)
{
// Process all metadata references. If it remote workspace, do this in parallel.
...
...
@@ -246,7 +253,7 @@ private Task UpdateReferencesAync(Project project, CancellationToken cancellatio
foreach
(
var
reference
in
project
.
MetadataReferences
.
OfType
<
PortableExecutableReference
>())
{
tasks
.
Add
(
GetTask
(
project
,
(
)
=>
UpdateReferenceAsync
(
project
,
reference
,
cancellationToken
)
,
cancellationToken
));
GetTask
(
project
,
(
self
,
project
,
reference
,
cancellationToken
)
=>
self
.
UpdateReferenceAsync
(
project
,
reference
,
cancellationToken
),
reference
,
cancellationToken
));
}
return
Task
.
WhenAll
(
tasks
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录