提交 604006fd 编写于 作者: G Gen Lu

Simplify test parameter

上级 ad40bde0
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
using Microsoft.CodeAnalysis.Options; using Microsoft.CodeAnalysis.Options;
using Microsoft.CodeAnalysis.Test.Utilities; using Microsoft.CodeAnalysis.Test.Utilities;
using Roslyn.Test.Utilities; using Roslyn.Test.Utilities;
using Roslyn.Utilities;
using Xunit; using Xunit;
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Completion.CompletionProviders namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Completion.CompletionProviders
...@@ -1771,11 +1772,11 @@ public static void Bar(this Goo goo, int x) ...@@ -1771,11 +1772,11 @@ public static void Bar(this Goo goo, int x)
inlineDescription: "Foo"); inlineDescription: "Foo");
} }
[InlineData(ReferenceType.Project, true)] [InlineData(ReferenceType.Project)]
[InlineData(ReferenceType.Metadata, false)] [InlineData(ReferenceType.Metadata)]
[Theory, Trait(Traits.Feature, Traits.Features.Completion)] [Theory, Trait(Traits.Feature, Traits.Features.Completion)]
[WorkItem(47551, "https://github.com/dotnet/roslyn/issues/47551")] [WorkItem(47551, "https://github.com/dotnet/roslyn/issues/47551")]
public async Task TestBrowsableNever(ReferenceType refType, bool shouldContainItem) public async Task TestBrowsableNever(ReferenceType refType)
{ {
var srcDoc = @" var srcDoc = @"
class Program class Program
...@@ -1802,11 +1803,11 @@ public static void Bar(this Goo goo, int x) ...@@ -1802,11 +1803,11 @@ public static void Bar(this Goo goo, int x)
} }
}"; }";
var markup = refType switch var (markup, shouldContainItem) = refType switch
{ {
ReferenceType.Project => CreateMarkupForProjectWithProjectReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), ReferenceType.Project => (CreateMarkupForProjectWithProjectReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), true),
ReferenceType.Metadata => CreateMarkupForProjectWithMetadataReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), ReferenceType.Metadata => (CreateMarkupForProjectWithMetadataReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), false),
_ => null, _ => throw ExceptionUtilities.Unreachable,
}; };
if (shouldContainItem) if (shouldContainItem)
...@@ -1826,13 +1827,13 @@ public static void Bar(this Goo goo, int x) ...@@ -1826,13 +1827,13 @@ public static void Bar(this Goo goo, int x)
} }
} }
[InlineData(ReferenceType.Project, true, true)] [InlineData(ReferenceType.Project, true)]
[InlineData(ReferenceType.Project, false, true)] [InlineData(ReferenceType.Project, false)]
[InlineData(ReferenceType.Metadata, true, false)] [InlineData(ReferenceType.Metadata, true)]
[InlineData(ReferenceType.Metadata, false, true)] [InlineData(ReferenceType.Metadata, false)]
[Theory, Trait(Traits.Feature, Traits.Features.Completion)] [Theory, Trait(Traits.Feature, Traits.Features.Completion)]
[WorkItem(47551, "https://github.com/dotnet/roslyn/issues/47551")] [WorkItem(47551, "https://github.com/dotnet/roslyn/issues/47551")]
public async Task TestBrowsableAdvanced(ReferenceType refType, bool hideAdvanced, bool shouldContainItem) public async Task TestBrowsableAdvanced(ReferenceType refType, bool hideAdvanced)
{ {
HideAdvancedMembers = hideAdvanced; HideAdvancedMembers = hideAdvanced;
...@@ -1861,11 +1862,12 @@ public static void Bar(this Goo goo, int x) ...@@ -1861,11 +1862,12 @@ public static void Bar(this Goo goo, int x)
} }
}"; }";
var markup = refType switch var (markup, shouldContainItem) = (refType, hideAdvanced) switch
{ {
ReferenceType.Project => CreateMarkupForProjectWithProjectReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), (ReferenceType.Project, _) => (CreateMarkupForProjectWithProjectReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), true),
ReferenceType.Metadata => CreateMarkupForProjectWithMetadataReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), (ReferenceType.Metadata, true) => (CreateMarkupForProjectWithMetadataReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), false),
_ => null, (ReferenceType.Metadata, false) => (CreateMarkupForProjectWithMetadataReference(srcDoc, refDoc, LanguageNames.CSharp, LanguageNames.CSharp), true),
_ => throw ExceptionUtilities.Unreachable,
}; };
if (shouldContainItem) if (shouldContainItem)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册