Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
5feb22ec
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
5feb22ec
编写于
10月 10, 2019
作者:
A
Allison Chou
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Covered more cases and added a test
上级
588ba577
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
24 addition
and
4 deletion
+24
-4
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
...SharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
+19
-0
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
...erAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
+5
-4
未找到文件。
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
浏览文件 @
5feb22ec
...
...
@@ -840,6 +840,25 @@ void Method2(Func<object> LocalFunction)
CodeStyleOptions
.
QualifyMethodAccess
);
}
[
WorkItem
(
38043
,
"https://github.com/dotnet/roslyn/issues/38043"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsQualifyMemberAccess
)]
public
async
Task
QualifyLocalMethodAccess_NotSuggestedInCollectionInitializer
()
{
await
TestMissingAsyncWithOption
(
@"using System;
using System.Collections.Generic;
class C
{
void Method()
{
object LocalFunction() => new object();
var dict = new Dictionary<Func<object>, int>() { { [|LocalFunction|], 1 } };
}
}"
,
CodeStyleOptions
.
QualifyMethodAccess
);
}
[
WorkItem
(
7065
,
"https://github.com/dotnet/roslyn/issues/7065"
)]
[
Fact
(
Skip
=
"https://github.com/dotnet/roslyn/issues/7587"
),
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsQualifyMemberAccess
)]
public
async
Task
QualifyEventAccess_EventSubscription
()
...
...
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
浏览文件 @
5feb22ec
...
...
@@ -108,7 +108,7 @@ private void AnalyzeOperation(OperationAnalysisContext context, IOperation opera
// if we can't find a member then we can't do anything. Also, we shouldn't qualify
// accesses to static members.
if
(
Is
StaticMemberOrTargetMethod
(
operation
))
if
(
Is
MemberOrTargetMethodStaticOrLocalFunction
(
operation
))
{
return
;
}
...
...
@@ -147,15 +147,16 @@ private void AnalyzeOperation(OperationAnalysisContext context, IOperation opera
}
}
private
bool
Is
StaticMemberOrTargetMethod
(
IOperation
operation
)
private
bool
Is
MemberOrTargetMethodStaticOrLocalFunction
(
IOperation
operation
)
{
switch
(
operation
)
{
case
IMemberReferenceOperation
memberReferenceOperation
:
return
memberReferenceOperation
.
Member
==
null
||
memberReferenceOperation
.
Member
.
IsStatic
||
memberReferenceOperation
.
Member
is
IMethodSymbol
me
thod
&&
m
ethod
.
MethodKind
==
MethodKind
.
LocalFunction
;
memberReferenceOperation
.
Member
is
IMethodSymbol
me
mberMethod
&&
memberM
ethod
.
MethodKind
==
MethodKind
.
LocalFunction
;
case
IInvocationOperation
invocationOperation
:
return
invocationOperation
.
TargetMethod
==
null
||
invocationOperation
.
TargetMethod
.
IsStatic
;
return
invocationOperation
.
TargetMethod
==
null
||
invocationOperation
.
TargetMethod
.
IsStatic
||
invocationOperation
.
TargetMethod
is
IMethodSymbol
targetMethod
&&
targetMethod
.
MethodKind
==
MethodKind
.
LocalFunction
;
default
:
throw
ExceptionUtilities
.
UnexpectedValue
(
operation
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录