Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
5f2cfc4b
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
5f2cfc4b
编写于
3月 14, 2020
作者:
C
Cyrus Najmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Do not add 'new' when there is no conflict in implement-interface.
上级
6140b500
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
44 addition
and
18 deletion
+44
-18
src/EditorFeatures/CSharpTest/ImplementInterface/ImplementInterfaceTests.cs
.../CSharpTest/ImplementInterface/ImplementInterfaceTests.cs
+37
-0
src/Features/Core/Portable/ImplementInterface/AbstractImplementInterfaceService.CodeAction.cs
...Interface/AbstractImplementInterfaceService.CodeAction.cs
+7
-18
未找到文件。
src/EditorFeatures/CSharpTest/ImplementInterface/ImplementInterfaceTests.cs
浏览文件 @
5f2cfc4b
...
@@ -8234,5 +8234,42 @@ public int Baz([AllowNull] int bar)
...
@@ -8234,5 +8234,42 @@ public int Baz([AllowNull] int bar)
}}
}}
}}
");
}}
");
}
}
[
WorkItem
(
13427
,
"https://github.com/dotnet/roslyn/issues/13427"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsImplementInterface
)]
public
async
Task
TestDoNotAddNewWithGenericAndNonGenericMethods
()
{
await
TestWithAllCodeStyleOptionsOffAsync
(
@"class B
{
public void M<T>() { }
}
interface I
{
void M();
}
class D : B, [|I|]
{
}"
,
@"class B
{
public void M<T>() { }
}
interface I
{
void M();
}
class D : B, I
{
public void M()
{
throw new System.NotImplementedException();
}
}"
);
}
}
}
}
}
src/Features/Core/Portable/ImplementInterface/AbstractImplementInterfaceService.CodeAction.cs
浏览文件 @
5f2cfc4b
...
@@ -440,30 +440,19 @@ private ISymbol GenerateEvent(Compilation compilation, string memberName, bool g
...
@@ -440,30 +440,19 @@ private ISymbol GenerateEvent(Compilation compilation, string memberName, bool g
return
return
baseTypes
.
Any
(
ts
=>
ts
.
GetMembers
(
memberName
)
baseTypes
.
Any
(
ts
=>
ts
.
GetMembers
(
memberName
)
.
Where
(
m
=>
m
.
IsAccessibleWithin
(
State
.
ClassOrStructType
))
.
Where
(
m
=>
m
.
IsAccessibleWithin
(
State
.
ClassOrStructType
))
.
Any
(
m
=>
HasNameConflict
(
member
,
m
emberName
,
m
)));
.
Any
(
m
=>
HasNameConflict
(
member
,
m
)));
}
}
private
static
bool
HasNameConflict
(
private
static
bool
HasNameConflict
(
ISymbol
member
,
ISymbol
baseMember
)
ISymbol
member
,
string
memberName
,
ISymbol
baseMember
)
{
{
Debug
.
Assert
(
memberName
==
baseMember
.
Name
);
if
(
member
is
IMethodSymbol
method1
&&
baseMember
is
IMethodSymbol
method2
)
if
(
member
.
Kind
==
SymbolKind
.
Method
&&
baseMember
.
Kind
==
SymbolKind
.
Method
)
{
{
// A method only conflicts with another method if they have the same parameter
// A method only conflicts with another method if they have the same parameter
// signature (return type is irrelevant).
// signature (return type is irrelevant).
var
method1
=
(
IMethodSymbol
)
member
;
return
method1
.
MethodKind
==
MethodKind
.
Ordinary
&&
var
method2
=
(
IMethodSymbol
)
baseMember
;
method2
.
MethodKind
==
MethodKind
.
Ordinary
&&
method1
.
TypeParameters
.
Length
==
method2
.
TypeParameters
.
Length
&&
if
(
method1
.
MethodKind
==
MethodKind
.
Ordinary
&&
method1
.
Parameters
.
SequenceEqual
(
method2
.
Parameters
,
SymbolEquivalenceComparer
.
Instance
.
ParameterEquivalenceComparer
);
method2
.
MethodKind
==
MethodKind
.
Ordinary
&&
method1
.
TypeParameters
.
Length
==
method2
.
TypeParameters
.
Length
)
{
return
method1
.
Parameters
.
Select
(
p
=>
p
.
Type
)
.
SequenceEqual
(
method2
.
Parameters
.
Select
(
p
=>
p
.
Type
));
}
}
}
// Any non method members with the same name simple name conflict.
// Any non method members with the same name simple name conflict.
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录