提交 5d6dc0ce 编写于 作者: M Manish Vasani

Address feedback

上级 e5f9839b
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
using System.Collections.Immutable; using System.Collections.Immutable;
using Microsoft.CodeAnalysis.CodeActions; using Microsoft.CodeAnalysis.CodeActions;
using Roslyn.Utilities;
namespace Microsoft.CodeAnalysis.CodeFixes.Configuration.ConfigureSeverity namespace Microsoft.CodeAnalysis.CodeFixes.Configuration.ConfigureSeverity
{ {
......
...@@ -54,7 +54,7 @@ private static ImmutableArray<CodeFix> GetConfigurations(Project project, IEnume ...@@ -54,7 +54,7 @@ private static ImmutableArray<CodeFix> GetConfigurations(Project project, IEnume
} }
var result = ArrayBuilder<CodeFix>.GetInstance(); var result = ArrayBuilder<CodeFix>.GetInstance();
var anayzerDiagnosticsByCategory = new SortedDictionary<string, ArrayBuilder<Diagnostic>>(); var analyzerDiagnosticsByCategory = new SortedDictionary<string, ArrayBuilder<Diagnostic>>();
using var disposer = ArrayBuilder<Diagnostic>.GetInstance(out var analyzerDiagnostics); using var disposer = ArrayBuilder<Diagnostic>.GetInstance(out var analyzerDiagnostics);
foreach (var diagnostic in diagnostics) foreach (var diagnostic in diagnostics)
{ {
...@@ -74,7 +74,7 @@ private static ImmutableArray<CodeFix> GetConfigurations(Project project, IEnume ...@@ -74,7 +74,7 @@ private static ImmutableArray<CodeFix> GetConfigurations(Project project, IEnume
// Ensure diagnostic has a valid non-empty 'Category' for category based configuration. // Ensure diagnostic has a valid non-empty 'Category' for category based configuration.
if (!string.IsNullOrEmpty(diagnostic.Descriptor.Category)) if (!string.IsNullOrEmpty(diagnostic.Descriptor.Category))
{ {
var diagnosticsForCategory = anayzerDiagnosticsByCategory.GetOrAdd(diagnostic.Descriptor.Category, _ => ArrayBuilder<Diagnostic>.GetInstance()); var diagnosticsForCategory = analyzerDiagnosticsByCategory.GetOrAdd(diagnostic.Descriptor.Category, _ => ArrayBuilder<Diagnostic>.GetInstance());
diagnosticsForCategory.Add(diagnostic); diagnosticsForCategory.Add(diagnostic);
} }
...@@ -82,7 +82,7 @@ private static ImmutableArray<CodeFix> GetConfigurations(Project project, IEnume ...@@ -82,7 +82,7 @@ private static ImmutableArray<CodeFix> GetConfigurations(Project project, IEnume
} }
} }
foreach (var (category, diagnosticsWithCategory) in anayzerDiagnosticsByCategory) foreach (var (category, diagnosticsWithCategory) in analyzerDiagnosticsByCategory)
{ {
AddBulkConfigurationCodeFixes(diagnosticsWithCategory.ToImmutableAndFree(), category); AddBulkConfigurationCodeFixes(diagnosticsWithCategory.ToImmutableAndFree(), category);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册