Merge pull request #42769 from jaredpar/dedupe-logic

Remove duplicate validation logic

src/Compilers/Core/MSBuildTask/ManagedCompiler.cs

@@ -951,77 +951,6 @@ private void ConfigureDebugProperties()
             }
         }
 
-        /// <summary>
-        /// Validate parameters, log errors and warnings and return true if
-        /// Execute should proceed.
-        /// </summary>
-        protected override bool ValidateParameters()
-        {
-            return ListHasNoDuplicateItems(Resources, nameof(Resources), "LogicalName", Log) && ListHasNoDuplicateItems(Sources, nameof(Sources), Log);
-        }
-
-        /// <summary>
-        /// Returns true if the provided item list contains duplicate items, false otherwise.
-        /// </summary>
-        internal static bool ListHasNoDuplicateItems(ITaskItem[]? itemList, string parameterName, TaskLoggingHelper log)
-        {
-            return ListHasNoDuplicateItems(itemList, parameterName, disambiguatingMetadataName: null, log);
-        }
-
-        /// <summary>
-        /// Returns true if the provided item list contains duplicate items, false otherwise.
-        /// </summary>
-        /// <param name="itemList"></param>
-        /// <param name="disambiguatingMetadataName">Optional name of metadata that may legitimately disambiguate items. May be null.</param>
-        /// <param name="parameterName"></param>
-        /// <param name="log"></param>
-        private static bool ListHasNoDuplicateItems(ITaskItem[]? itemList, string parameterName, string? disambiguatingMetadataName, TaskLoggingHelper log)
-        {
-            if (itemList == null || itemList.Length == 0)
-            {
-                return true;
-            }
-
-            var alreadySeen = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
-            foreach (ITaskItem item in itemList)
-            {
-                string key;
-                string? disambiguatingMetadataValue = null;
-                if (disambiguatingMetadataName != null)
-                {
-                    disambiguatingMetadataValue = item.GetMetadata(disambiguatingMetadataName);
-                }
-
-                if (disambiguatingMetadataName == null || string.IsNullOrEmpty(disambiguatingMetadataValue))
-                {
-                    key = item.ItemSpec;
-                }
-                else
-                {
-                    key = item.ItemSpec + ":" + disambiguatingMetadataValue;
-                }
-
-                if (alreadySeen.ContainsKey(key))
-                {
-                    if (disambiguatingMetadataName == null || string.IsNullOrEmpty(disambiguatingMetadataValue))
-                    {
-                        log.LogErrorWithCodeFromResources("General_DuplicateItemsNotSupported", item.ItemSpec, parameterName);
-                    }
-                    else
-                    {
-                        log.LogErrorWithCodeFromResources("General_DuplicateItemsNotSupportedWithMetadata", item.ItemSpec, parameterName, disambiguatingMetadataValue, disambiguatingMetadataName);
-                    }
-                    return false;
-                }
-                else
-                {
-                    alreadySeen[key] = string.Empty;
-                }
-            }
-
-            return true;
-        }
-
         /// <summary>
         /// Allows tool to handle the return code.
         /// This method will only be called with non-zero exitCode.