Merge pull request #6921 from jmarolf/GenerateConstructorCrash

Fix crash in generate constructor for C#
Fixes #6920

src/EditorFeatures/CSharpTest/Diagnostics/GenerateConstructor/GenerateConstructorTests.cs

@@ -757,5 +757,13 @@ public Derived(int a, string value = null) : base(a, value)
     }
 }");
         }
+
+        [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateConstructor)]
+        public void TestGenerateWithIncorrectConstructorArguments_Crash()
+        {
+            Test(
+@"using System ; using System . Collections . Generic ; using System . Linq ; using System . Threading . Tasks ; abstract class Y { class X : Y { void M ( ) { new X ( new [|string|] ( ) ) ; } } } ",
+@"using System ; using System . Collections . Generic ; using System . Linq ; using System . Threading . Tasks ; abstract class Y { class X : Y { private string v ; public X ( string v ) { this . v = v ; } void M ( ) { new X ( new string ( ) ) ; } } } ");
+        }
     }
 }

src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs

@@ -57,7 +57,7 @@ private static bool ParameterTypesMatch(SemanticDocument document, IList<ITypeSy
                 return false;
             }
 
-            if (parameterTypes.Count < method.Parameters.Length)
+            if (parameterTypes.Count != method.Parameters.Length)
             {
                 return false;
             }