提交 542be342 编写于 作者: C Cyrus Najmabadi

Fix override completion inside records.

上级 c9bd086b
...@@ -3042,5 +3042,25 @@ public override bool Bar(Baz baz) ...@@ -3042,5 +3042,25 @@ public override bool Bar(Baz baz)
await VerifyCustomCommitProviderAsync(markupBeforeCommit, "Bar(NS2.Baz baz)", expectedCodeAfterCommit); await VerifyCustomCommitProviderAsync(markupBeforeCommit, "Bar(NS2.Baz baz)", expectedCodeAfterCommit);
} }
[WpfFact, Trait(Traits.Feature, Traits.Features.Completion)]
public async Task OverrideInRecordWithoutExplicitOverriddenMember()
{
await VerifyItemExistsAsync(@"record Program
{
override $$
}", "ToString()");
}
[WpfFact, Trait(Traits.Feature, Traits.Features.Completion)]
public async Task OverrideInRecordWithExplicitOverriddenMember()
{
await VerifyItemIsAbsentAsync(@"record Program
{
public override string ToString() => "";
override $$
}", "ToString()");
}
} }
} }
...@@ -584,10 +584,11 @@ private static bool IsOverridable(ISymbol member, INamedTypeSymbol containingTyp ...@@ -584,10 +584,11 @@ private static bool IsOverridable(ISymbol member, INamedTypeSymbol containingTyp
{ {
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
var overriddenMember = member.OverriddenMember(); if (!member.IsImplicitlyDeclared)
if (overriddenMember != null)
{ {
result.Remove(overriddenMember); var overriddenMember = member.OverriddenMember();
if (overriddenMember != null)
result.Remove(overriddenMember);
} }
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册