Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
50471703
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
50471703
编写于
2月 21, 2018
作者:
M
Martin Strecker
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Added code comment. Moved some functions to have a better github diff.
上级
2017cfb1
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
51 addition
and
46 deletion
+51
-46
src/Features/Core/Portable/AddParameter/AbstractAddParameterCodeFixProvider.cs
...table/AddParameter/AbstractAddParameterCodeFixProvider.cs
+51
-46
未找到文件。
src/Features/Core/Portable/AddParameter/AbstractAddParameterCodeFixProvider.cs
浏览文件 @
50471703
...
...
@@ -65,6 +65,11 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
}
}
/// <summary>
/// If the diagnostic is on a argument, the argument is considered to be the argument to fix.
/// There are some exceptions to this rule. Returning null indicates that the fixer needs
/// to find the relevant argument by itself.
/// </summary>
private
TArgumentSyntax
TryGetRelevantArgument
(
SyntaxNode
initialNode
,
SyntaxNode
node
,
Diagnostic
diagnostic
)
{
...
...
@@ -139,6 +144,52 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
RegisterFixForMethodOverloads
(
context
,
arguments
,
insertionData
);
}
private
ImmutableArray
<
ArgumentInsertPositionData
<
TArgumentSyntax
>>
GetArgumentInsertPositionForMethodCandidates
(
TArgumentSyntax
argumentOpt
,
SemanticModel
semanticModel
,
ISyntaxFactsService
syntaxFacts
,
SeparatedSyntaxList
<
TArgumentSyntax
>
arguments
,
ImmutableArray
<
IMethodSymbol
>
methodCandidates
)
{
var
comparer
=
syntaxFacts
.
StringComparer
;
var
methodsAndArgumentToAdd
=
ArrayBuilder
<
ArgumentInsertPositionData
<
TArgumentSyntax
>>.
GetInstance
();
foreach
(
var
method
in
methodCandidates
.
OrderBy
(
m
=>
m
.
Parameters
.
Length
))
{
if
(
method
.
IsNonImplicitAndFromSource
())
{
var
isNamedArgument
=
!
string
.
IsNullOrWhiteSpace
(
syntaxFacts
.
GetNameForArgument
(
argumentOpt
));
if
(
isNamedArgument
||
NonParamsParameterCount
(
method
)
<
arguments
.
Count
)
{
var
argumentToAdd
=
DetermineFirstArgumentToAdd
(
semanticModel
,
syntaxFacts
,
comparer
,
method
,
arguments
,
argumentOpt
);
if
(
argumentToAdd
!=
null
)
{
if
(
argumentOpt
!=
null
&&
argumentToAdd
!=
argumentOpt
)
{
// We were trying to fix a specific argument, but the argument we want
// to fix is something different. That means there was an error earlier
// than this argument. Which means we're looking at a non-viable
// constructor or method. Skip this one.
continue
;
}
methodsAndArgumentToAdd
.
Add
(
new
ArgumentInsertPositionData
<
TArgumentSyntax
>(
method
,
argumentToAdd
,
arguments
.
IndexOf
(
argumentToAdd
)));
}
}
}
}
return
methodsAndArgumentToAdd
.
ToImmutableAndFree
();
}
private
int
NonParamsParameterCount
(
IMethodSymbol
method
)
=>
method
.
IsParams
()
?
method
.
Parameters
.
Length
-
1
:
method
.
Parameters
.
Length
;
private
void
RegisterFixForMethodOverloads
(
CodeFixContext
context
,
SeparatedSyntaxList
<
TArgumentSyntax
>
arguments
,
...
...
@@ -230,52 +281,6 @@ private static string GetCodeFixTitle(IMethodSymbol methodToUpdate, IEnumerable<
return
title
;
}
private
ImmutableArray
<
ArgumentInsertPositionData
<
TArgumentSyntax
>>
GetArgumentInsertPositionForMethodCandidates
(
TArgumentSyntax
argumentOpt
,
SemanticModel
semanticModel
,
ISyntaxFactsService
syntaxFacts
,
SeparatedSyntaxList
<
TArgumentSyntax
>
arguments
,
ImmutableArray
<
IMethodSymbol
>
methodCandidates
)
{
var
comparer
=
syntaxFacts
.
StringComparer
;
var
methodsAndArgumentToAdd
=
ArrayBuilder
<
ArgumentInsertPositionData
<
TArgumentSyntax
>>.
GetInstance
();
foreach
(
var
method
in
methodCandidates
.
OrderBy
(
m
=>
m
.
Parameters
.
Length
))
{
if
(
method
.
IsNonImplicitAndFromSource
())
{
var
isNamedArgument
=
!
string
.
IsNullOrWhiteSpace
(
syntaxFacts
.
GetNameForArgument
(
argumentOpt
));
if
(
isNamedArgument
||
NonParamsParameterCount
(
method
)
<
arguments
.
Count
)
{
var
argumentToAdd
=
DetermineFirstArgumentToAdd
(
semanticModel
,
syntaxFacts
,
comparer
,
method
,
arguments
,
argumentOpt
);
if
(
argumentToAdd
!=
null
)
{
if
(
argumentOpt
!=
null
&&
argumentToAdd
!=
argumentOpt
)
{
// We were trying to fix a specific argument, but the argument we want
// to fix is something different. That means there was an error earlier
// than this argument. Which means we're looking at a non-viable
// constructor or method. Skip this one.
continue
;
}
methodsAndArgumentToAdd
.
Add
(
new
ArgumentInsertPositionData
<
TArgumentSyntax
>(
method
,
argumentToAdd
,
arguments
.
IndexOf
(
argumentToAdd
)));
}
}
}
}
return
methodsAndArgumentToAdd
.
ToImmutableAndFree
();
}
private
int
NonParamsParameterCount
(
IMethodSymbol
method
)
=>
method
.
IsParams
()
?
method
.
Parameters
.
Length
-
1
:
method
.
Parameters
.
Length
;
private
async
Task
<
Solution
>
FixAsync
(
Document
invocationDocument
,
IMethodSymbol
method
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录