提交 4a8ff341 编写于 作者: C CyrusNajmabadi

Remove parameter.

上级 2f794996
......@@ -19,8 +19,7 @@ protected CompletionHelper()
{
}
public static CompletionHelper GetHelper(
Workspace workspace, string language, CompletionService completionService)
public static CompletionHelper GetHelper(Workspace workspace, string language)
{
var ls = workspace.Services.GetLanguageServices(language);
if (ls != null)
......@@ -31,18 +30,15 @@ protected CompletionHelper()
return factory.CreateCompletionHelper();
}
if (completionService != null)
{
return new CompletionHelper();
}
return new CompletionHelper();
}
return null;
}
public static CompletionHelper GetHelper(Document document, CompletionService service)
public static CompletionHelper GetHelper(Document document)
{
return GetHelper(document.Project.Solution.Workspace, document.Project.Language, service);
return GetHelper(document.Project.Solution.Workspace, document.Project.Language);
}
public IReadOnlyList<TextSpan> GetHighlightedSpans(CompletionItem completionItem, string filterText)
......
......@@ -272,8 +272,7 @@ private CompletionHelper GetCompletionHelper()
var document = this.SubjectBuffer.CurrentSnapshot.GetOpenDocumentInCurrentContextWithChanges();
if (document != null)
{
return CompletionHelper.GetHelper(
document, document.GetLanguageService<CompletionService>());
return CompletionHelper.GetHelper(document);
}
return null;
......
......@@ -62,8 +62,7 @@ private CompletionHelper GetCompletionHelper()
var document = GetDocument();
if (document != null)
{
_completionHelper = CompletionHelper.GetHelper(document,
document.Project.LanguageServices.GetService<CompletionService>());
_completionHelper = CompletionHelper.GetHelper(document);
}
}
......
......@@ -58,9 +58,9 @@ internal CompletionServiceWithProviders GetCompletionService(Workspace workspace
internal abstract CompletionServiceWithProviders CreateCompletionService(
Workspace workspace, ImmutableArray<CompletionProvider> exclusiveProviders);
internal static CompletionHelper GetCompletionHelper(Document document, CompletionService service)
internal static CompletionHelper GetCompletionHelper(Document document)
{
return CompletionHelper.GetHelper(document, service);
return CompletionHelper.GetHelper(document);
}
internal static async Task<CompletionContext> GetCompletionListContextAsync(
......@@ -310,7 +310,7 @@ private async Task VerifyCustomCommitProviderCheckResultsAsync(Document document
var customCommitCompletionProvider = service.ExclusiveProviders?[0] as ICustomCommitCompletionProvider;
if (customCommitCompletionProvider != null)
{
var completionRules = GetCompletionHelper(document, service);
var completionRules = GetCompletionHelper(document);
var textView = (await WorkspaceFixture.GetWorkspaceAsync()).Documents.Single().GetTextView();
VerifyCustomCommitWorker(service, customCommitCompletionProvider, firstItem, completionRules, textView, textBuffer, codeBeforeCommit, expectedCodeAfterCommit, commitChar);
}
......@@ -416,7 +416,7 @@ private async Task VerifyCustomCommitProviderCheckResultsAsync(Document document
var items = (await GetCompletionListAsync(service, document, position, CompletionTrigger.Default)).Items;
var firstItem = items.First(i => CompareItems(i.DisplayText, itemToCommit));
var completionRules = GetCompletionHelper(document, service);
var completionRules = GetCompletionHelper(document);
var commitChar = commitCharOpt ?? '\t';
var text = await document.GetTextAsync();
......
......@@ -48,8 +48,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense
Private Sub TestMatches(v As String, wordsToMatch() As String)
Using New CultureContext("tr-TR")
Dim workspace = New TestWorkspace
Dim helper = CompletionHelper.GetHelper(workspace, LanguageNames.CSharp,
workspace.Services.GetLanguageServices(LanguageNames.CSharp).GetService(Of CompletionService))
Dim helper = CompletionHelper.GetHelper(workspace, LanguageNames.CSharp)
For Each word In wordsToMatch
Dim item = CompletionItem.Create(word)
Assert.True(helper.MatchesFilterText(item, v, CompletionTrigger.Default, CompletionFilterReason.TypeChar), $"Expected item {word} does not match {v}")
......@@ -60,8 +59,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense
Private Sub TestNotMatches(v As String, wordsToNotMatch() As String)
Using New CultureContext("tr-TR")
Dim workspace = New TestWorkspace
Dim helper = CompletionHelper.GetHelper(workspace, LanguageNames.CSharp,
workspace.Services.GetLanguageServices(LanguageNames.CSharp).GetService(Of CompletionService))
Dim helper = CompletionHelper.GetHelper(workspace, LanguageNames.CSharp)
For Each word In wordsToNotMatch
Dim item = CompletionItem.Create(word)
Assert.False(helper.MatchesFilterText(item, v, CompletionTrigger.Default, CompletionFilterReason.TypeChar), $"Unexpected item {word} matches {v}")
......
......@@ -142,7 +142,7 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.Completion.Complet
Dim completionList = Await GetCompletionListAsync(service, document, position, CompletionTrigger.Default)
Dim item = completionList.Items.First()
Dim helper = CompletionHelper.GetHelper(document, service)
Dim helper = CompletionHelper.GetHelper(document)
For Each ch In chars
Assert.True(Controller.IsCommitCharacter(service.GetRules(), item, ch, textTypedSoFar), $"Expected '{ch}' to be a commit character")
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册