Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
44a5287f
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
44a5287f
编写于
6月 25, 2020
作者:
G
Gen Lu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use loop instead of enumerator
上级
3b9099a1
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
25 addition
and
31 deletion
+25
-31
src/Features/Core/Portable/Completion/Providers/ImportCompletionProvider/ExtensionMethodImportCompletionHelper.cs
...mpletionProvider/ExtensionMethodImportCompletionHelper.cs
+25
-31
未找到文件。
src/Features/Core/Portable/Completion/Providers/ImportCompletionProvider/ExtensionMethodImportCompletionHelper.cs
浏览文件 @
44a5287f
...
...
@@ -303,45 +303,39 @@ static ImmutableArray<string> AttachComplexTypes(ImmutableArray<string> receiver
// This is also affected by the symbol resolving issue mentioned above, which means in case referenced projects
// are targeting different framework, we will miss extension methods with any framework type in their signature from those projects.
var
methodsInCurrentCompilation
=
methodSymbols
.
Select
(
s
=>
SymbolFinder
.
FindSimilarSymbols
(
s
,
semanticModel
.
Compilation
).
FirstOrDefault
()).
WhereNotNull
();
var
enumerator
=
methodsInCurrentCompilation
.
GetEnumerator
();
if
(!
enumerator
.
MoveNext
())
{
continue
;
}
var
methodInCurrentCompilation
=
enumerator
.
Current
;
// We haven't seen this receiver type yet. Try to check by reducing one extension method
// to the given receiver type and save the result.
if
(!
cachedResult
)
{
// If this is the first symbol we retrived from current compilation,
// try to check if we can apply it to given receiver type, and save result to our cache.
var
reducedMethodSymbol
=
methodInCurrentCompilation
.
ReduceExtensionMethod
(
receiverTypeSymbol
);
cachedResult
=
reducedMethodSymbol
!=
null
;
checkedReceiverTypes
[
declaredReceiverTypeInCurrentCompilation
]
=
cachedResult
;
}
// Now, cachedResult being false means method doesn't match the receiver type,
// stop processing methods from this group.
if
(!
cachedResult
)
var
isFirstMethod
=
true
;
foreach
(
var
methodInCurrentCompilation
in
methodSymbols
.
Select
(
s
=>
SymbolFinder
.
FindSimilarSymbols
(
s
,
semanticModel
.
Compilation
).
FirstOrDefault
()).
WhereNotNull
())
{
continue
;
}
if
(
isFirstMethod
)
{
isFirstMethod
=
false
;
// Add all methods to item list
do
{
methodInCurrentCompilation
=
enumerator
.
Current
;
// We haven't seen this receiver type yet. Try to check by reducing one extension method
// to the given receiver type and save the result.
if
(!
cachedResult
)
{
// If this is the first symbol we retrived from current compilation,
// try to check if we can apply it to given receiver type, and save result to our cache.
// Since method symbols are grouped by their declared receiver type, they are either all matches to the receiver type
// or all mismatches. So we only need to call ReduceExtensionMethod on one of them.
var
reducedMethodSymbol
=
methodInCurrentCompilation
.
ReduceExtensionMethod
(
receiverTypeSymbol
);
cachedResult
=
reducedMethodSymbol
!=
null
;
checkedReceiverTypes
[
declaredReceiverTypeInCurrentCompilation
]
=
cachedResult
;
// Now, cachedResult being false means method doesn't match the receiver type,
// stop processing methods from this group.
if
(!
cachedResult
)
{
break
;
}
}
}
if
(
semanticModel
.
IsAccessible
(
position
,
methodInCurrentCompilation
))
{
CreateAndAddItem
(
methodInCurrentCompilation
,
builder
,
stringCache
);
}
}
while
(
enumerator
.
MoveNext
());
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录