renamed ICompilerDiagnosticAnalyzer to ICodeAnalysisDiagnosticAnalyzerExecutor

src/EditorFeatures/Test/TestExportProvider.cs

@@ -110,7 +110,7 @@ private static Type[] GetNeutralAndCSharpAndVisualBasicTypes()
                 typeof(CSharp.LanguageServices.CSharpContentTypeLanguageService),
                 typeof(VisualBasic.LanguageServices.VisualBasicContentTypeLanguageService),
                 typeof(IncrementalCaches.SymbolTreeInfoIncrementalAnalyzerProvider),
-                typeof(CodeAnalysis.Diagnostics.EngineV2.InProcCompilerDiagnosticAnalyzer)
+                typeof(CodeAnalysis.Diagnostics.EngineV2.InProcCodeAnalysisDiagnosticAnalyzerExecutor)
             };
 
             return MinimalTestExportProvider.GetLanguageNeutralTypes()

src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs

@@ -496,7 +496,7 @@ private IEnumerable<DiagnosticData> ConvertToLocalDiagnosticsWithoutCompilation(
                         ImmutableDictionary<DiagnosticAnalyzer, AnalyzerTelemetryInfo>.Empty);
                 }
 
-                var executor = project.Solution.Workspace.Services.GetService<ICompilerDiagnosticAnalyzer>();
+                var executor = project.Solution.Workspace.Services.GetService<ICodeAnalysisDiagnosticAnalyzerExecutor>();
                 return await executor.AnalyzeAsync(analyzerDriver, project, cancellationToken).ConfigureAwait(false);
             }
 

src/Features/Core/Portable/Diagnostics/EngineV2/ICompilerDiagnosticAnalyzer.cs → src/Features/Core/Portable/Diagnostics/EngineV2/ICodeAnalysisDiagnosticAnalyzerExecutor.cs

@@ -7,7 +7,13 @@
 
 namespace Microsoft.CodeAnalysis.Diagnostics.EngineV2
 {
-    internal interface ICompilerDiagnosticAnalyzer : IWorkspaceService
+    /// <summary>
+    /// Interface to run DiagnosticAnalyzers. Implementation of this interface should be 
+    /// able to run analyzers that can run in command line (Host agnostic DiagnosticAnalyzers)
+    /// 
+    /// How and where analyzers run depends on the implementation of this interface
+    /// </summary>
+    internal interface ICodeAnalysisDiagnosticAnalyzerExecutor : IWorkspaceService
     {
         Task<DiagnosticAnalysisResultMap<DiagnosticAnalyzer, DiagnosticAnalysisResult>> AnalyzeAsync(CompilationWithAnalyzers analyzerDriver, Project project, CancellationToken cancellationToken);
     }

src/Features/Core/Portable/Diagnostics/EngineV2/InProcCompilerDiagnosticAnalyzer.cs → src/Features/Core/Portable/Diagnostics/EngineV2/InProcCodeAnalysisDiagnosticAnalyzerExecutor.cs

@@ -10,8 +10,8 @@
 
 namespace Microsoft.CodeAnalysis.Diagnostics.EngineV2
 {
-    [ExportWorkspaceService(typeof(ICompilerDiagnosticAnalyzer)), Shared]
-    internal class InProcCompilerDiagnosticAnalyzer : ICompilerDiagnosticAnalyzer
+    [ExportWorkspaceService(typeof(ICodeAnalysisDiagnosticAnalyzerExecutor)), Shared]
+    internal class InProcCodeAnalysisDiagnosticAnalyzerExecutor : ICodeAnalysisDiagnosticAnalyzerExecutor
     {
         public async Task<DiagnosticAnalysisResultMap<DiagnosticAnalyzer, DiagnosticAnalysisResult>> AnalyzeAsync(CompilationWithAnalyzers analyzerDriver, Project project, CancellationToken cancellationToken)
         {

src/Features/Core/Portable/Features.csproj

@@ -233,8 +233,8 @@
     <Compile Include="FindReferences\DocumentLocation.cs" />
     <Compile Include="FindReferences\IDefinitionsAndReferencesFactory.cs" />
     <Compile Include="FindReferences\SourceReferenceItem.cs" />
-    <Compile Include="Diagnostics\EngineV2\InProcCompilerDiagnosticAnalyzer.cs" />
-    <Compile Include="Diagnostics\EngineV2\ICompilerDiagnosticAnalyzer.cs" />
+    <Compile Include="Diagnostics\EngineV2\InProcCodeAnalysisDiagnosticAnalyzerExecutor.cs" />
+    <Compile Include="Diagnostics\EngineV2\ICodeAnalysisDiagnosticAnalyzerExecutor.cs" />
     <Compile Include="ReplacePropertyWithMethods\AbstractReplacePropertyWithMethodsService.cs" />
     <Compile Include="ReplacePropertyWithMethods\IReplacePropertyWithMethodsService.cs" />
     <Compile Include="ReplacePropertyWithMethods\ReplacePropertyWithMethodsCodeRefactoringProvider.cs" />

src/VisualStudio/Next/Diagnostics/OutOfProcCompilerDiagnosticAnalyzer.cs → src/VisualStudio/Next/Diagnostics/OutOfProcDiagnosticAnalyzerExecutor.cs

@@ -22,10 +22,10 @@
 
 namespace Microsoft.VisualStudio.LanguageServices.Diagnostics
 {
-    [ExportWorkspaceService(typeof(ICompilerDiagnosticAnalyzer), layer: ServiceLayer.Host), Shared]
-    internal class OutOfProcCompilerDiagnosticAnalyzer : ICompilerDiagnosticAnalyzer
+    [ExportWorkspaceService(typeof(ICodeAnalysisDiagnosticAnalyzerExecutor), layer: ServiceLayer.Host), Shared]
+    internal class OutOfProcDiagnosticAnalyzerExecutor : ICodeAnalysisDiagnosticAnalyzerExecutor
     {
-        private static readonly ICompilerDiagnosticAnalyzer _inProcAnalyzer = new InProcCompilerDiagnosticAnalyzer();
+        private static readonly ICodeAnalysisDiagnosticAnalyzerExecutor _inProcAnalyzer = new InProcCodeAnalysisDiagnosticAnalyzerExecutor();
 
         private readonly IDiagnosticAnalyzerService _analyzerService;
         private readonly AbstractHostDiagnosticUpdateSource _hostDiagnosticUpdateSource;
@@ -34,7 +34,7 @@ internal class OutOfProcCompilerDiagnosticAnalyzer : ICompilerDiagnosticAnalyzer
         private ChecksumScope _lastSnapshot;
 
         [ImportingConstructor]
-        public OutOfProcCompilerDiagnosticAnalyzer(
+        public OutOfProcDiagnosticAnalyzerExecutor(
             IDiagnosticAnalyzerService analyzerService,
             AbstractHostDiagnosticUpdateSource hostDiagnosticUpdateSource)
         {

src/VisualStudio/Next/ServicesVisualStudio.Next.csproj

@@ -81,7 +81,7 @@
     <Compile Include="..\..\Workspaces\Remote\ServiceHub\Shared\WellKnownServiceHubServices.cs">
       <Link>Shared\WellKnownServiceHubServices.cs</Link>
     </Compile>
-    <Compile Include="Diagnostics\OutOfProcCompilerDiagnosticAnalyzer.cs" />
+    <Compile Include="Diagnostics\OutOfProcDiagnosticAnalyzerExecutor.cs" />
     <Compile Include="Remote\RemoteHostClientServiceFactory.RemoteHostClientService.cs" />
     <Compile Include="Remote\RemoteHostClientServiceFactory.cs" />
     <Compile Include="Remote\JsonRpcClient.cs" />