提交 41a275b2 编写于 作者: C Cyrus Najmabadi

Add comment.

上级 af1d63e7
......@@ -20,8 +20,6 @@ namespace Microsoft.CodeAnalysis.CSharp.UseDeconstruction
[ExportCodeFixProvider(LanguageNames.CSharp), Shared]
internal class CSharpUseDeconstructionCodeFixProvider : SyntaxEditorBasedCodeFixProvider
{
private readonly CSharpUseDeconstructionDiagnosticAnalyzer s_analyzer = new CSharpUseDeconstructionDiagnosticAnalyzer();
public override ImmutableArray<string> FixableDiagnosticIds
=> ImmutableArray.Create(IDEDiagnosticIds.UseDeconstructionDiagnosticId);
......@@ -65,7 +63,7 @@ private SyntaxNode UpdateRoot(SemanticModel semanticModel, SyntaxNode root, Synt
if (node is VariableDeclaratorSyntax variableDeclarator)
{
var variableDeclaration = (VariableDeclarationSyntax)variableDeclarator.Parent;
if (s_analyzer.TryAnalyzeVariableDeclaration(
if (CSharpUseDeconstructionDiagnosticAnalyzer.TryAnalyzeVariableDeclaration(
semanticModel, variableDeclaration,
out var tupleType, out memberAccessExpressions,
cancellationToken))
......@@ -81,7 +79,7 @@ private SyntaxNode UpdateRoot(SemanticModel semanticModel, SyntaxNode root, Synt
}
else if (node is ForEachStatementSyntax forEachStatement)
{
if (s_analyzer.TryAnalyzeForEachStatement(
if (CSharpUseDeconstructionDiagnosticAnalyzer.TryAnalyzeForEachStatement(
semanticModel, forEachStatement,
out var tupleType, out memberAccessExpressions,
cancellationToken))
......
......@@ -67,7 +67,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
private void AnalyzeVariableDeclaration(
SyntaxNodeAnalysisContext context, VariableDeclarationSyntax variableDeclaration, DiagnosticSeverity severity)
{
if (!this.TryAnalyzeVariableDeclaration(
if (!TryAnalyzeVariableDeclaration(
context.SemanticModel, variableDeclaration, out _,
out var memberAccessExpressions, context.CancellationToken))
{
......@@ -82,7 +82,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
private void AnalyzeForEachStatement(
SyntaxNodeAnalysisContext context, ForEachStatementSyntax forEachStatement, DiagnosticSeverity severity)
{
if (!this.TryAnalyzeForEachStatement(
if (!TryAnalyzeForEachStatement(
context.SemanticModel, forEachStatement, out _,
out var memberAccessExpressions, context.CancellationToken))
{
......@@ -94,7 +94,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
forEachStatement.Identifier.GetLocation()));
}
public bool TryAnalyzeVariableDeclaration(
public static bool TryAnalyzeVariableDeclaration(
SemanticModel semanticModel,
VariableDeclarationSyntax variableDeclaration,
out INamedTypeSymbol tupleType,
......@@ -132,7 +132,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
out tupleType, out memberAccessExpressions, cancellationToken);
}
public bool TryAnalyzeForEachStatement(
public static bool TryAnalyzeForEachStatement(
SemanticModel semanticModel,
ForEachStatementSyntax forEachStatement,
out INamedTypeSymbol tupleType,
......@@ -146,7 +146,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
forEachStatement, out tupleType, out memberAccessExpressions, cancellationToken);
}
private bool TryAnalyze(
private static bool TryAnalyze(
SemanticModel semanticModel,
ILocalSymbol local,
TypeSyntax typeNode,
......@@ -220,7 +220,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
}
}
private bool AnyTupleFieldNamesCollideWithExistingNames(
private static bool AnyTupleFieldNamesCollideWithExistingNames(
SemanticModel semanticModel, INamedTypeSymbol tupleType,
SyntaxNode container, CancellationToken cancellationToken)
{
......@@ -242,7 +242,7 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
return false;
}
private bool IsViableTupleTypeSyntax(TypeSyntax type)
private static bool IsViableTupleTypeSyntax(TypeSyntax type)
{
if (type.IsVar)
{
......@@ -270,7 +270,7 @@ private bool IsViableTupleTypeSyntax(TypeSyntax type)
return false;
}
private bool OnlyUsedToAccessTupleFields(
private static bool OnlyUsedToAccessTupleFields(
SemanticModel semanticModel, SyntaxNode searchScope, ILocalSymbol local,
ArrayBuilder<MemberAccessExpressionSyntax> memberAccessLocations, CancellationToken cancellationToken)
{
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册