Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
3f256a7c
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
3f256a7c
编写于
3月 06, 2018
作者:
O
Omar Tawfik
提交者:
Julien Couvreur
3月 05, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Support PointerElementAccess in value escape rules (#24909)
上级
a3e9a813
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
64 addition
and
2 deletion
+64
-2
src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs
src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs
+13
-2
src/Compilers/CSharp/Test/Semantic/Semantics/RefEscapingTests.cs
...pilers/CSharp/Test/Semantic/Semantics/RefEscapingTests.cs
+51
-0
未找到文件。
src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs
浏览文件 @
3f256a7c
...
...
@@ -2185,6 +2185,11 @@ internal static uint GetValEscape(BoundExpression expr, uint scopeOfTheContainin
// just say it does not escape anywhere, so that we do not get false errors.
return
scopeOfTheContainingExpression
;
case
BoundKind
.
PointerElementAccess
:
case
BoundKind
.
PointerIndirectionOperator
:
// Unsafe code will always be allowed to escape.
return
Binder
.
ExternalScope
;
default
:
throw
ExceptionUtilities
.
UnexpectedValue
(
$"
{
expr
.
Kind
}
expression of
{
expr
.
Type
}
type"
);
}
...
...
@@ -2492,13 +2497,19 @@ internal static bool CheckValEscape(SyntaxNode node, BoundExpression expr, uint
var
colElement
=
(
BoundCollectionElementInitializer
)
expr
;
return
CheckValEscape
(
colElement
.
Arguments
,
escapeFrom
,
escapeTo
,
diagnostics
);
case
BoundKind
.
PointerElementAccess
:
var
accessedExpression
=
((
BoundPointerElementAccess
)
expr
).
Expression
;
return
CheckValEscape
(
accessedExpression
.
Syntax
,
accessedExpression
,
escapeFrom
,
escapeTo
,
checkingReceiver
,
diagnostics
);
case
BoundKind
.
PointerIndirectionOperator
:
var
operandExpression
=
((
BoundPointerIndirectionOperator
)
expr
).
Operand
;
return
CheckValEscape
(
operandExpression
.
Syntax
,
operandExpression
,
escapeFrom
,
escapeTo
,
checkingReceiver
,
diagnostics
);
default
:
throw
ExceptionUtilities
.
UnexpectedValue
(
$"
{
expr
.
Kind
}
expression of
{
expr
.
Type
}
type"
);
#
region
"cannot produce ref-like values"
// case BoundKind.ThrowExpression:
// case BoundKind.PointerIndirectionOperator:
// case BoundKind.PointerElementAccess:
// case BoundKind.ArgListOperator:
// case BoundKind.ArgList:
// case BoundKind.RefTypeOperator:
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/RefEscapingTests.cs
浏览文件 @
3f256a7c
...
...
@@ -3201,5 +3201,56 @@ public class C
"
;
CreateCompilationWithMscorlibAndSpan
(
text
).
VerifyDiagnostics
();
}
[
Fact
]
[
WorkItem
(
24776
,
"https://github.com/dotnet/roslyn/issues/24776"
)]
public
void
PointerElementAccess_RefStructPointer
()
{
CreateCompilation
(
@"
public ref struct TestStruct
{
public void M() { }
}
public class C
{
public static unsafe void Test(TestStruct[] ar)
{
fixed (TestStruct* p = ar)
{
for (int i = 0; i < ar.Length; i++)
{
p[i].M();
}
}
}
}"
,
options
:
TestOptions
.
UnsafeReleaseDll
).
VerifyDiagnostics
(
// (8,36): error CS0611: Array elements cannot be of type 'TestStruct'
// public static unsafe void Test(TestStruct[] ar)
Diagnostic
(
ErrorCode
.
ERR_ArrayElementCantBeRefAny
,
"TestStruct"
).
WithArguments
(
"TestStruct"
).
WithLocation
(
8
,
36
));
}
[
Fact
]
[
WorkItem
(
24776
,
"https://github.com/dotnet/roslyn/issues/24776"
)]
public
void
PointerIndirectionOperator_RefStructPointer
()
{
CreateCompilation
(
@"
public ref struct TestStruct
{
public void M() { }
}
public class C
{
public static unsafe void Test(TestStruct[] ar)
{
fixed (TestStruct* p = ar)
{
var x = *p;
}
}
}"
,
options
:
TestOptions
.
UnsafeReleaseDll
).
VerifyDiagnostics
(
// (8,36): error CS0611: Array elements cannot be of type 'TestStruct'
// public static unsafe void Test(TestStruct[] ar)
Diagnostic
(
ErrorCode
.
ERR_ArrayElementCantBeRefAny
,
"TestStruct"
).
WithArguments
(
"TestStruct"
).
WithLocation
(
8
,
36
));
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录