Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
3efbc944
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
3efbc944
编写于
4月 20, 2018
作者:
C
Cyrus Najmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add tests.
上级
f1c9b4fe
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
58 addition
and
12 deletion
+58
-12
src/EditorFeatures/CSharpTest/GenerateFromMembers/GenerateEqualsAndGetHashCodeFromMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs
...omMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs
+45
-0
src/Workspaces/Core/Portable/Shared/Extensions/ICodeDefinitionFactoryExtensions_CreateEqualsMethod.cs
...ns/ICodeDefinitionFactoryExtensions_CreateEqualsMethod.cs
+13
-12
未找到文件。
src/EditorFeatures/CSharpTest/GenerateFromMembers/GenerateEqualsAndGetHashCodeFromMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs
浏览文件 @
3efbc944
...
@@ -1575,5 +1575,50 @@ public override bool Equals(object obj)
...
@@ -1575,5 +1575,50 @@ public override bool Equals(object obj)
}
}
}"
);
}"
);
}
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsGenerateEqualsAndGetHashCode
)]
public
async
Task
TestEqualsBaseWithOverriddenEquals_Patterns
()
{
await
TestInRegularAndScript1Async
(
@"using System.Collections.Generic;
class Base
{
public override bool Equals(object o)
{
}
}
class Program : Base
{
[|int i;
string S { get; }|]
}"
,
@"using System.Collections.Generic;
class Base
{
public override bool Equals(object o)
{
}
}
class Program : Base
{
int i;
string S { get; }
public override bool Equals(object obj)
{
return obj is Program program &&
base.Equals(obj) &&
i == program.i &&
S == program.S;
}
}"
,
index
:
0
);
}
}
}
}
}
src/Workspaces/Core/Portable/Shared/Extensions/ICodeDefinitionFactoryExtensions_CreateEqualsMethod.cs
浏览文件 @
3efbc944
...
@@ -157,18 +157,19 @@ public static IMethodSymbol CreateEqualsMethod(this Compilation compilation, Imm
...
@@ -157,18 +157,19 @@ public static IMethodSymbol CreateEqualsMethod(this Compilation compilation, Imm
//
//
// myType != null
// myType != null
expressions
.
Add
(
factory
.
ReferenceNotEqualsExpression
(
localNameExpression
,
factory
.
NullLiteralExpression
()));
expressions
.
Add
(
factory
.
ReferenceNotEqualsExpression
(
localNameExpression
,
factory
.
NullLiteralExpression
()));
if
(
HasExistingBaseEqualsMethod
(
containingType
,
cancellationToken
))
}
{
// If we're overriding something that also provided an overridden 'Equals',
if
(!
containingType
.
IsValueType
&&
HasExistingBaseEqualsMethod
(
containingType
,
cancellationToken
))
// then ensure the base type thinks it is equals as well.
{
//
// If we're overriding something that also provided an overridden 'Equals',
// base.Equals(obj)
// then ensure the base type thinks it is equals as well.
expressions
.
Add
(
factory
.
InvocationExpression
(
//
factory
.
MemberAccessExpression
(
// base.Equals(obj)
factory
.
BaseExpression
(),
expressions
.
Add
(
factory
.
InvocationExpression
(
factory
.
IdentifierName
(
EqualsName
)),
factory
.
MemberAccessExpression
(
objNameExpression
));
factory
.
BaseExpression
(),
}
factory
.
IdentifierName
(
EqualsName
)),
objNameExpression
));
}
}
AddMemberChecks
(
factory
,
compilation
,
members
,
localNameExpression
,
expressions
);
AddMemberChecks
(
factory
,
compilation
,
members
,
localNameExpression
,
expressions
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录