提交 3c3a8a1f 编写于 作者: G Gen Lu

Address review comments

上级 f20d3090
......@@ -167,31 +167,31 @@ public void M({type2} x)
[Theory, Trait(Traits.Feature, Traits.Features.Completion)]
public async Task UsingAliasInDeclaration(ReferenceType refType)
{
var file1 = $@"
var file1 = @"
using System;
using MyInt = System.Int32;
namespace Foo
{{
{
public static class ExtensionClass
{{
{
public static bool ExtentionMethod(this MyInt x)
=> true;
}}
}}";
var file2 = $@"
}
}";
var file2 = @"
using System;
namespace Baz
{{
{
public class Bat
{{
{
public void M(int x)
{{
{
x.$$
}}
}}
}}";
}
}
}";
var markup = GetMarkup(file2, file1, refType);
await VerifyTypeImportItemExistsAsync(
......
......@@ -319,6 +319,7 @@ internal static partial class ExtensionMethodImportCompletionService
conflictTypeRootNode.Add(fullyQualifiedContainerName, (qualifiedNamespaceName, methodNames));
}
}
var ticks = Environment.TickCount;
GetItemsFromConflictingTypes(rootNamespaceSymbol, conflictTypeRootNode, builder, receiverTypeSymbol, semanticModel, position, counter);
......
......@@ -16,6 +16,9 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.FindSymbols
Friend Class VisualBasicDeclaredSymbolInfoFactoryService
Inherits AbstractDeclaredSymbolInfoFactoryService
Private Const ExtensionName As String = "Extension"
Private Const ExtensionAttributeName As String = "ExtensionAttribute"
<ImportingConstructor>
Public Sub New()
End Sub
......@@ -307,7 +310,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.FindSymbols
End If
Dim name = attribute.Name.GetRightmostName()?.ToString()
If String.Equals(name, "Extension", StringComparison.OrdinalIgnoreCase) Or String.Equals(name, "ExtensionAttribute", StringComparison.OrdinalIgnoreCase) Then
If String.Equals(name, ExtensionName, StringComparison.OrdinalIgnoreCase) Or String.Equals(name, ExtensionAttributeName, StringComparison.OrdinalIgnoreCase) Then
Return True
End If
Next
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册