Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
3c227cae
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
3c227cae
编写于
4月 25, 2020
作者:
A
Alireza Habibi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
CR feedback
上级
1ef362f0
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
31 addition
and
5 deletion
+31
-5
src/EditorFeatures/CSharpTest/UsePatternCombinators/CSharpUsePatternCombinatorsDiagnosticAnalyzerTests.cs
...ors/CSharpUsePatternCombinatorsDiagnosticAnalyzerTests.cs
+2
-1
src/Features/CSharp/Portable/UsePatternCombinators/CSharpUsePatternCombinatorsDiagnosticAnalyzer.cs
...binators/CSharpUsePatternCombinatorsDiagnosticAnalyzer.cs
+29
-4
未找到文件。
src/EditorFeatures/CSharpTest/UsePatternCombinators/CSharpUsePatternCombinatorsDiagnosticAnalyzerTests.cs
浏览文件 @
3c227cae
...
...
@@ -49,14 +49,15 @@ class C
[
InlineData
(
"i is C c"
)]
[
InlineData
(
"!(i > 0)"
)]
[
InlineData
(
"o != null"
)]
[
InlineData
(
"!(o is C c)"
)]
[
Theory
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUsePatternCombinators
)]
public
async
Task
TestMissingOnExpression
(
string
expression
)
{
await
TestMissingAsync
(
s_initialMarkup
.
Replace
(
"EXPRESSION"
,
expression
));
}
[
InlineData
(
"!(o is C c)"
,
"o is not C c"
)]
[
InlineData
(
"!(o is C)"
,
"o is not C"
)]
[
InlineData
(
"!(o is C _)"
,
"o is not C _"
)]
[
InlineData
(
"i == 1 || 2 == i"
,
"i is 1 or 2"
)]
[
InlineData
(
"i != 1 || 2 != i"
,
"i is not 1 or not 2"
)]
[
InlineData
(
"i != 1 && 2 != i"
,
"i is not (1 or 2)"
)]
...
...
src/Features/CSharp/Portable/UsePatternCombinators/CSharpUsePatternCombinatorsDiagnosticAnalyzer.cs
浏览文件 @
3c227cae
...
...
@@ -4,8 +4,10 @@
#
nullable
enable
using
System.Linq
;
using
Microsoft.CodeAnalysis.CodeStyle
;
using
Microsoft.CodeAnalysis.CSharp.Extensions
;
using
Microsoft.CodeAnalysis.CSharp.Shared.Extensions
;
using
Microsoft.CodeAnalysis.CSharp.Syntax
;
using
Microsoft.CodeAnalysis.Diagnostics
;
...
...
@@ -57,18 +59,18 @@ protected override void InitializeWorker(AnalysisContext context)
ArrowExpressionClauseSyntax
n
=>
n
.
Expression
,
AssignmentExpressionSyntax
n
=>
n
.
Right
,
LambdaExpressionSyntax
n
=>
n
.
ExpressionBody
,
ArgumentSyntax
n
when
n
.
GetRefKind
()
==
RefKind
.
None
=>
n
.
Expression
,
ArgumentSyntax
n
when
n
.
RefKindKeyword
.
IsMissing
=>
n
.
Expression
,
_
=>
null
,
};
private
void
AnalyzeNode
(
SyntaxNodeAnalysisContext
context
)
{
// TODO need an option for user to disable the feature
// TODO need to check language version >= C# 9.0
var
parentNode
=
context
.
Node
;
if
(!((
CSharpParseOptions
)
parentNode
.
SyntaxTree
.
Options
).
LanguageVersion
.
IsCSharp9OrAbove
())
return
;
var
expression
=
GetExpression
(
parentNode
);
if
(
expression
is
null
)
return
;
...
...
@@ -84,6 +86,9 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
if
(
IsTrivial
(
pattern
))
return
;
if
(
HasIllegalPatternVariables
(
pattern
))
return
;
context
.
ReportDiagnostic
(
DiagnosticHelper
.
Create
(
Descriptor
,
location
:
expression
.
GetLocation
(),
...
...
@@ -93,6 +98,26 @@ private void AnalyzeNode(SyntaxNodeAnalysisContext context)
messageArgs
:
null
));
}
private
static
bool
HasIllegalPatternVariables
(
AnalyzedPattern
pattern
,
bool
permitDesignations
=
true
)
{
switch
(
pattern
)
{
case
Not
p
:
return
HasIllegalPatternVariables
(
p
.
Pattern
,
permitDesignations
:
false
);
case
Binary
p
:
if
(
p
.
IsDisjunctive
)
permitDesignations
=
false
;
return
HasIllegalPatternVariables
(
p
.
Left
,
permitDesignations
)
||
HasIllegalPatternVariables
(
p
.
Right
,
permitDesignations
);
case
Source
p
when
!
permitDesignations
:
return
p
.
PatternSyntax
.
DescendantNodes
()
.
OfType
<
SingleVariableDesignationSyntax
>()
.
Any
(
variable
=>
!
variable
.
Identifier
.
IsMissing
);
default
:
return
false
;
}
}
private
static
bool
IsTrivial
(
AnalyzedPattern
pattern
)
=>
pattern
switch
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录