Merge pull request #8479 from TyOverby/dont-eat-errors

make msbuildtask not eat errors

src/Compilers/Core/MSBuildTask/Shared/Csc.cs

@@ -486,14 +486,7 @@ private bool InitializeHostCompiler(ICscHostObject cscHostObject)
             }
             catch (Exception e)
             {
-                if (HostCompilerSupportsAllParameters)
-                {
-                    // If the host compiler doesn't support everything we need, we're going to end up 
-                    // shelling out to the command-line compiler anyway.  That means the command-line
-                    // compiler will log the error.  So here, we only log the error if we would've
-                    // tried to use the host compiler.
-                    Log.LogErrorWithCodeFromResources("General_CouldNotSetHostObjectParameter", param, e.Message);
-                }
+                Log.LogErrorWithCodeFromResources("General_CouldNotSetHostObjectParameter", param, e.Message);
                 return false;
             }
 
@@ -620,14 +613,7 @@ private bool InitializeHostCompiler(ICscHostObject cscHostObject)
             }
             catch (Exception e)
             {
-                if (HostCompilerSupportsAllParameters)
-                {
-                    // If the host compiler doesn't support everything we need, we're going to end up 
-                    // shelling out to the command-line compiler anyway.  That means the command-line
-                    // compiler will log the error.  So here, we only log the error if we would've
-                    // tried to use the host compiler.
-                    Log.LogErrorWithCodeFromResources("General_CouldNotSetHostObjectParameter", param, e.Message);
-                }
+                Log.LogErrorWithCodeFromResources("General_CouldNotSetHostObjectParameter", param, e.Message);
                 return false;
             }
             finally
@@ -748,4 +734,4 @@ protected override bool CallHostObjectToExecute()
             return cscHostObject.Compile();
         }
     }
-}
\ No newline at end of file
+}

src/Compilers/Core/MSBuildTask/Shared/Vbc.cs

@@ -967,15 +967,7 @@ private bool InitializeHostCompiler(IVbcHostObject vbcHostObject)
             }
             catch (Exception e)
             {
-                if (this.HostCompilerSupportsAllParameters)
-                {
-                    // If the host compiler doesn't support everything we need, we're going to end up 
-                    // shelling out to the command-line compiler anyway.  That means the command-line
-                    // compiler will log the error.  So here, we only log the error if we would've
-                    // tried to use the host compiler.
-                    Log.LogErrorWithCodeFromResources("General_CouldNotSetHostObjectParameter", param, e.Message);
-                }
-
+                Log.LogErrorWithCodeFromResources("General_CouldNotSetHostObjectParameter", param, e.Message);
                 return false;
             }
             finally
@@ -1113,4 +1105,4 @@ public VBError(string message, MessageImportance importance)
             }
         }
     }
-}
\ No newline at end of file
+}