Move ToAssemblyName

This function relied on CultureInfo which is not a supported CoreFx API.
Moved it out to the Desktop layers where it was actually used.

src/Compilers/Core/CodeAnalysisTest/CodeAnalysisTest.csproj

@@ -24,6 +24,9 @@
     <Compile Include="..\..\Helpers\InMemoryAssemblyProvider.cs">
       <Link>InMemoryAssemblyProvider.cs</Link>
     </Compile>
+    <Compile Include="..\..\Helpers\AssemblyIdentityExtensions.cs">
+      <Link>AssemblyIdentityExtensions.cs</Link>
+    </Compile>
     <Compile Include="AnalyzerFileReferenceTests.cs" />
     <Compile Include="AsyncQueueTests.cs" />
     <Compile Include="Collections\BoxesTest.cs" />

src/Compilers/Core/Desktop/CodeAnalysis.Desktop.csproj

@@ -56,7 +56,6 @@
       <DesignTime>True</DesignTime>
       <DependentUpon>CodeAnalysisDesktopResources.resx</DependentUpon>
     </Compile>
-    <Compile Include="AssemblyIdentityExtensions.cs" />
     <Compile Include="AssemblyPortabilityPolicy.cs" />
     <Compile Include="AssemblyVersion.cs" />
     <Compile Include="CommandLine\CommandLineReference.cs" />

src/Compilers/Core/Desktop/PublicAPI.txt

-Microsoft.CodeAnalysis.AssemblyIdentityExtensions
 Microsoft.CodeAnalysis.CommandLineAnalyzerReference
 Microsoft.CodeAnalysis.CommandLineAnalyzerReference.CommandLineAnalyzerReference(string path) -> void
 Microsoft.CodeAnalysis.CommandLineAnalyzerReference.Equals(Microsoft.CodeAnalysis.CommandLineAnalyzerReference other) -> bool
@@ -113,7 +112,6 @@ override Microsoft.CodeAnalysis.XmlFileResolver.ResolveReference(string path, st
 readonly Microsoft.CodeAnalysis.Diagnostics.AnalyzerLoadFailureEventArgs.ErrorCode -> Microsoft.CodeAnalysis.Diagnostics.AnalyzerLoadFailureEventArgs.FailureErrorCode
 readonly Microsoft.CodeAnalysis.Diagnostics.AnalyzerLoadFailureEventArgs.Exception -> System.Exception
 readonly Microsoft.CodeAnalysis.Diagnostics.AnalyzerLoadFailureEventArgs.TypeName -> string
-static Microsoft.CodeAnalysis.AssemblyIdentityExtensions.ToAssemblyName(this Microsoft.CodeAnalysis.AssemblyIdentity identity) -> System.Reflection.AssemblyName
 static Microsoft.CodeAnalysis.CommandLineParser.SplitCommandLineIntoArguments(string commandLine, bool removeHashComments) -> System.Collections.Generic.IEnumerable<string>
 static Microsoft.CodeAnalysis.DesktopAssemblyIdentityComparer.LoadFromXml(System.IO.Stream input) -> Microsoft.CodeAnalysis.DesktopAssemblyIdentityComparer
 static Microsoft.CodeAnalysis.FileSystemExtensions.Emit(this Microsoft.CodeAnalysis.Compilation compilation, string outputPath, string pdbPath = null, string xmlDocPath = null, string win32ResourcesPath = null, System.Collections.Generic.IEnumerable<Microsoft.CodeAnalysis.ResourceDescription> manifestResources = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> Microsoft.CodeAnalysis.Emit.EmitResult

src/Compilers/Core/Desktop/AssemblyIdentityExtensions.cs → src/Compilers/Helpers/AssemblyIdentityExtensions.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.CodeAnalysis
 {
-    public static class AssemblyIdentityExtensions
+    internal static class AssemblyIdentityExtensions
     {
         // CultureInfo is not portable.
 

src/Scripting/Core/Scripting.csproj

@@ -27,6 +27,9 @@
     <Compile Include="..\..\Compilers\Helpers\InMemoryAssemblyProvider.cs">
       <Link>InMemoryAssemblyProvider.cs</Link>
     </Compile>
+    <Compile Include="..\..\Compilers\Helpers\AssemblyIdentityExtensions.cs">
+      <Link>InMemoryAssemblyProvider.cs</Link>
+    </Compile>
   </ItemGroup>
   <ItemGroup Label="Project References">
     <ProjectReference Include="..\..\Compilers\Core\Desktop\CodeAnalysis.Desktop.csproj">

src/Workspaces/Core/Desktop/Workspaces.Desktop.csproj

@@ -85,6 +85,9 @@
     <Compile Include="..\..\..\Compilers\Helpers\GlobalAssemblyCacheHelpers\GacFileResolver.cs">
       <Link>InternalUtilities\GacFileResolver.cs</Link>
     </Compile>
+    <Compile Include="..\..\..\Compilers\Helpers\AssemblyIdentityExtensions.cs">
+      <Link>InternalUtilities\AssemblyIdentityExtensions.cs</Link>
+    </Compile>
     <Compile Include="Options\ExportOptionAttribute.cs" />
     <Compile Include="InternalUtilities\FilePathUtilities.cs" />
     <Compile Include="Log\EtwLogger.cs" />
@@ -176,4 +179,4 @@
     <Import Project="..\..\..\..\build\VSL.Imports.Closed.targets" />
     <Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" />
   </ImportGroup>
-</Project>
\ No newline at end of file
+</Project>