Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
3640ed98
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
3640ed98
编写于
2月 09, 2018
作者:
M
Martin Strecker
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Check if IMethodSymbol might have cascading declarations.
上级
e5a00c2c
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
88 addition
and
3 deletion
+88
-3
src/EditorFeatures/CSharpTest/AddParameter/AddParameterTests.cs
...itorFeatures/CSharpTest/AddParameter/AddParameterTests.cs
+38
-0
src/Features/Core/Portable/AddParameter/AbstractAddParameterCodeFixProvider.cs
...table/AddParameter/AbstractAddParameterCodeFixProvider.cs
+50
-3
未找到文件。
src/EditorFeatures/CSharpTest/AddParameter/AddParameterTests.cs
浏览文件 @
3640ed98
...
...
@@ -1696,5 +1696,43 @@ public class T
</Workspace>"
;
await
TestInRegularAndScriptAsync
(
code
,
fix
);
}
[
WorkItem
(
21446
,
"https://github.com/dotnet/roslyn/issues/21446"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsAddParameter
)]
public
async
Task
TestInvocation_Cascading_OfferFixCascadingForImplicitInterface
()
{
// error CS1501: No overload for method 'M1' takes 1 arguments
var
code
=
@"
interface I1
{
void M1();
}
class C: I1
{
public void M1() { }
void MTest()
{
[|M1|](1);
}
}
"
;
var
fix0
=
@"
interface I1
{
void M1(int v);
}
class C: I1
{
public void M1(int v) { }
void MTest()
{
M1(1);
}
}
"
;
await
TestInRegularAndScriptAsync
(
code
,
fix0
);
}
}
}
src/Features/Core/Portable/AddParameter/AbstractAddParameterCodeFixProvider.cs
浏览文件 @
3640ed98
...
...
@@ -152,9 +152,8 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
var
methodToUpdate
=
argumentInsertPositionData
.
MethodToUpdate
;
var
argumentToInsert
=
argumentInsertPositionData
.
ArgumentToInsert
;
var
parameters
=
methodToUpdate
.
Parameters
.
Select
(
p
=>
p
.
ToDisplayString
(
SimpleFormat
));
var
signature
=
$"
{
methodToUpdate
.
Name
}
(
{
string
.
Join
(
", "
,
parameters
)}
)"
;
var
title
=
string
.
Format
(
FeaturesResources
.
Add_parameter_to_0
,
signature
);
var
title
=
GetCodeFixTitle
(
methodToUpdate
,
parameters
);
var
hasCascadingDeclarations
=
HasCascadingDeclarations
(
methodToUpdate
);
context
.
RegisterCodeFix
(
new
MyCodeAction
(
title
,
c
=>
FixAsync
(
context
.
Document
,
methodToUpdate
,
argumentToInsert
,
arguments
,
c
)),
...
...
@@ -162,6 +161,54 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
}
}
/// <summary>
/// Checks if there are indications that there might be more than one declaration that needs to be fixed.
/// The check does not look-up if there are other declarations (this is done later in the CodeAction).
/// </summary>
/// <param name="method"></param>
/// <returns></returns>
private
bool
HasCascadingDeclarations
(
IMethodSymbol
method
)
{
// Virtual methods of all kinds might have overrides somewhere else that need to be fixed.
if
(
method
.
IsVirtual
||
method
.
IsOverride
||
method
.
IsAbstract
)
{
return
true
;
}
// If interfaces are involved we will fix those too
// Explicit interface implementations are easy
if
(
method
.
ExplicitInterfaceImplementations
.
Length
>
0
)
{
return
true
;
}
// For implicit interface implementations lets check if the characteristic of the method
// allows it to implicit implement an interface member.
if
(
method
.
DeclaredAccessibility
==
Accessibility
.
Private
||
method
.
DeclaredAccessibility
==
Accessibility
.
NotApplicable
)
{
return
false
;
}
if
(
method
.
IsStatic
)
{
return
false
;
}
// Now check if the method does implement an interface member
var
containingType
=
method
.
ContainingType
;
var
allMethodsInAllInterfaces
=
containingType
.
AllInterfaces
.
SelectMany
(
i
=>
i
.
GetMembers
(
method
.
Name
));
var
isMethodImplementingAnInterfaceMember
=
allMethodsInAllInterfaces
.
Any
(
methodInInterface
=>
containingType
.
FindImplementationForInterfaceMember
(
methodInInterface
)
==
method
);
return
isMethodImplementingAnInterfaceMember
;
}
private
static
string
GetCodeFixTitle
(
IMethodSymbol
methodToUpdate
,
IEnumerable
<
string
>
parameters
)
{
var
signature
=
$"
{
methodToUpdate
.
Name
}
(
{
string
.
Join
(
", "
,
parameters
)}
)"
;
var
title
=
string
.
Format
(
FeaturesResources
.
Add_parameter_to_0
,
signature
);
return
title
;
}
private
ImmutableArray
<
ArgumentInsertPositionData
<
TArgumentSyntax
>>
GetArgumentInsertPositionForMethodCandidates
(
TArgumentSyntax
argumentOpt
,
SemanticModel
semanticModel
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录