Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
345ee8ef
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
345ee8ef
编写于
5月 15, 2019
作者:
S
Sam Harwell
提交者:
GitHub
5月 15, 2019
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #35483 from sharwell/analyzer-patterns
Update analyzers to follow recommended patterns
上级
f36dfa52
d2961e12
变更
9
隐藏空白更改
内联
并排
Showing
9 changed file
with
30 addition
and
1 deletion
+30
-1
eng/config/rulesets/NonShipping.ruleset
eng/config/rulesets/NonShipping.ruleset
+6
-0
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs
...Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs
+3
-0
src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs
...tation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs
+7
-1
src/Features/Core/Portable/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs
...table/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs
+4
-0
src/Features/Core/Portable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs
...rtable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs
+4
-0
src/Features/Core/Portable/Diagnostics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs
...ics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs
+1
-0
src/Features/Core/Portable/EmbeddedLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs
...edLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs
+3
-0
src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
...rts/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
+1
-0
src/Features/Core/Portable/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
...tString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
+1
-0
未找到文件。
eng/config/rulesets/NonShipping.ruleset
浏览文件 @
345ee8ef
...
@@ -32,6 +32,12 @@
...
@@ -32,6 +32,12 @@
<!-- DiagnosticId must be unique across analyzers - suppress for non-shipping/test projects -->
<!-- DiagnosticId must be unique across analyzers - suppress for non-shipping/test projects -->
<Rule
Id=
"RS1019"
Action=
"None"
/>
<Rule
Id=
"RS1019"
Action=
"None"
/>
<!-- Configure generated code analysis - suppress for non-shipping/test projects -->
<Rule
Id=
"RS1025"
Action=
"None"
/>
<!-- Enable concurrent execution - suppress for non-shipping/test projects -->
<Rule
Id=
"RS1026"
Action=
"None"
/>
<!-- Do not use generic CodeAction.Create to create CodeAction - not useful for tests -->
<!-- Do not use generic CodeAction.Create to create CodeAction - not useful for tests -->
<Rule
Id=
"RS0005"
Action=
"None"
/>
<Rule
Id=
"RS0005"
Action=
"None"
/>
</Rules>
</Rules>
...
...
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -35,6 +35,9 @@ public sealed override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
...
@@ -35,6 +35,9 @@ public sealed override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
public
sealed
override
void
Initialize
(
AnalysisContext
context
)
public
sealed
override
void
Initialize
(
AnalysisContext
context
)
{
{
context
.
EnableConcurrentExecution
();
context
.
ConfigureGeneratedCodeAnalysis
(
GeneratedCodeAnalysisFlags
.
Analyze
|
GeneratedCodeAnalysisFlags
.
ReportDiagnostics
);
context
.
RegisterCompilationStartAction
(
c
=>
context
.
RegisterCompilationStartAction
(
c
=>
{
{
var
analyzer
=
new
CompilationAnalyzer
(
c
.
Compilation
);
var
analyzer
=
new
CompilationAnalyzer
(
c
.
Compilation
);
...
...
src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -26,8 +26,14 @@ public DiagnosticAnalyzerCategory GetAnalyzerCategory()
...
@@ -26,8 +26,14 @@ public DiagnosticAnalyzerCategory GetAnalyzerCategory()
public
bool
OpenFileOnly
(
Workspace
workspace
)
public
bool
OpenFileOnly
(
Workspace
workspace
)
=>
true
;
=>
true
;
#pragma warning disable RS1026 // Enable concurrent execution
public
override
void
Initialize
(
AnalysisContext
context
)
public
override
void
Initialize
(
AnalysisContext
context
)
=>
context
.
RegisterSyntaxTreeAction
(
AnalyzeSyntaxTree
);
#pragma warning restore RS1026 // Enable concurrent execution
{
context
.
ConfigureGeneratedCodeAnalysis
(
GeneratedCodeAnalysisFlags
.
Analyze
|
GeneratedCodeAnalysisFlags
.
ReportDiagnostics
);
context
.
RegisterSyntaxTreeAction
(
AnalyzeSyntaxTree
);
}
private
void
AnalyzeSyntaxTree
(
SyntaxTreeAnalysisContext
context
)
private
void
AnalyzeSyntaxTree
(
SyntaxTreeAnalysisContext
context
)
{
{
...
...
src/Features/Core/Portable/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -20,7 +20,11 @@ internal abstract class DocumentDiagnosticAnalyzer : DiagnosticAnalyzer
...
@@ -20,7 +20,11 @@ internal abstract class DocumentDiagnosticAnalyzer : DiagnosticAnalyzer
/// <summary>
/// <summary>
/// it is not allowed one to implement both DocumentDiagnosticAnalzyer and DiagnosticAnalyzer
/// it is not allowed one to implement both DocumentDiagnosticAnalzyer and DiagnosticAnalyzer
/// </summary>
/// </summary>
#pragma warning disable RS1026 // Enable concurrent execution
#pragma warning disable RS1025 // Configure generated code analysis
public
sealed
override
void
Initialize
(
AnalysisContext
context
)
public
sealed
override
void
Initialize
(
AnalysisContext
context
)
#pragma warning restore RS1025 // Configure generated code analysis
#pragma warning restore RS1026 // Enable concurrent execution
{
{
}
}
...
...
src/Features/Core/Portable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -18,7 +18,11 @@ internal abstract class ProjectDiagnosticAnalyzer : DiagnosticAnalyzer
...
@@ -18,7 +18,11 @@ internal abstract class ProjectDiagnosticAnalyzer : DiagnosticAnalyzer
/// <summary>
/// <summary>
/// it is not allowed one to implement both ProjectDiagnosticAnalzyer and DiagnosticAnalyzer
/// it is not allowed one to implement both ProjectDiagnosticAnalzyer and DiagnosticAnalyzer
/// </summary>
/// </summary>
#pragma warning disable RS1026 // Enable concurrent execution
#pragma warning disable RS1025 // Configure generated code analysis
public
sealed
override
void
Initialize
(
AnalysisContext
context
)
public
sealed
override
void
Initialize
(
AnalysisContext
context
)
#pragma warning restore RS1025 // Configure generated code analysis
#pragma warning restore RS1026 // Enable concurrent execution
{
{
}
}
...
...
src/Features/Core/Portable/Diagnostics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs
浏览文件 @
345ee8ef
...
@@ -26,6 +26,7 @@ internal abstract class UnboundIdentifiersDiagnosticAnalyzerBase<TLanguageKindEn
...
@@ -26,6 +26,7 @@ internal abstract class UnboundIdentifiersDiagnosticAnalyzerBase<TLanguageKindEn
public
override
void
Initialize
(
AnalysisContext
context
)
public
override
void
Initialize
(
AnalysisContext
context
)
{
{
context
.
EnableConcurrentExecution
();
context
.
EnableConcurrentExecution
();
context
.
ConfigureGeneratedCodeAnalysis
(
GeneratedCodeAnalysisFlags
.
Analyze
|
GeneratedCodeAnalysisFlags
.
ReportDiagnostics
);
context
.
RegisterSyntaxNodeAction
(
AnalyzeNode
,
this
.
SyntaxKindsOfInterest
.
ToArray
());
context
.
RegisterSyntaxNodeAction
(
AnalyzeNode
,
this
.
SyntaxKindsOfInterest
.
ToArray
());
}
}
...
...
src/Features/Core/Portable/EmbeddedLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -53,6 +53,9 @@ public bool OpenFileOnly(Workspace workspace)
...
@@ -53,6 +53,9 @@ public bool OpenFileOnly(Workspace workspace)
public
override
void
Initialize
(
AnalysisContext
context
)
public
override
void
Initialize
(
AnalysisContext
context
)
{
{
context
.
EnableConcurrentExecution
();
context
.
ConfigureGeneratedCodeAnalysis
(
GeneratedCodeAnalysisFlags
.
Analyze
|
GeneratedCodeAnalysisFlags
.
ReportDiagnostics
);
foreach
(
var
analyzer
in
_analyzers
)
foreach
(
var
analyzer
in
_analyzers
)
{
{
analyzer
.
Initialize
(
context
);
analyzer
.
Initialize
(
context
);
...
...
src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -73,6 +73,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
...
@@ -73,6 +73,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
public
override
void
Initialize
(
AnalysisContext
context
)
public
override
void
Initialize
(
AnalysisContext
context
)
{
{
context
.
EnableConcurrentExecution
();
context
.
EnableConcurrentExecution
();
context
.
ConfigureGeneratedCodeAnalysis
(
GeneratedCodeAnalysisFlags
.
Analyze
|
GeneratedCodeAnalysisFlags
.
ReportDiagnostics
);
context
.
RegisterSemanticModelAction
(
this
.
AnalyzeSemanticModel
);
context
.
RegisterSemanticModelAction
(
this
.
AnalyzeSemanticModel
);
}
}
...
...
src/Features/Core/Portable/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
浏览文件 @
345ee8ef
...
@@ -65,6 +65,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
...
@@ -65,6 +65,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
public
override
void
Initialize
(
AnalysisContext
context
)
public
override
void
Initialize
(
AnalysisContext
context
)
{
{
context
.
EnableConcurrentExecution
();
context
.
EnableConcurrentExecution
();
context
.
ConfigureGeneratedCodeAnalysis
(
GeneratedCodeAnalysisFlags
.
Analyze
|
GeneratedCodeAnalysisFlags
.
ReportDiagnostics
);
context
.
RegisterCompilationStartAction
(
startContext
=>
context
.
RegisterCompilationStartAction
(
startContext
=>
{
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录