提交 32723672 编写于 作者: A Andrew Casey

Remove my alias from all TODOs.

上级 5b08d9b3
......@@ -156,7 +156,7 @@ internal sealed class EvaluationContext : EvaluationContextBase
{
try
{
// TODO (acasey): switch on the type of typedSymReader and call the appropriate helper. (GH #702)
// TODO (https://github.com/dotnet/roslyn/issues/702): switch on the type of typedSymReader and call the appropriate helper.
methodDebugInfo = typedSymReader.GetMethodDebugInfo(methodToken, methodVersion, localNames.FirstOrDefault());
inScopeHoistedLocalIndices = methodDebugInfo.GetInScopeHoistedLocalIndices(ilOffset, ref methodContextReuseConstraints);
}
......
......@@ -107,6 +107,6 @@ internal static class SymUnmanagedReaderExtensions
defaultNamespaceName: ""); // Unused in C#.
}
// TODO (acasey): overload for portable format (GH #702)
// TODO (https://github.com/dotnet/roslyn/issues/702): overload for portable format
}
}
\ No newline at end of file
......@@ -36,7 +36,7 @@ internal sealed class PortableImportRecord : ImportRecord
_targetNamespaceName = targetNamespaceName;
}
// TODO (acasey): Uncomment when ImportDefinition is available in this branch. (GH #702)
// TODO (https://github.com/dotnet/roslyn/issues/702): Uncomment when ImportDefinition is available in this branch.
//public static bool TryCreateFromImportDefinition(
// ImportDefinition importDefinition,
// MetadataReader metadataReader,
......
......@@ -28,7 +28,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator
_inspectionContext = inspectionContext
_typeNameDecoder = typeNameDecoder
_containingMethod = containingMethod
' TODO (acasey): pass comparer (GH #878). Until then, there is no need for a comparer,
' TODO (https://github.com/dotnet/roslyn/issues/878): pass comparer. Until then, there is no need for a comparer,
' since we're going to canonicalize all names.
_implicitDeclarations = If(allowImplicitDeclarations, New Dictionary(Of String, LocalSymbol)(), Nothing)
End Sub
......@@ -45,7 +45,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator
Return
End If
' TODO (acasey): use name (GH #878)
' TODO (https://github.com/dotnet/roslyn/issues/878): use name
Dim canonicalName = Canonicalize(name)
Dim local As LocalSymbol = Nothing
......@@ -76,7 +76,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator
Dim typeChar As String = Nothing
Dim specialType = GetSpecialTypeForTypeCharacter(identifier.GetTypeCharacter(), typeChar)
Dim type = Compilation.GetSpecialType(If(specialType = SpecialType.None, SpecialType.System_Object, specialType))
' TODO (acasey): don't canonicalize name (GH #878)
' TODO (https://github.com/dotnet/roslyn/issues/878): don't canonicalize name
Dim canonicalName = Canonicalize(identifier.GetIdentifierText())
Dim local = LocalSymbol.Create(
_containingMethod,
......
......@@ -163,7 +163,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator
If IsDteeEntryPoint(currentFrame) Then
methodDebugInfo = SynthesizeMethodDebugInfoForDtee(lazyAssemblyReaders.Value)
ElseIf typedSymReader IsNot Nothing Then
' TODO (acasey): Switch on the type of typedSymReader and call the appropriate helper. (GH #702)
' TODO (https://github.com/dotnet/roslyn/issues/702): Switch on the type of typedSymReader and call the appropriate helper.
methodDebugInfo = typedSymReader.GetMethodDebugInfo(methodToken, methodVersion)
Else
methodDebugInfo = Nothing
......
......@@ -73,7 +73,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator
projectLevelImportRecords.ToImmutableAndFree(),
fileLevelImportRecords.ToImmutableAndFree())
' TODO (acasey): portable format overload (GH #702)
' TODO (https://github.com/dotnet/roslyn/issues/702): portable format overload
' Somehow construct hoistedLocalScopeRecords.
Dim hoistedLocalScopeRecords = ImmutableArray(Of HoistedLocalScopeRecord).Empty
......@@ -86,6 +86,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator
dynamicLocalConstantMap:=ImmutableDictionary(Of String, ImmutableArray(Of Boolean)).Empty)
End Function
' TODO (acasey): portable format overload (GH #702)
' TODO (https://github.com/dotnet/roslyn/issues/702): portable format overload
End Module
End Namespace
......@@ -462,7 +462,7 @@ End Class"
expr:="$ReturnValue(Of Object)",
resultProperties:=resultProperties,
errorMessage:=errorMessage)
' TODO (acasey): don't canonicalize name (GH #878)
' TODO (https://github.com/dotnet/roslyn/issues/878): don't canonicalize name
Assert.Equal("(1) : error BC32045: '$returnvalue' has no type parameters and so cannot have type arguments.", errorMessage)
Const source = "
......
......@@ -464,7 +464,7 @@ public static ImmutableArray<string> GetVisualBasicImportStrings(this ISymUnmana
return importStrings;
}
// TODO (acasey): caller should depend on abstraction (GH #702)
// TODO (https://github.com/dotnet/roslyn/issues/702): caller should depend on abstraction
/// <exception cref="InvalidOperationException">Bad data.</exception>
public static void GetCSharpDynamicLocalInfo(
byte[] customDebugInfo,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册