PR feedback

src/Compilers/Core/Portable/Diagnostic/DiagnosticInfo.cs

@@ -138,7 +138,7 @@ internal DiagnosticInfo GetInstanceWithSeverity(DiagnosticSeverity severity)
 
         #region Serialization
 
-        bool IObjectWritable.ShouldReuseInSerialization => true;
+        bool IObjectWritable.ShouldReuseInSerialization => false;
 
         void IObjectWritable.WriteTo(ObjectWriter writer)
         {

src/Compilers/Core/Portable/Diagnostic/LocalizableResourceString.cs

@@ -93,7 +93,7 @@ private LocalizableResourceString(ObjectReader reader)
             }
         }
 
-        bool IObjectWritable.ShouldReuseInSerialization => true;
+        bool IObjectWritable.ShouldReuseInSerialization => false;
 
         void IObjectWritable.WriteTo(ObjectWriter writer)
         {

src/Compilers/Core/Portable/Serialization/IObjectWritable.cs

@@ -11,8 +11,8 @@ internal interface IObjectWritable
         void WriteTo(ObjectWriter writer);
 
         /// <summary>
-        /// Returns `true` when the same instance could be used more than once.
-        /// Instances that return "false" should not be tracked or the purpose 
+        /// Returns 'true' when the same instance could be used more than once.
+        /// Instances that return 'false' should not be tracked for the purpose 
         /// of de-duplication while serializing/deserializing.
         /// </summary>
         bool ShouldReuseInSerialization { get; }

src/Compilers/Core/Portable/Serialization/ObjectBinderSnapshot.cs

@@ -6,7 +6,7 @@
 
 namespace Roslyn.Utilities
 {
-    internal struct ObjectBinderSnapshot
+    internal readonly struct ObjectBinderSnapshot
     {
         private readonly Dictionary<Type, int> _typeToIndex;
         private readonly ImmutableArray<Type> _types;

src/Compilers/VisualBasic/Portable/Errors/MessageProvider.vb

@@ -18,7 +18,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
         Private Sub New()
         End Sub
 
-        Private ReadOnly Property IsReausable As Boolean Implements IObjectWritable.ShouldReuseInSerialization
+        Private ReadOnly Property IObjectWritable_ShouldReuseInSerialization As Boolean Implements IObjectWritable.ShouldReuseInSerialization
             Get
                 Return True
             End Get

src/Compilers/VisualBasic/Portable/Syntax/InternalSyntax/SyntaxToken.vb

@@ -89,7 +89,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax.InternalSyntax
                 Me._trailingTrivia = DirectCast(reader.ReadValue(), GreenNode)
             End Sub
 
-            Private ReadOnly Property IsReausable As Boolean Implements IObjectWritable.ShouldReuseInSerialization
+            Private ReadOnly Property IObjectWritable_ShouldReuseInSerialization As Boolean Implements IObjectWritable.ShouldReuseInSerialization
                 Get
                     Return ShouldCacheTriviaInfo(_leadingTrivia, _trailingTrivia)
                 End Get