Fix violations for IDE0036 (Order modifiers) and IDE0040 (Add accessibility modifiers)

src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialogViewModel.cs

@@ -149,7 +149,7 @@ private void UpdateNameConflictMarkers()
         public AddParameterDialogViewModel CreateAddParameterDialogViewModel()
             => new AddParameterDialogViewModel(_document, _positionForTypeBinding);
 
-        List<ParameterViewModel> CreateParameterViewModels(ImmutableArray<Parameter> parameters, ref int initialIndex)
+        private List<ParameterViewModel> CreateParameterViewModels(ImmutableArray<Parameter> parameters, ref int initialIndex)
         {
             var list = new List<ParameterViewModel>();
             foreach (ExistingParameter existingParameter in parameters)

src/VisualStudio/Core/Def/Implementation/CodeModel/ICodeModelInstanceFactory.cs

@@ -10,7 +10,7 @@
 
 namespace Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel
 {
-    interface ICodeModelInstanceFactory
+    internal interface ICodeModelInstanceFactory
     {
         /// <summary>
         /// Requests the project system to create a <see cref="EnvDTE.FileCodeModel"/> through the project system.

src/VisualStudio/Core/Def/Implementation/LanguageClient/VisualStudioLspSolutionProvider.cs

@@ -17,7 +17,7 @@
 namespace Microsoft.VisualStudio.LanguageServices.Implementation.LanguageClient
 {
     [Export(typeof(ILspSolutionProvider)), Shared]
-    class VisualStudioLspSolutionProvider : ILspSolutionProvider
+    internal class VisualStudioLspSolutionProvider : ILspSolutionProvider
     {
         private readonly VisualStudioWorkspace _visualStudioWorkspace;
         private readonly MiscellaneousFilesWorkspace _miscellaneousFilesWorkspace;

src/VisualStudio/Core/Def/Implementation/Preview/ChangeList.cs

@@ -9,7 +9,7 @@ namespace Microsoft.VisualStudio.LanguageServices.Implementation.Preview
 {
     internal partial class ChangeList : IVsPreviewChangesList, IVsLiteTreeList
     {
-        public readonly static ChangeList Empty = new ChangeList(Array.Empty<AbstractChange>());
+        public static readonly ChangeList Empty = new ChangeList(Array.Empty<AbstractChange>());
 
         internal AbstractChange[] Changes { get; }
 

src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioWorkspaceImpl.OpenFileTracker.cs

@@ -110,7 +110,7 @@ void IRunningDocumentTableEventListener.OnRenameDocument(string newMoniker, stri
             {
             }
 
-            public async static Task<OpenFileTracker> CreateAsync(VisualStudioWorkspaceImpl workspace, IAsyncServiceProvider asyncServiceProvider)
+            public static async Task<OpenFileTracker> CreateAsync(VisualStudioWorkspaceImpl workspace, IAsyncServiceProvider asyncServiceProvider)
             {
                 var runningDocumentTable = (IVsRunningDocumentTable)await asyncServiceProvider.GetServiceAsync(typeof(SVsRunningDocumentTable)).ConfigureAwait(true);
                 var componentModel = (IComponentModel)await asyncServiceProvider.GetServiceAsync(typeof(SComponentModel)).ConfigureAwait(true);

src/VisualStudio/Core/Test/ObjectBrowser/Helpers.vb

@@ -17,7 +17,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ObjectBrowser
             Private ReadOnly _workspace As TestWorkspace
             Private ReadOnly _libraryManager As AbstractObjectBrowserLibraryManager
 
-            Sub New(workspace As TestWorkspace, libraryManager As AbstractObjectBrowserLibraryManager)
+            Public Sub New(workspace As TestWorkspace, libraryManager As AbstractObjectBrowserLibraryManager)
                 _workspace = workspace
                 _libraryManager = libraryManager
             End Sub

src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpF1Help.cs

@@ -22,7 +22,7 @@ public CSharpF1Help(VisualStudioInstanceFactory instanceFactory, ITestOutputHelp
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.F1Help)]
-        void F1Help()
+        private void F1Help()
         {
             var text = @"
 using System;

src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicF1Help.cs

@@ -22,7 +22,7 @@ public BasicF1Help(VisualStudioInstanceFactory instanceFactory, ITestOutputHelpe
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.F1Help)]
-        void F1Help()
+        private void F1Help()
         {
             var text = @"
 Imports System

src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicLineCommit.cs

@@ -24,7 +24,7 @@ public BasicLineCommit(VisualStudioInstanceFactory instanceFactory, ITestOutputH
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.LineCommit)]
-        void CaseCorrection()
+        private void CaseCorrection()
         {
             VisualStudio.Editor.SetText(@"Module Goo
     Sub M()
@@ -38,7 +38,7 @@ End Sub
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.LineCommit)]
-        void UndoWithEndConstruct()
+        private void UndoWithEndConstruct()
         {
             VisualStudio.Editor.SetText(@"Module Module1
     Sub Main()
@@ -56,7 +56,7 @@ End Sub
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.LineCommit)]
-        void UndoWithoutEndConstruct()
+        private void UndoWithoutEndConstruct()
         {
             VisualStudio.Editor.SetText(@"Module Module1
 
@@ -80,7 +80,7 @@ End Sub
         }
 
         [WpfFact(Skip = "https://github.com/dotnet/roslyn/issues/34637"), Trait(Traits.Feature, Traits.Features.LineCommit)]
-        void CommitOnSave()
+        private void CommitOnSave()
         {
             VisualStudio.Editor.SetText(@"Module Module1
     Sub Main()
@@ -98,7 +98,7 @@ End Module
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.LineCommit)]
-        void CommitOnFocusLost()
+        private void CommitOnFocusLost()
         {
             VisualStudio.Editor.SetText(@"Module M
     Sub M()
@@ -118,7 +118,7 @@ End Sub
         }
 
         [WpfFact, Trait(Traits.Feature, Traits.Features.LineCommit)]
-        void CommitOnFocusLostDoesNotFormatWithPrettyListingOff()
+        private void CommitOnFocusLostDoesNotFormatWithPrettyListingOff()
         {
             try
             {

src/VisualStudio/IntegrationTest/TestUtilities/InProcess/MoveToNamespaceDialog_InProc.cs

@@ -9,7 +9,7 @@
 
 namespace Microsoft.VisualStudio.IntegrationTest.Utilities.InProcess
 {
-    class MoveToNamespaceDialog_InProc : AbstractCodeRefactorDialog_InProc<MoveToNamespaceDialog, MoveToNamespaceDialog.TestAccessor>
+    internal class MoveToNamespaceDialog_InProc : AbstractCodeRefactorDialog_InProc<MoveToNamespaceDialog, MoveToNamespaceDialog.TestAccessor>
     {
         private MoveToNamespaceDialog_InProc()
         {

src/VisualStudio/IntegrationTest/TestUtilities/InProcess/VisualStudio_InProc.cs

@@ -20,13 +20,13 @@ public static VisualStudio_InProc Create()
         public new void WaitForApplicationIdle(TimeSpan timeout)
             => InProcComponent.WaitForApplicationIdle(timeout);
 
-        new public void WaitForSystemIdle()
+        public new void WaitForSystemIdle()
             => InProcComponent.WaitForSystemIdle();
 
-        new public bool IsCommandAvailable(string commandName)
+        public new bool IsCommandAvailable(string commandName)
             => InProcComponent.IsCommandAvailable(commandName);
 
-        new public void ExecuteCommand(string commandName, string args = "")
+        public new void ExecuteCommand(string commandName, string args = "")
             => InProcComponent.ExecuteCommand(commandName, args);
 
         public string[] GetAvailableCommands()

src/VisualStudio/LiveShare/Impl/Client/Projects/IRemoteProjectInfoProvider.cs

@@ -9,7 +9,7 @@
 
 namespace Microsoft.VisualStudio.LanguageServices.LiveShare.Client.Projects
 {
-    interface IRemoteProjectInfoProvider
+    internal interface IRemoteProjectInfoProvider
     {
         Task<ImmutableArray<ProjectInfo>> GetRemoteProjectInfosAsync(CancellationToken cancellationToken);
     }

src/VisualStudio/LiveShare/Impl/LiveShareConstants.cs

@@ -4,7 +4,7 @@
 
 namespace Microsoft.VisualStudio.LanguageServices.LiveShare
 {
-    class LiveShareConstants
+    internal class LiveShareConstants
     {
         // The service name for an LSP server implemented using Roslyn designed to be used with the Roslyn client
         public const string RoslynContractName = "Roslyn";

src/VisualStudio/TestUtilities2/CodeModel/CodeModelTestHelpers.vb

@@ -29,7 +29,9 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.CodeModel
         Public SystemWindowsFormsPath As String
         Public SystemDrawingPath As String
 
+#Disable Warning IDE0040 ' Add accessibility modifiers - https://github.com/dotnet/roslyn/issues/45962
         Sub New()
+#Enable Warning IDE0040 ' Add accessibility modifiers
             SystemWindowsFormsPath = GetType(System.Windows.Forms.Form).Assembly.Location
             SystemDrawingPath = GetType(System.Drawing.Point).Assembly.Location
         End Sub

src/VisualStudio/TestUtilities2/VisualStudioTestExportProvider.vb

@@ -13,7 +13,9 @@ Imports Microsoft.CodeAnalysis.Editor.UnitTests
 
 Namespace Microsoft.VisualStudio.LanguageServices.UnitTests
     Public Module VisualStudioTestExportProvider
+#Disable Warning IDE0040 ' Add accessibility modifiers - https://github.com/dotnet/roslyn/issues/45962
         Sub New()
+#Enable Warning IDE0040 ' Add accessibility modifiers
             Dim additionalAssemblies = {GetType(CSharpCodeModelService).Assembly,
                                         GetType(VisualBasicCodeModelService).Assembly}